feat(reports): leftover-map distance on grouping comparison graphic (v2.76.0) - #859
Conversation
…v2.76.0)
Caption persisted leftover-map distance d on the grouping
comparison leftover-map graphic from already-named leftover_distance
(ADR 0319). Comparison copy uses leftover map comparison graphic leftover-map
distance {label} so it stays distinct from leftover-map distance {label}.
A missing or non-finite d omits that caption and keeps leftover-map rank,
leftover expected, leftover observed, leftover residual, leftover-map unexplained leftover,
leftover-map reconstruction, and comparison graphic coverage notes.
Rank-0 origin cells still name d 0.00 when that leftover-map distance is finite.
Do not caption leftover-map coordinate ticks this increment.
Do not invent leftover-map distance from plotted coordinates. Never invent a leftover score.
Never invent a theta. No new columns.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact head |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Cycle 2026-08-31T00:18Z. Exact head Next buyer increment (explicitly deferred in ADR 0319): leftover-map coordinate ticks on the grouping comparison leftover-map graphic with a distinct comparison-graphic accessible name (ADR 0320 / v2.77.0), stacked on this head. Period-report ticks already sit through ADR 0270. Do not invent leftover-map distance from plotted coordinates. Never invent a leftover score. Never invent a theta. No new columns. Synthetic fixtures only. |
|
Cycle 2026-08-31T00:28Z. Exact head |
seonghobae
added
enhancement
ChatGPT Codex Connector
Adopt exact reconstructed #858 as the current tree while preserving historical #859 as first parent. Retain the v2.76 distance product delta as executable RED: the comparison graphic must name persisted leftover_distance with distinct comparison copy, omit only missing/non-finite evidence, preserve finite zero/signed values, and never derive distance from plot geometry. Exact #858 is the second parent. No force update or destructive rebase.
Adopt exact reconstructed #859 as the current tree while preserving historical #860 as first parent. Retain the v2.77 coordinate-tick product delta as executable RED: comparison ticks need distinct accessible copy and must come only from the origin plus persisted ξ/ζ projections, never from leftover distance or fabricated spacing. Exact #859 is the second parent. No force update or destructive rebase.
Adopt exact repaired #858 head 0a10ded without force-updating or replaying stale historical source. Preserve the existing #859 reconstruction as first parent, carry its executable distance RED unchanged, and take the repaired #858 tree as the second parent so the descendant no longer drops the rank accessible-name fix.
1 participant
Summary
Caption persisted leftover-map distance
don the grouping-comparison leftover-map graphic from already-namedleftover_distance(ADR 0319 / v2.76.0), without adding a comparison-only static translation key.Current exact authority
d207b04ff3a44ff66e995c7435328cbfba5b07a98d6e5ac52abce56eae53b80c0586c51f7e81881cProposedRED → causal product repair
The predecessor contract incorrectly demanded a new English-only
LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_DISTANCE, repeating localization debt already found and repaired in #858. The contract now rejects that dedicated key and requires composition of the already-localized comparison-graphic label with the already-localized generic distance label.Production
LeftoverMapPlotuses that composition only forvariant="comparison"; report rendering keeps its existing generic distance accessible name. The exact current production expression is${t(LEFTOVER_MAP_COMPARE_PLOT_LABEL)}: ${tf(LEFTOVER_MAP_PLOT_SEGMENT_DISTANCE, { label })}, so the English current-head accessible name isLeftover map comparison graphic: leftover-map distance d ….leftoverMapDistanceLocalization.test.tsverifies ko/zh/ja/vi behavior and runtimedsubstitution. Distance still comes only from persistedpair.leftover_distancethrough the fail-closed formatter: missing/non-finite omits the caption, finite zero/signed values remain data-driven and unclamped.Current exact-head validation / remaining RED
Tests run
34661368261is authoritative for this head.103464435638: terminal GREEN103464435494: lint GREEN; Test RED; build/Storybook skipped after Test REDleftoverMapDistanceLocalization.test.tsandleftoverMapRankLocalization.test.tsare GREENfrontend/src/components/LeftoverMapPlot.test.tsxat the comparison-only omission cases around lines 1278, 1394, 1520, 1656, 1802, 1958, 2123, and 2294. Each still demands the old report-only exact nameleftover-map distance d …even though the intentional comparison accessible name isLeftover map comparison graphic: leftover-map distance d ….The report-variant assertions near the start of the same file remain correct and must not change. This is a stale executable consumer-test contract, not a reason to revert the localized comparison name, add an English-only alias, add hidden duplicate accessible nodes, loosen assertions, or weaken a11y semantics. The minimal causal fix is to migrate only those eight comparison-variant expectation pairs, then rerun exact-head frontend lint/test/build/Storybook; a new head must receive fresh repository/security/browser/a11y/performance evidence before promotion.
The complete current
LeftoverMapPlot.test.tsxblob2ac6230131579c8dccf4d202a821a3d1cdb4ff1bhas now been read end-to-end, and the eight stale pairs plus the intentionally unchanged report-mode assertions were re-verified against current production source. Partial-retrieval uncertainty is no longer a valid reason to defer the test repair. Because #860/#861 and the serialized descendant stack consume this exact ancestry, any source-head move here must be followed in the same maintenance lane by ordinary non-force descendant convergence; do not move #859 and leave descendants stale, and do not reconstruct unrelated test regions.Translation-owner boundary
Issue #922 / PR #929 remain the canonical versioned translation-ledger path. This PR adds no DB schema, comparison-only translation resource, cross-service SQL, provider/model dependency, or competing translation authority. Historical v2.76 copy is semantic evidence only and must not be replayed wholesale.
Keep Draft until the eight comparison assertions are safely migrated with descendant convergence and fresh exact-head repository/security/browser/a11y/performance evidence plus qualifying independent approval are current. No self-approval, bypass, force-push, destructive rebase, ancestor skip, generated-lock hand edit, stale-evidence transfer, hidden compatibility label, or historical-tree replay.