feat(reports): leftover-map unexplained leftover share on grouping comparison graphic (v2.69.0) - #852
Conversation
…mparison graphic (v2.69.0)
Caption persisted leftover-map unexplained leftover share s on the grouping
comparison leftover-map graphic from already-named leftover_map_unexplained_share
(ADR 0312). Comparison copy uses leftover map comparison graphic unexplained
leftover share {label} so it stays distinct from hyphen leftover-map unexplained
leftover share {label} and from strip Leftover map comparison unexplained leftover
share. A missing or non-finite s omits that caption and keeps leftover-map
explained leftover share, leftover-map reconstruction, leftover-map distance,
and comparison graphic coverage notes. Rank-0 origin cells still name U²/R² 0.00
when that share is finite. Do not caption leftover-map cross share this increment.
Do not invent s from U and R or leftover-map distance. Never invent a leftover
score. Never invent a theta. No new columns.
|
Queue retry: leftover-map unexplained leftover share on grouping comparison graphic (v2.69.0 / ADR 0312) @ Verification: vitest 808 passed, oxlint 0, py_compile ok. Next stacked increment is leftover-map cross share on that comparison graphic. Issues #79 and #87 stay open. #96 is already closed. Do not merge #808 without independent APPROVE. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Queue retry: leftover-map unexplained leftover share on grouping comparison graphic (v2.69.0 / ADR 0312). Independent APPROVE required before squash-merge. Do not self-approve. Next stacked increment is leftover-map cross share on that comparison graphic. Issues #79 and #87 stay open. #96 is already closed. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| aria-label={tf( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_UNEXPLAINED_SHARE | ||
| : LEFTOVER_MAP_PLOT_SEGMENT_UNEXPLAINED_SHARE, | ||
| { label: segment.unexplainedShareLabel }, | ||
| )} |
There was a problem hiding this comment.
📝 Info: Variant switch preserves omission behavior
LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_UNEXPLAINED_SHARE changes only the accessible name. Missing shares still omit independently because rendering remains gated by the existing formatter.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "leftover map comparison graphic explained leftover share {label}": | ||
| "잔여 지도 비교 그림 설명 잔여 점유율 {label}", | ||
| "Leftover map comparison explained leftover share": "잔여 지도 비교 설명 잔여 점유율", | ||
| "leftover map comparison graphic unexplained leftover share {label}": "잔여 지도 비교 그림 미설명 잔여 점유율 {label}", |
There was a problem hiding this comment.
📝 Info: Translations follow runtime lookup order
Every non-English locale defines the new key. English safely uses the key itself before tf substitutes the formatted persisted value.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Cycle 2026-08-31T06:40 KST: writes work. Independent APPROVE still required; not self-approving. Local duplicate of this increment was 8d3085c on a shallow clone of #851 and was not force-pushed. Next buyer gap after this head: leftover-map cross share on the grouping comparison leftover-map graphic (ADR 0313 / v2.70.0). |
|
Cycle retry (2026-08-31T07:08 KST): write-scope probe. Independent APPROVE still required; not self-approving. |
|
Queue retry 2026-08-31T07:21 KST: leftover-map unexplained leftover share on grouping comparison graphic remains stacked at v2.69.0. Independent APPROVE required on exact head 2c34896. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Next buyer gap is leftover-map cross share on the grouping comparison graphic (distinct comparison-graphic name; strip already has ADR 0296). |
|
Cycle 2026-08-31 ~07:08 KST: writes retry. Head |
|
Stacked buyer increment opened: leftover-map cross share on grouping comparison leftover-map graphic (v2.70.0 / ADR 0313) is #853 @ |
seonghobae
added
enhancement
ChatGPT Codex Connector
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
현재 exact head의 v2.69 제품 경로에서 Vietnamese LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_UNEXPLAINED_SHARE 번역이 phần dư chưa giải thích ...로 되어 있어 unexplained residual만 말하고 share 의미를 보존하지 않습니다. Production constant는 leftover map comparison graphic unexplained leftover share {label}이고 formatter 값도 U²/R², 즉 비율/몫입니다. 기존 leftoverMapUnexplainedShare.test.ts는 영문 key identity와 수치 formatter만 검사해 이 locale 의미 손실을 잡지 못합니다. #851의 explained-share 번역 repair를 먼저 상속한 뒤, 이 PR 고유 s 경로에도 production-key Vietnamese regression을 추가하고 tỷ phần phần dư chưa giải thích ...처럼 share 의미가 명시되는 최소 번역 repair를 수행해야 합니다. 다른 locale·measurement semantics·owner boundary는 변경하지 않습니다.
…tics Adopt exact repaired #852 de9e7b3 as the second parent while preserving #853 product delta from 4eae847. Promote the workflow-free tree that exercised the Vietnamese cross-share accessible-name RED, repaired explicit share semantics, regenerated uv.lock with uv 0.11.28 to v2.70.0, and passed focused frontend/build/Storybook plus project lock parity validation.
1 participant
Summary
Caption persisted leftover-map unexplained leftover share
son the grouping-comparison leftover-map graphic (ADR 0312 / v2.69.0). It omits independently from explained share, reconstruction, distance, and coverage. No SQL/new columns; never derivesfromU/Ror neighbouring statistics.Current exact authority
99f92eb4a1b1a646b1188a31fbe3d164fb5b5d30de9e7b3b9f2348145177e2593b19d1e7babf7ac33630fc5452042b18bbdb099e556f044867bec2ce, second parent is exact repaired feat(reports): leftover-map explained leftover share on grouping comparison graphic (v2.68.0) #85199f92eb4...Parent convergence and child RED → repair
#851's explained-share Vietnamese semantics and generated-lock repair are inherited normally rather than copied. The convergence commit also preserves #852's v2.69 product delta and repairs the child-owned Vietnamese accessible-name defect for
LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_UNEXPLAINED_SHARE: production copy keeps explicit share semantics (tỷ phần phần dư chưa giải thích ...) instead of reducing the label to an unexplained residual phrase.The synthetic pre-merge validation of #1000 exposed a real merge-result lock-parity RED (
uv.lock2.68.0 vspyproject.toml2.69.0). The promoted two-parent product commit does not inherit that stale generated artifact: currentpyproject.toml, runtimelineageweave.__version__, and editableuv.lockare all 2.69.0. Do not transfer the failed synthetic merge receipt or predecessor GREEN as acceptance forde9e7b3....Descendant convergence
The prior body was stale. Direct child #853 has already adopted this exact repaired parent non-force and is now at
ef02b1d2fab4f9f7a8db797a29acda93e156847d; #854 is based on that current #853 head at746bd6a102fa6ec6eb181779369e98cdad7fa34d, with later serialized descendants converged onward through #858/#859. Do not create duplicate restacks for already-current ancestry. Parent movement remains a repair event, not a close reason, and no child may copy parent-owned repairs independently. Each descendant keeps its own exact-head RED/gate state; #859 currently owns the comparison-distance consumer-test RED.Product invariants
somits only its graphic caption; finite zero and values above 1 remain visible and are not clamped.Keep Draft until this exact head has fresh repository/security validation, required browser/a11y/performance evidence, and qualifying independent approval. No self-approval, bypass, force push, destructive rebase, generated-lock hand edit, ancestor skip, or predecessor-evidence transfer.