feat(reports): leftover-map singular values on leftover-map graphic leftover-map axis ticks independently of leftover-map axis share (v2.84.0) - #868
Conversation
…eftover-map axis ticks independently of leftover-map axis share (v2.84.0)
Caption leftover-map graphic leftover-map axis ticks with persisted leftover-map singular values σ_k through leftoverMapPlotTickAxisBadge independently of leftover-map axis share (ADR 0327). Tick copy stays leftover-map axis {k} tick {value} σ {singular} when σ_k is finite so it stays distinct from leftover-map axis {k} σ {value}, leftover axis {k} σ {value}, leftover map comparison leftover axis {k} σ {value}, leftover map comparison graphic leftover-map axis {k} σ {value}, and leftover map comparison graphic leftover-map axis {k} tick {value}. Rank-0 unused axes still name σ 0.00. Singular value omits independently of leftover-map axis share. Leftover-map graphic leftover-map axis ticks never name leftover-map axis share. Do not invent σ_k from leftover-map axis share. Never invent a leftover score. Never invent a theta.
|
Cycle 2026-08-31 12:23 KST. Writes work as seonghobae. Exact head |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cycle 2026-08-31 12:23 KST. Writes work. Exact head Next buyer increment after this stacked σ_k surface: leftover-map comparison graphic leftover-map axis ticks naming persisted σ_k independently of leftover-map axis share (named helper leftoverMapComparePlotTickAxisBadge matching leftoverMapPlotTickAxisBadge / leftoverMapComparePlotAxisBadge / leftoverMapPlotAxisBadge / leftoverMapCompareAxisBadge / leftoverMapAxisBadge), or the next already-persisted leftover-map quantity that still has no buyer caption. Do not persist leftover-map inner product, cosine, or length. Synthetic fixtures only. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| if (variant === "comparison") { | ||
| return tf(LEFTOVER_MAP_COMPARE_PLOT_TICK, { axis: axisIndex, value: tickLabel }); | ||
| } | ||
| const leftoverSingular = leftoverSingularForAxis(leftoverMapAxes, axisIndex); | ||
| const badge = leftoverMapPlotTickAxisBadge(axisIndex, tickLabel, leftoverSingular); | ||
| return tf(badge.key, badge.values); |
There was a problem hiding this comment.
📝 Info: Comparison labels remain isolated
The comparison branch returns before singular-value lookup. Shared rendering therefore cannot leak the new report caption into comparison ticks.
Was this helpful? React with 👍 or 👎 to provide feedback.
| export function leftoverMapPlotTickAxisBadge( | ||
| axisIndex: number, | ||
| tickLabel: string, | ||
| leftoverSingular: number | null | undefined, | ||
| ): LeftoverMapCompareAxisBadge { | ||
| const singular = formatLeftoverMapPlotAxisSingular(leftoverSingular); | ||
| if (singular === null) { | ||
| return { key: LEFTOVER_MAP_PLOT_TICK, values: { axis: axisIndex, value: tickLabel } }; | ||
| } | ||
| return { | ||
| key: LEFTOVER_MAP_PLOT_TICK_SINGULAR, | ||
| values: { axis: axisIndex, value: tickLabel, singular }, | ||
| }; | ||
| } |
There was a problem hiding this comment.
📝 Info: Malformed singular values fail closed
formatLeftoverMapPlotAxisSingular rejects missing, negative, and non-finite values while preserving zero. The fallback retains the original tick caption.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Independent review still required on exact head Next buyer increment stacked locally: leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map singular values |
|
Stacked follow-on opened: #869 leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map singular values |
seonghobae
added
enhancement
ChatGPT Codex Connector
Adopt exact reconstructed #867 as the current tree while preserving historical #868 as first parent. Retain the v2.84 product delta as executable RED: report-graphic ticks may name persisted σ independently of share, invalid σ falls back to the ordinary tick, and no share or σ is inferred. Exact #867 is the second parent. No force update or destructive rebase.
Adopt exact reconstructed #868 as the current tree while preserving historical #869 as first parent. Retain the v2.85 product delta as executable RED: comparison-graphic ticks may name persisted σ independently of share, invalid σ falls back to the comparison tick, and no share or σ is inferred. Exact #868 is the second parent. No force update or destructive rebase.
1 participant
Current exact authority
86d24716f570af33422ec2e707c334c83a15b2d0dddd9ad77c64a9524ef313db25c62fb2f01e3608Proposedtests/test_leftover_map_report_tick_singular_contract.py; ordinary non-force convergence onlyReport-graphic ticks may append finite persisted σ without axis share, preserve
σ=0, fall back when σ is invalid, and never synthesize share. #859 remains executable RED; no predecessor validation transfers. Keep Draft until inherited/local REDs and fresh repository/security/browser/a11y/performance/approval gates are GREEN.