feat(reports): leftover-map coordinate ticks on grouping comparison graphic (v2.77.0) - #860
Conversation
…raphic (v2.77.0)
Caption persisted leftover-map coordinate ticks on the grouping
comparison leftover-map graphic from already-named leftover-map
coordinates (ADR 0320). Comparison copy uses leftover map comparison
graphic leftover-map axis {axis} tick {value} so it stays distinct from
leftover-map axis {axis} tick {value} and from leftover map comparison
axis {axis} ({share}%). Origin and unique finite xi / zeta projections
only. Rank-0 origin cells still name leftover-map comparison graphic
leftover-map axis tick 0.00. Do not invent evenly spaced ticks.
Do not caption leftover-map singular values this increment.
Do not invent leftover-map coordinate ticks from leftover-map distance.
Never invent a leftover score. Never invent a theta. No new columns.
|
Cycle 2026-08-31T00:28Z. Exact head Frontend vitest: leftoverMapPlotLayout, LeftoverMapPlot, i18n, App — 520 passed. Oxlint on changed files: 0 warnings, 0 errors. Synthetic fixtures only. Next deferred increment (explicit in ADR 0320): leftover-map singular values on the grouping comparison leftover-map graphic. Never invent a leftover score. Never invent a theta. No new columns. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| aria-label={tf( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_TICK | ||
| : LEFTOVER_MAP_PLOT_TICK, | ||
| { axis: tick.axis, value: tick.label }, | ||
| )} |
There was a problem hiding this comment.
🟡 Nearby coordinates lose comparison ticks
When distinct coordinates share a two-decimal label, layout.ticks contains only the first. The comparison graphic therefore omits a required coordinate tick.
Prompt for agents
ADR 0320 requires a tick at every unique finite persisted coordinate, but frontend/src/leftoverMapPlotLayout.ts uniqueCoordinateTicks deduplicates coordinates by their formatted two-decimal labels. Distinct values such as 0.001 and 0.002 collapse into one tick before LeftoverMapPlot renders the comparison labels. Preserve uniqueness by numeric coordinate while still using the shared formatter for display. Ensure React keys remain unique when multiple coordinates have the same displayed label, and add layout/component tests covering distinct same-label coordinates.
Was this helpful? React with 👍 or 👎 to provide feedback.
| aria-label={tf( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_TICK | ||
| : LEFTOVER_MAP_PLOT_TICK, | ||
| { axis: tick.axis, value: tick.label }, | ||
| )} |
There was a problem hiding this comment.
📝 Info: Report tick names remain stable
The variant branch changes only comparison tick names. Existing report plots retain LEFTOVER_MAP_PLOT_TICK, and the production comparison caller supplies the required variant.
Was this helpful? React with 👍 or 👎 to provide feedback.
| export const LEFTOVER_MAP_COMPARE_PLOT_TICK = | ||
| "leftover map comparison graphic leftover-map axis {axis} tick {value}"; |
There was a problem hiding this comment.
📝 Info: Tick sources remain coordinate-bound
layoutLeftoverMapPlot still derives ticks only from finite persisted projections plus zero. Collapsed drawing scale adds no synthetic tick values.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "name": "frontend", | ||
| "private": true, | ||
| "version": "2.76.0", | ||
| "version": "2.77.0", |
There was a problem hiding this comment.
🔍 Focused tests need CI confirmation
Local Corepack could not verify the pinned pnpm signature, so focused frontend tests never started. CI must confirm the rendering and translation suites.
Was this helpful? React with 👍 or 👎 to provide feedback.
seonghobae
added
enhancement
ChatGPT Codex Connector
Adopt exact reconstructed #859 as the current tree while preserving historical #860 as first parent. Retain the v2.77 coordinate-tick product delta as executable RED: comparison ticks need distinct accessible copy and must come only from the origin plus persisted ξ/ζ projections, never from leftover distance or fabricated spacing. Exact #859 is the second parent. No force update or destructive rebase.
Adopt exact reconstructed #860 as the current tree while preserving historical #861 as first parent. Retain the v2.78 singular-value product delta as executable RED: comparison axes must name persisted finite non-negative σ values with distinct comparison copy, preserve σ=0, omit invalid σ independently of share, and never infer σ from axis share. Exact #860 is the second parent. No force update or destructive rebase.
1 participant
Current exact authority
8d6e5ac52abce56eae53b80c0586c51f7e81881ca5970cda7a209439c23771d07a63c881f8f11c7dProposedtests/test_grouping_comparison_graphic_tick_contract.py; the branch was converged by ordinary non-force ancestry adoption, not historical-tree replayInvariant
Comparison ticks remain the origin plus unique finite persisted person/item axis projections and use distinct comparison-graphic naming. Do not invent evenly spaced ticks or derive them from distance, rank, geometry, or other evidence. Report tick semantics remain separate.
#859 currently has a valid localized comparison-distance production repair but eight stale comparison-component exact assertions still RED on its authoritative hosted run. No #859 GREEN or predecessor receipt transfers here. Keep Draft until inherited/local REDs are causally GREEN and fresh exact-head repository/security/browser/a11y/performance evidence plus qualifying independent approval are current. No force-push, destructive rebase, bypass, self-approval, or stale historical-tree replay.