feat(reports): leftover expected on grouping comparison graphic (v2.74.0) - #857
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact head |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Cycle 2026-08-31 08:19 KST: exact head |
…4.0) Name leftover expected E on grouping comparison leftover-map pair segments (ADR 0317). After make seed, closest and farthest leftover pairs sit above the member list with leftover expected E next to leftover observed Y on that comparison graphic; click opens that post. Rank-0 unused axes still name E 0.00 when that persisted leftover expected is finite. A missing or non-finite E omits that leftover-map comparison graphic leftover expected caption and keeps leftover observed Y. Never invent a leftover score. Never invent a theta.
9f34d2c to
ade9ed5
Compare
|
Rebased onto #856 @ Comparison-graphic leftover expected uses distinct accessible name Leave open for independent review. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Next buyer increment after this residual: leftover-map rank on the comparison graphic (ADR 0318 / v2.75.0). |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head repair finding: ADR 0317 is introduced by this still-Draft PR as Decision status: Accepted. That overstates decision authority before independent review/normal merge. Keep the product/UI delta, but make ADR 0317 Proposed on this branch and add an executable regression that prevents the Draft decision from silently returning to Accepted. Also refresh the Stack authority: the live base is #856 at dbb30794bdf5af1ae85f2e9e1ea39ba434e9bd14 and the live head is 2c256e58e08b082b7936b99f3d1481f2f3bc833e, not the older SHAs in the body. Do not force-push or weaken gates.
seonghobae
added
enhancement
ChatGPT Codex Connector
Preserve #857 expected-E truth and ADR 0317 Proposed while inheriting repaired ADR 0314/0315/0316 governance through ordinary two-parent non-force convergence.
Preserve #857 expected-E truth and Proposed ADR 0317 while inheriting repaired ADR 0313/0314/0315/0316 governance through ordinary two-parent non-force convergence.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head re-review: ADR 0317 is Proposed and the expected-E product delta is preserved through ordinary non-force convergence of repaired #853–#856. Exact-head hosted frontend evidence is still RED: 853 tests pass and exactly three inherited assertions fail (20px caption bounds plus two Vietnamese-copy contracts), so this head is not GREEN and no merge/approval claim is made.
Adopt the exact repaired #857 tree while preserving historical #858 as the first parent. Keep the v2.75 rank product delta as an executable RED instead of replaying stale App/i18n/ADR/package choices: the comparison graphic must name persisted leftover_map_rank with distinct comparison copy, retain rank 0, omit missing/negative/non-integer evidence, and never derive or clamp rank. Exact #857 is the second parent. No force update or destructive rebase.
1 participant
Summary
Caption persisted leftover expected
Eon the grouping-comparison leftover-map graphic (ADR 0317 / v2.74.0) without inventing scores or columns. Missing/non-finiteEomits only this caption; finite negativeEremains visible.Current exact authority
87de090ead8a39fdf0d12bc1ca5b5c6d3b5ebad038ac253ad39869b62add7359b47b9da383d1278cProposed; predecessor acceptance does not transfer across head movementThe current convergence head carries the Vietnamese share-meaning repairs that previously remained RED. Exact-head repository Tests run
34536230215is terminal GREEN. The prior compact-canvas/Vietnamese inherited failures are therefore not active on this head. Devin Review and CodeRabbit commit statuses are success.This is still not merge authority: no qualifying independent current-head
APPROVEDreview is present, the current-head evidence set does not establish separate Security/SAST/CodeQL acceptance, and authenticated responsive/pointer/touch/keyboard/focus/screen-reader plus buyer-path performance evidence remain incomplete. The earlier Ready state had served validation admission and is now returned to Draft instead of presenting an incomplete gate set as promotion-ready.Direct child #858 has already been semantically reconstructed onto this exact parent: its GitHub base is
feat/leftover-map-compare-plot-expected-v2740@38ac253ad39869b62add7359b47b9da383d1278c, its preserved historical first-parent delta remains in ancestry, and current reconstructed head isc3a64c4c0f9df45a9466e5c087a75f24e12bf9d3. #858 intentionally retains an executable rank-label RED and remains Draft; no child GREEN transfers to this parent.No self-approval, bypass, force-push, destructive rebase, generated-lock hand edit, ancestor skip, or stale-evidence transfer.