Skip to content

feat(reports): leftover-map singular values on leftover-map comparison leftover-axis ticks independently of leftover-map axis share (v2.86.0) - #870

Draft
seonghobae wants to merge 3 commits into
feat/leftover-map-compare-plot-tick-axis-badge-v2850from
feat/leftover-map-compare-axis-tick-badge-v2860
Draft

feat(reports): leftover-map singular values on leftover-map comparison leftover-axis ticks independently of leftover-map axis share (v2.86.0)#870
seonghobae wants to merge 3 commits into
feat/leftover-map-compare-plot-tick-axis-badge-v2850from
feat/leftover-map-compare-axis-tick-badge-v2860

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

Caption grouping-comparison strip leftover-axis ticks with persisted leftover-map singular values σ_k through leftoverMapCompareAxisTickBadge (ADR 0329 / v2.86.0).

Current exact authority

The branch adopts exact reconstructed #869 as its second parent without replaying historical App/i18n/ADR/package/lock choices. The v2.86 delta is retained as ancestry plus tests/test_grouping_comparison_strip_tick_singular_contract.py.

RED / product invariant

A grouping-comparison strip leftover-axis tick may append persisted σ_k even when axis share is absent, using leftover map comparison leftover axis {axis} tick {value} σ {singular}. Invalid σ falls back to the ordinary comparison-axis tick; tick captions never synthesize share. Persisted σ=0 remains explicit. Neither σ nor share may be inferred.

Minimal causal GREEN follows inherited repairs and extends the canonical singular projection to comparison-strip tick naming while preserving comparison-graphic/report-graphic distinctions. Never invent a leftover score or theta; no new columns.

Keep Draft until inherited and local REDs are causally GREEN and fresh exact-head repository/security/browser/a11y/performance evidence plus qualifying independent approval are current. No self-approval, bypass, force-push, destructive rebase, ancestor skip, generated-lock hand edit, or stale-evidence transfer.

…n leftover-axis ticks independently of leftover-map axis share (v2.86.0)

Caption leftover-map comparison leftover-axis ticks with persisted leftover-map singular values σ_k through leftoverMapCompareAxisTickBadge independently of leftover-map axis share (ADR 0329). A missing, non-finite, or negative singular value omits that σ tick caption. Rank-0 unused axes still name σ 0.00. Do not invent σ_k from leftover-map axis share.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Independent review required on exact head b086d97. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Stacked onto #869 @ 98a29e4. Devin Review on #869 is COMMENTED, not APPROVE — do not merge #869 or this PR without independent APPROVE plus GitHub Checks on the exact SHA. Issues #79 and #87 stay open.

Buyer-facing copy: leftover-map comparison leftover-axis ticks stay leftover map comparison leftover axis {k} tick {value} σ {singular} when σ is finite, independently of leftover-map axis share. Origin 0.00 plus unique finite ξ/ζ projections match the comparison graphic. Comparison graphic leftover-map axis ticks stay ADR 0328.

Next buyer-visible increment after independent review of this PR: leftover-map leftover-axis ticks with persisted leftover-map singular values independently of leftover-map axis share (ADR 0330 / v2.87.0), stacked onto this PR — pair-list leftover-axis surface, not leftover-map comparison leftover-axis ticks (0329).

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T13:31 KST: leftover-axis ticks (ADR 0330 / v2.87.0) opened as #871 stacked onto this PR @ b086d97. Leave #870 open. Independent APPROVE still required on this exact head. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T13:54 KST: exact head b086d97 Frontend lint/test/build + Full test suite required-success. Devin Review COMMENTED (no issues) is not independent APPROVE. Leave #870 open. Do not self-approve. Do not squash-merge.

Adopt exact reconstructed #869 as the current tree while preserving historical #870 as first parent. Retain the v2.86 product delta as executable RED: comparison-strip ticks may name persisted σ independently of share, invalid σ falls back to the ordinary comparison-axis tick, and no counterpart is inferred. Exact #869 is the second parent. No force update or destructive rebase.
seonghobae added a commit that referenced this pull request Sep 10, 2026
Adopt exact reconstructed #870 as the current tree while preserving historical #871 as first parent. Retain the v2.87 product delta as executable RED: report leftover-axis ticks may name persisted σ independently of share, invalid σ falls back to an ordinary tick, and neither σ nor share is inferred. Exact #870 is the second parent. No force update or destructive rebase.
Adopt exact converged #869 head 486a86e without force-updating or replaying stale source. Preserve the existing #870 reconstruction as first parent, retain its comparison-strip tick singular RED unchanged, and take the updated parent tree as second parent.
seonghobae added a commit that referenced this pull request Sep 11, 2026
Adopt exact converged #870 head 2fc2ed6 without force-updating or replaying stale source. Preserve the existing #871 reconstruction as first parent, retain its report-axis tick singular RED unchanged, and take the updated parent tree as second parent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant