Skip to content

feat(reports): leftover-map singular values on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share (v2.85.0) - #869

Draft
seonghobae wants to merge 6 commits into
feat/leftover-map-plot-tick-axis-badge-v2840from
feat/leftover-map-compare-plot-tick-axis-badge-v2850
Draft

feat(reports): leftover-map singular values on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share (v2.85.0)#869
seonghobae wants to merge 6 commits into
feat/leftover-map-plot-tick-axis-badge-v2840from
feat/leftover-map-compare-plot-tick-axis-badge-v2850

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Current exact authority

Comparison-graphic ticks may append finite persisted σ without share, preserve σ=0, fall back on invalid σ, and never synthesize share. #859 remains executable RED; no predecessor validation transfers. Keep Draft until inherited/local REDs and fresh repository/security/browser/a11y/performance/approval gates are GREEN.

…n graphic leftover-map axis ticks independently of leftover-map axis share (v2.85.0)

Caption leftover-map comparison graphic leftover-map axis ticks with persisted leftover-map singular values σ_k through leftoverMapComparePlotTickAxisBadge independently of leftover-map axis share (ADR 0328). A missing, non-finite, or negative singular value omits that σ tick caption. Rank-0 unused axes still name σ 0.00. Do not invent σ_k from leftover-map axis share.
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Independent review required on exact head 98a29e4. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Stacked onto #868 @ 5218a5c. Devin Review on #868 is COMMENTED, not APPROVE — do not merge #868 or this PR without independent APPROVE plus GitHub Checks on the exact SHA. Issues #79 and #87 stay open.

Buyer-facing copy: leftover-map comparison graphic leftover-map axis ticks name persisted leftover-map singular values as leftoverMapComparePlotTickAxisBadge. leftover map comparison graphic leftover-map axis {k} tick {value} σ {singular} when σ_k is finite; omit independently of leftover-map axis share. Rank-0 still names σ 0.00. Never invent σ_k from leftover-map axis share.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T13:09 KST: exact head 98a29e4 Frontend lint/test/build + Full test suite required-success. Devin Review COMMENTED (no issues) is not independent APPROVE. Leave #869 open. Do not squash-merge onto the unprotected leftover base. Do not self-approve. After independent review, retarget onto leftover-coordinates (feat/leftover-map-coordinates-v2240 / #782). Issues #79 and #87 stay open. Next buyer-visible increment is leftover-map comparison leftover-axis ticks with persisted leftover-map singular values independently of leftover-map axis share (ADR 0329 / v2.86.0), stacked onto this head — not mixed into #782.

Copy link
Copy Markdown
Contributor Author

Cycle write probe 2026-08-31T04:10Z: confirming comment scope on leftover-map stack tip #869 (v2.85.0). Independent APPROVE required; no self-approve.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T13:17 KST: GitHub writes live as seonghobae. Exact head 98a29e4 has required-success Checks; Devin Review COMMENTED is not independent APPROVE. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Leave #869 open. Issues #79 and #87 stay open.

Next buyer-visible increment: leftover-map comparison leftover-axis ticks with persisted leftover-map singular values independently of leftover-map axis share (ADR 0329 / v2.86.0), stacked onto this PR — grouping comparison strip leftover-axis surface, not leftover-map comparison graphic leftover-map axis ticks (0328).

Copy link
Copy Markdown
Contributor Author

Exact-head loop 2026-08-31T13:20 KST: Frontend lint/test/build success and Full test suite success on 98a29e4. Devin Review commented no issues; that is not independent APPROVE. Leave this PR open. Do not squash-merge onto the unprotected leftover base. Do not self-approve. Do not merge #808 without independent APPROVE. Issues #79 and #87 stay open. Next buyer gap ships as a stacked increment (leftover-map comparison graphic leftover-map axis ticks name leftover-map axis share independently of leftover-map singular values) and will not mix into this head.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T13:27 KST: leftover-map comparison leftover-axis ticks (ADR 0329 / v2.86.0) opened as #870 stacked onto this PR @ 98a29e4. Leave #869 open. Independent APPROVE still required on this exact head. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-31T13:53 KST: GitHub writes live as seonghobae. Exact head 98a29e4 has required-success Checks; Devin Review COMMENTED is not independent APPROVE. Do not self-approve. Do not squash-merge. Leave #869/#870/#871 open. Next buyer gap is leftover-map axis share on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map singular values, stacked after #871.

Adopt exact reconstructed #868 as the current tree while preserving historical #869 as first parent. Retain the v2.85 product delta as executable RED: comparison-graphic ticks may name persisted σ independently of share, invalid σ falls back to the comparison tick, and no share or σ is inferred. Exact #868 is the second parent. No force update or destructive rebase.
seonghobae added a commit that referenced this pull request Sep 10, 2026
Adopt exact reconstructed #869 as the current tree while preserving historical #870 as first parent. Retain the v2.86 product delta as executable RED: comparison-strip ticks may name persisted σ independently of share, invalid σ falls back to the ordinary comparison-axis tick, and no counterpart is inferred. Exact #869 is the second parent. No force update or destructive rebase.
Adopt exact converged #868 head fcaf7a7 without force-updating or replaying stale historical source. Preserve the existing #869 reconstruction as first parent, retain its comparison-tick singular RED unchanged, and take the converged parent tree as the second parent.
…rent

Adopt exact converged #868 head 97bcc8d without force-updating or replaying stale source. Preserve the existing #869 convergence as first parent, retain its comparison-tick singular RED unchanged, and take the updated parent tree as second parent.
seonghobae added a commit that referenced this pull request Sep 11, 2026
Adopt exact converged #869 head 486a86e without force-updating or replaying stale source. Preserve the existing #870 reconstruction as first parent, retain its comparison-strip tick singular RED unchanged, and take the updated parent tree as second parent.
chore(stack): converge #869 onto repaired #868 head
seonghobae added a commit that referenced this pull request Sep 12, 2026
chore(stack): converge #870 onto repaired #869 head
seonghobae added a commit that referenced this pull request Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant