Repository navigation
arm64: spin table: release chosen stopped CPUs ahead of the others - #2118
Merged
Merged
Conversation
This was referenced Nov 17, 2026
erikwb
marked this pull request as draft
November 17, 2026 15:05
At a suspend's commit the parked CPUs stop and wait, still running and coherent, until spin_table_release_stopped() lets all of them take their last WFI together. A platform's sleep may need some of them down before the rest: the sleep engine on the Apple T6050 runs each CPU cluster's power-down in turn, and a cluster only goes down once all of its cores are in their last WFI. Add spin_table_release_cpus(), which releases the stopped CPUs of a mask now; the others still wait for spin_table_release_stopped(). The mask is cleared again by spin_table_stop_finished(). Developed with Claude Code. Signed-off-by: Erik Bourget <erik@ebourget.net>
erikwb
force-pushed
the
j716c/spin-table-release-cpus
branch
from
November 17, 2026 15:08
3abd1e1 to
d127243
Compare
DjDeveloperr
marked this pull request as ready for review
November 17, 2026 19:02
This was referenced Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
At a suspend's commit the parked spin-table CPUs stop and wait, still running and coherent,
until
spin_table_release_stopped()lets all of them take their last WFI together.This adds
spin_table_release_cpus(const struct cpumask *), which releases the stopped CPUs of amask now, ahead of the others; the rest still wait for
spin_table_release_stopped(). The mask iscleared by
spin_table_stop_finished(). There is a stub for kernels without CPU hotplug.The T6050 sleep uses it on the J716c to take its two secondary CPU clusters down before the boot
cluster (#2119 (
j716c/sleep-j716c-profile)). Nothing else calls it, so other platforms are unchanged.Tested
j716c/spin-table-release-cpus) builds on its own base (Image.gz, modules and dtbs, arm64, LLVM).integration/aurorawere built as one kernel and run on a J716c (16" M5 Max): one suspend-to-RAM with a USB4 dock attached, about 30 s asleep, woken by the RTC alarm (wake source 76). After the wake all 18 CPUs were online, the dock's router came back in place with its Ethernet up, and the SEP answered RNG reads. The sleep's log showed "secondary clusters down first: cores 6+6, cluster 1 0x1a in 353 us, cluster 2 0x1c01a in 448 us". The PMP was not running in that build.Dependencies
Branch #2118 (
j716c/spin-table-release-cpus). Based onintegration/aurora; no dependencies at build time.Part of the J716c deep sleep set: #2118 (
j716c/spin-table-release-cpus), #2119 (j716c/sleep-j716c-profile), #2120 (j716c/sleep-wake-source-names), #2121 (j716c/sleep-sep-auto-wake), #2122 (j716c/sep-t6050-profile), #2123 (j716c/dts-deep-sleep), #2124 (j716c/drm-apple-sleep), #2125 (j716c/dart-sleep), #2126 (j716c/thunderbolt-sleep), #2127 (j716c/usb-sleep), #2128 (j716c/phy-sleep), #2129 (j716c/pcie-sleep), #2130 (j716c/aic-sleep), #2131 (j716c/asahi-sleep), #2132 (j716c/spmi-sleep), #2133 (j716c/macsmc-sleep), #2134 (j716c/nvme-sleep).🤖 Generated with Claude Code