Repository navigation
thunderbolt: apple: T6050: J716c USB4 router sleeps in place - #2126
Merged
Merged
Conversation
This was referenced Nov 17, 2026
erikwb
marked this pull request as draft
November 17, 2026 15:06
… on the J714s The J716c has the J714s's T6050 USB4 router, NHI and tunnelled PCIe, and its right port is acio2 as on the J714s. Apply the J714s's rules for a router that sleeps in place with a dock attached to the J716c too: the USB host's binding to the router, the router's CIO frames and power roles in the suspend, the tunnel's domain after a refused sleep, the retimer scan that the dock's link does not take, and the router's sleep teardown. The left ports are powered off for the sleep. The J714s-only diagnostics stay J714s only. Developed with Claude Code. Signed-off-by: Erik Bourget <erik@ebourget.net>
…old as on the J714s The J716c's USB4 router sleeps in place the way the J714s's does, and needs the same two rules at its power-off: - the router's own domain (ATC2_CIO), held on by its DART, is taken down at the entry and raised again only after the PHY at the wake, so that a dock's link trains in place; - LSTX is held high through the sleep, so that an attached dock's CIO wake source does not assert right after the commit. Apply both on the J716c too. Developed with Claude Code. Signed-off-by: Erik Bourget <erik@ebourget.net>
erikwb
force-pushed
the
j716c/thunderbolt-sleep
branch
from
November 17, 2026 15:09
8742e6d to
1d2639d
Compare
DjDeveloperr
marked this pull request as ready for review
November 17, 2026 19:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The J716c's right-port USB4 router (acio2, as on the J714s) sleeps in place with a dock attached,
with the J714s's rules: the USB host's binding to the router, the router's CIO frames and power
roles in the suspend, the tunnel's domain after a refused sleep, the router's sleep teardown, its
own domain (ATC2_CIO) taken down at the entry and raised after the PHY at the wake, LSTX held
high through the sleep, and no retimer scan on the dock's link. The left ports are powered off for
the sleep. The J714s's diagnostics (link state and adapter dumps, domain guard logs) stay J714s
only.
Tested
j716c/thunderbolt-sleep) builds on its own base (Image.gz, modules and dtbs, arm64, LLVM).integration/aurorawere built as one kernel and run on a J716c (16" M5 Max): one suspend-to-RAM with a USB4 dock attached, about 30 s asleep, woken by the RTC alarm (wake source 76). After the wake all 18 CPUs were online, the dock's router came back in place with its Ethernet up, and the SEP answered RNG reads. The sleep's log showed "secondary clusters down first: cores 6+6, cluster 1 0x1a in 353 us, cluster 2 0x1c01a in 448 us". The PMP was not running in that build.Dependencies
Branch #2126 (
j716c/thunderbolt-sleep). Based onintegration/aurora; no dependencies at build time. At run time the J716c deep sleep needs #2119 (j716c/sleep-j716c-profile) and #2123 (j716c/dts-deep-sleep).Part of the J716c deep sleep set: #2118 (
j716c/spin-table-release-cpus), #2119 (j716c/sleep-j716c-profile), #2120 (j716c/sleep-wake-source-names), #2121 (j716c/sleep-sep-auto-wake), #2122 (j716c/sep-t6050-profile), #2123 (j716c/dts-deep-sleep), #2124 (j716c/drm-apple-sleep), #2125 (j716c/dart-sleep), #2126 (j716c/thunderbolt-sleep), #2127 (j716c/usb-sleep), #2128 (j716c/phy-sleep), #2129 (j716c/pcie-sleep), #2130 (j716c/aic-sleep), #2131 (j716c/asahi-sleep), #2132 (j716c/spmi-sleep), #2133 (j716c/macsmc-sleep), #2134 (j716c/nvme-sleep).🤖 Generated with Claude Code