Repository navigation
Conversation
85fedb0 to
ff2b720
Compare
|
Thanks for this. The node matches the J714s block (spi2 at 0x505108000, 8 MHz, mode 2, NUB GPIO 21 power, AP GPIO 138 data ready), the reserved-range split opens only pin 138, and the J716c is already admitted to the T6050 SEP profile at the current tip. So this PR only needs the device tree. We are also moving the SEP profile choice to the SoC compatible, after which no T6050 machine needs a board admit. The code looks good to us. What is still missing is the user-visible half of the hardware row. On the J716c, at this PR's head (with #1956/#1957 if you need them):
Please paste the |
|
A short follow-up: the SoC-based SEP profile choice we mentioned is now #2311. With it, the J716c no longer needs its entry in the profile list, and this PR stays device tree only. The J716c row we asked for is unchanged (cold-boot SEP lines, enrol plus match and no-match, three deep sleeps each followed by a first-try match, and the finger still listed and matching after a reboot). |
|
Note 🤖 Claude Opus 5.5 responding on behalf of erikwb J716c row. The kernel was 7.3.0 from integration/aurora b3445d7 plus this PR's head ff2b720, with #1956/#1957 and #2144, on the 27.2 stub. There was no enrolment beforehand.
The first-touch match rate was 2/3 after sleep, and about the same before any sleep. Each miss was a clean capture that the enclave scored as no match ( |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Adversarial review of ff2b7209 against the pre-PR checklist.
Checklist summary
- DT / Code / CI: 0 code blockers.
arch/arm64/boot/dts/apple/t6050-j716c.dts:&pinctrl_apgpio-reserved-ranges = <0 80>, <81 57>, <139 82>;splits<81 140>cleanly (81 + 57 = 138,139 + 82 = 221), exposing only AP GPIO 138 while keeping pin 112 and all other unused pins reserved.&ps_nub_gpio,&nub_gpio0,&ps_spi2, and&spi2/mesa: fingerprint@0matcht6050-j714s.dts(with board-specificapple/mesacal-j716c.binandapple/msrk-j716c.binper-device factory firmware names), and all referenced labels exist int6050-peripherals.dtsi(spi2is enabled forT6050_J716C,nub_gpio0has 61 pins).dt-checksandhost-testsare both green.
- §1–§3, §6: Pass.
- §4 (Attribution): 1 blocker below.
- §5 (Evidence): J716c Touch ID boot, enroll/verify, 3x deep sleep (
rtcwake -m mem -s 30), and reboot persistence are verified onff2b7209cb26(no SEP/SPI/DART errors). Please also confirm 0 SELinux denials, 0 failed units, and 0 new kernel errors overall for full §5 completeness.
Blocker
- §4 Attribution in commit message: Commit
ff2b7209cb26containsDeveloped with Claude Code.in the commit body. Per §4 of the pre-PR checklist, commits must carry human identity and a humanSigned-off-by:only (no AI attribution lines or trailers in commits). Please amend the commit to removeDeveloped with Claude Code.(keeping the DT diff identical) and replace the PR body footer (🤖 Generated with [Claude Code]...) with a plainAssisted-by:line at the end of the PR body.
Assisted-by: LLM (Gemini 4 Neon)
The J716c ADT wires the Mesa sensor as on the J714s: sensor-id 0x3356 on spi2 at 0x505108000, 8 MHz, chip select 0, power on NUB GPIO 21 (function-mesa_pwr) and data ready on AP GPIO 138. The device tree did not describe it, so apple_sep fell back to the T6020 controller address, found nothing there and never registered the sensor. Enable nub-gpio0, spi2 and their power states and add the fingerprint node with the J714s timing and SPI mode, naming the J716c calibration and root-key files. Expose AP GPIO 138: while it was reserved, gpiolib would have refused the data-ready interrupt's mapping. Signed-off-by: Erik Bourget <erik@ebourget.net>
ff2b720 to
92d43be
Compare
|
Note 🤖 Gemini 4 Neon responding on behalf of erikwb Fixed the §4 attribution blocker in
|
|
Thanks for the J716c row. It covers everything we asked for: the SEP comes up with no retries, enrolment and match/no-match work, the finger still matches after each of the three deep sleeps with no SEP, SPI or DART errors, and it persists across a reboot. A 2/3 first-touch rate with clean captures looks like enrolment quality to us, not a resume problem. 92d43be only changes the commit message: same tree (2d55af36) and parent as ff2b720, so the row applies to it unchanged. Nothing more from us. Assisted-by: LLM (Claude:Opus 5.5) |
Problem
The J716c wires the Touch ID sensor the same way as the J714s (
spi2at0x505108000, 8 MHz, chip select 0, power on NUB GPIO 21, data ready on AP GPIO 138). Without a device tree node,apple_sepfell back to the T6020 controller address, found nothing, and never registered the sensor.Change
Adds the Touch ID sensor to
arch/arm64/boot/dts/apple/t6050-j716c.dts, matching4b9a1718b27ffor the J714s:nub_gpio0,spi2, and their power states.fingerprint@0node with the J714s timing and SPI mode, namingapple/mesacal-j716c.binandapple/msrk-j716c.bin.pinctrl_ap'sgpio-reserved-ranges(<0 80>, <81 57>, <139 82>, leaving only 80 and 138 open while 112 stays reserved).Testing
On a J716c (M5 Max, 128 GB), 27.2 stub, with
integration/aurora(b3445d72) plus this patch (identical DT diff), #1956/#1957, and #2144:apple_sepready in 1454 ms (1459 ms after reboot) andapple-mesa spi0.0: sep sensor: bound, 8000000 Hz, mode 2 (CPOL=1 CPHA=0)with no bring-up retries.fprintd-enroll -f right-index-fingercompleted;fprintd-verifymatched the enrolled finger (verify-match) and rejected another finger (verify-no-match).rtcwake -m mem -s 30,mem_sleep=deep): each resume loggedthe enclave is back from its sleep requestwith no SEP, SPI, or DART errors, andfprintd-verifymatched after every wake (first touch on sleeps 1 and 3, second touch on sleep 2).fprintd-listretainedright-index-finger(identity count 1 after Catacomb restore with sensor registered) andfprintd-verifymatched on the first touch.make CHECK_DTBS=y apple/t6050-j716c.dtb apple/t6050-j714s.dtbwith dtschema: no warnings on any touched node (spi2,nub_gpio0,pinctrl_ap,fingerprint@0).scripts/checkpatch.pl: 0 errors, 0 warnings.Still to run
Assisted-by: LLM (Anthropic:Claude, Google:Gemini 4 Neon)