Skip to content

soc: apple: sleep: T6050: name the wake source after a wake - #2120

Merged
DjDeveloperr merged 2 commits into
integration/aurorafrom
j716c/sleep-wake-source-names
Nov 17, 2026
Merged

DjDeveloperr merged 2 commits into
integration/aurorafrom
j716c/sleep-wake-source-names

Conversation

@erikwb

@erikwb erikwb commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

What this does

The T6050's AP wake status words are sticky. They are now read at the start of the wake, before
anything else is touched, and once the wake is done each source that is set is logged as
wake source: <number> <name>. The names are the ADT's /arm-io/pmgr ap-wake-sources, which
are the same on the J714s and the J716c. A source with no name, or the GFX die's, is logged by
its number.

This applies to every T6050 profile. It is stacked on #2119 (j716c/sleep-j716c-profile) only because
it touches the same region-state struct and finish path; the change itself does not depend on it.

Tested

  • soc: apple: sleep: T6050: name the wake source after a wake #2120 (j716c/sleep-wake-source-names) builds on its own base (Image.gz, modules and dtbs, arm64, LLVM).
  • On the J716c run above the wake was reported with wake source 76, the RTC alarm.
  • All 17 branches merged on integration/aurora were built as one kernel and run on a J716c (16" M5 Max): one suspend-to-RAM with a USB4 dock attached, about 30 s asleep, woken by the RTC alarm (wake source 76). After the wake all 18 CPUs were online, the dock's router came back in place with its Ethernet up, and the SEP answered RNG reads. The sleep's log showed "secondary clusters down first: cores 6+6, cluster 1 0x1a in 353 us, cluster 2 0x1c01a in 448 us". The PMP was not running in that build.

Dependencies

Branch #2120 (j716c/sleep-wake-source-names). Stacked on #2119 (j716c/sleep-j716c-profile).

Part of the J716c deep sleep set: #2118 (j716c/spin-table-release-cpus), #2119 (j716c/sleep-j716c-profile), #2120 (j716c/sleep-wake-source-names), #2121 (j716c/sleep-sep-auto-wake), #2122 (j716c/sep-t6050-profile), #2123 (j716c/dts-deep-sleep), #2124 (j716c/drm-apple-sleep), #2125 (j716c/dart-sleep), #2126 (j716c/thunderbolt-sleep), #2127 (j716c/usb-sleep), #2128 (j716c/phy-sleep), #2129 (j716c/pcie-sleep), #2130 (j716c/aic-sleep), #2131 (j716c/asahi-sleep), #2132 (j716c/spmi-sleep), #2133 (j716c/macsmc-sleep), #2134 (j716c/nvme-sleep).

🤖 Generated with Claude Code

Nothing said what woke the machine from a deep sleep. The AP wake
status words are sticky: each source that raised the wake keeps its bit
set, ten words on the SoC die at +0x34 of the wake block and one on the
GFX die.

Read them at the start of the wake, before anything else is touched,
and once the wake is done log each source that is set as
"wake source: <number> <name>", with the names the ADT's
/arm-io/pmgr ap-wake-sources gives (a source with no name, or the GFX
die's, by its number).

Developed with Claude Code.

Signed-off-by: Erik Bourget <erik@ebourget.net>
@erikwb
erikwb force-pushed the j716c/sleep-j716c-profile branch from cc10822 to 949b24a Compare November 17, 2026 15:08
@erikwb
erikwb force-pushed the j716c/sleep-wake-source-names branch from 3c252e9 to 7e63437 Compare November 17, 2026 15:08
The AP and GFX status words contain latched bits. Label the reported
bits as status, including the die, so the log does not imply that a
bit was enabled or uniquely caused the wake.

Signed-off-by: Diljit Singh <hey@djdev.me>
@DjDeveloperr
DjDeveloperr changed the base branch from j716c/sleep-j716c-profile to integration/aurora November 17, 2026 19:16
@DjDeveloperr
DjDeveloperr marked this pull request as ready for review November 17, 2026 19:21
@DjDeveloperr
DjDeveloperr merged commit fe92789 into integration/aurora Nov 17, 2026
6 checks passed
@RyanTheTide
RyanTheTide deleted the j716c/sleep-wake-source-names branch November 17, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants