Skip to content

usb: apple: J716c: T6050 sleep rules for the port controllers and dwc3 - #2127

Merged
DjDeveloperr merged 2 commits into
integration/aurorafrom
j716c/usb-sleep
Nov 17, 2026
Merged

DjDeveloperr merged 2 commits into
integration/aurorafrom
j716c/usb-sleep

Conversation

@erikwb

@erikwb erikwb commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

What this does

The J716c's port controllers take the J714s's T6050 sleep rules: the system power state (SSPS)
rules, the MagSafe controller's sleep handling, and the dwc3 wait for a Type-C PHY that is not yet
restarted after a sleep. The T6050 dwc3 also keeps its tunnel over a USB4 router's sleep in place.

Behaviour change: on the J716c the MagSafe controller (hpm5, no connector) is now probed as on
the J714s. It registers a normal Type-C port and power supply, and with apple,sleep-ssps it
follows the system's sleep as the USB-C port controllers do.

Tested

  • usb: apple: J716c: T6050 sleep rules for the port controllers and dwc3 #2127 (j716c/usb-sleep) builds on its own base (Image.gz, modules and dtbs, arm64, LLVM).
  • All 17 branches merged on integration/aurora were built as one kernel and run on a J716c (16" M5 Max): one suspend-to-RAM with a USB4 dock attached, about 30 s asleep, woken by the RTC alarm (wake source 76). After the wake all 18 CPUs were online, the dock's router came back in place with its Ethernet up, and the SEP answered RNG reads. The sleep's log showed "secondary clusters down first: cores 6+6, cluster 1 0x1a in 353 us, cluster 2 0x1c01a in 448 us". The PMP was not running in that build.

Dependencies

Branch #2127 (j716c/usb-sleep). Based on integration/aurora; no dependencies at build time. At run time the J716c deep sleep needs #2119 (j716c/sleep-j716c-profile) and #2123 (j716c/dts-deep-sleep).

Part of the J716c deep sleep set: #2118 (j716c/spin-table-release-cpus), #2119 (j716c/sleep-j716c-profile), #2120 (j716c/sleep-wake-source-names), #2121 (j716c/sleep-sep-auto-wake), #2122 (j716c/sep-t6050-profile), #2123 (j716c/dts-deep-sleep), #2124 (j716c/drm-apple-sleep), #2125 (j716c/dart-sleep), #2126 (j716c/thunderbolt-sleep), #2127 (j716c/usb-sleep), #2128 (j716c/phy-sleep), #2129 (j716c/pcie-sleep), #2130 (j716c/aic-sleep), #2131 (j716c/asahi-sleep), #2132 (j716c/spmi-sleep), #2133 (j716c/macsmc-sleep), #2134 (j716c/nvme-sleep).

🤖 Generated with Claude Code

The J716c's port controllers take the same system power states for a
firmware suspend as the J714s's: apply the SSPS rules, the MagSafe
controller's sleep handling and the DWC3 wait for a Type-C PHY that is
not yet restarted after a sleep on both boards.

Without the wait, a DWC3 behind a port whose PHY is down after a
cancelled firmware suspend failed its restart with -ENOLINK and lost its
devices until the next boot.

With this the J716c's MagSafe controller (hpm5, no connector) is probed
as on the J714s: it registers its Type-C port and power supply, and
with apple,sleep-ssps it follows the system's sleep as the USB-C ports'
controllers do. The DT change that gives hpm0-2 and hpm5
apple,sleep-ssps and enables hpm5 is separate.

Developed with Claude Code.
Signed-off-by: Erik Bourget <erik@ebourget.net>
…leep in place

The J716c's right-port USB4 router sleeps in place as the J714s's does.
Apply the J714s's rule that keeps the T6050 dwc3's tunnel over such a
sleep to the J716c too.

Developed with Claude Code.

Signed-off-by: Erik Bourget <erik@ebourget.net>
@DjDeveloperr
DjDeveloperr marked this pull request as ready for review November 17, 2026 19:13
@DjDeveloperr
DjDeveloperr merged commit b19761e into integration/aurora Nov 17, 2026
7 checks passed
@RyanTheTide
RyanTheTide deleted the j716c/usb-sleep branch November 17, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants