Skip to content

spmi: apple: recover from a failed generation 4 exchange on the J716c too - #2132

Merged
DjDeveloperr merged 1 commit into
integration/aurorafrom
j716c/spmi-sleep
Nov 17, 2026
Merged

DjDeveloperr merged 1 commit into
integration/aurorafrom
j716c/spmi-sleep

Conversation

@erikwb

@erikwb erikwb commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

What this does

The sleep controller exchanges with the PMU by hand on nub-spmi0, sharing the reply FIFO with this
driver. After a failed exchange the J714s reads out the late or stray reply words so that none can
answer a later command; every other machine refuses the later commands. The J716c has the same
sleep and the same PMU on the same bus: it recovers the same way now.

Tested

  • spmi: apple: recover from a failed generation 4 exchange on the J716c too #2132 (j716c/spmi-sleep) builds on its own base (Image.gz, modules and dtbs, arm64, LLVM).
  • All 17 branches merged on integration/aurora were built as one kernel and run on a J716c (16" M5 Max): one suspend-to-RAM with a USB4 dock attached, about 30 s asleep, woken by the RTC alarm (wake source 76). After the wake all 18 CPUs were online, the dock's router came back in place with its Ethernet up, and the SEP answered RNG reads. The sleep's log showed "secondary clusters down first: cores 6+6, cluster 1 0x1a in 353 us, cluster 2 0x1c01a in 448 us". The PMP was not running in that build.

Dependencies

Branch #2132 (j716c/spmi-sleep). Based on integration/aurora; no dependencies at build time. At run time the J716c deep sleep needs #2119 (j716c/sleep-j716c-profile) and #2123 (j716c/dts-deep-sleep).

Part of the J716c deep sleep set: #2118 (j716c/spin-table-release-cpus), #2119 (j716c/sleep-j716c-profile), #2120 (j716c/sleep-wake-source-names), #2121 (j716c/sleep-sep-auto-wake), #2122 (j716c/sep-t6050-profile), #2123 (j716c/dts-deep-sleep), #2124 (j716c/drm-apple-sleep), #2125 (j716c/dart-sleep), #2126 (j716c/thunderbolt-sleep), #2127 (j716c/usb-sleep), #2128 (j716c/phy-sleep), #2129 (j716c/pcie-sleep), #2130 (j716c/aic-sleep), #2131 (j716c/asahi-sleep), #2132 (j716c/spmi-sleep), #2133 (j716c/macsmc-sleep), #2134 (j716c/nvme-sleep).

🤖 Generated with Claude Code

… too

The sleep controller exchanges with the PMU by hand on nub-spmi0, under
this driver's FIFO lock, and the two share the reply FIFO. After a failed
exchange the J714s reads out the late or stray reply words, so that none
can answer a later command; every other machine refuses the later commands.
The J716c now has the same sleep and the same PMU on the same bus: recover
there too.

Developed with Claude Code.
Signed-off-by: Erik Bourget <erik@ebourget.net>
@DjDeveloperr
DjDeveloperr marked this pull request as ready for review November 17, 2026 19:09
@DjDeveloperr
DjDeveloperr merged commit a390d6d into integration/aurora Nov 17, 2026
1 check passed
@RyanTheTide
RyanTheTide deleted the j716c/spmi-sleep branch November 17, 2026 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants