Repository navigation
Let authored AP242 dimensions take precedence over planned dimensions - #2187
Merged
Merged
Conversation
pzfreo
enabled auto-merge (squash)
October 4, 2026 21:27
This was referenced Oct 5, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2185.
Change
Drawing.dimension_sources()as a per-placed-measurement source inventory, including manual, AP242, and planner origin.Evidence
scripts/pr-check --staticpasses. Broader affected geometry selection and PR CI are the remaining merge gates.Architecture fit
No ADR boundary or invariant changes.
Final CI-fix review (2026-10-05)
The first CI run exposed a report-only PMI scale regression and a missing route for the new test module. Both were reproduced, fixed, and covered. The report-only GRM-03 fixture contains raw authored dimensions; its generated Sheet script now retains all five planned step lengths. A Document member that hides source PMI no longer inherits an extra baseline mark from the annotated acquisition, while a member-declared source still drives the baseline. Local focused and manifest selection: 145 passing tests;
scripts/pr-check --staticpasses. A fresh independent reviewer executed an adverse mode substitution and found no remaining blocker in this delta. The new full CI run is the merge gate.The same review uncovered the separate pre-existing Document tolerance-mode defect #2188. It is logged with a CTC-03 reproduction and is outside the raw dimension precedence change in this PR.
Cached-model and inspection guard review
The next CI run exposed two exact-identity assertions (
test_detect_onceand scale-retry ownership) and the pinned module footprint of read-only STEP inspection. The fix preserves the cachedPartModelobject when its visibility is already correct and calls PMI lowering only when an active source dimension needs baseline preparation. Local reproduction of all three guard tests, the #2185 regressions, source-shape and import boundaries passed; the static gate passed. A second fresh independent review executed adverse no-source/active-source/report-mode probes and found no blocker (one justified duplicate guard nit). The new CI run remains the merge gate.