Skip to content

Let authored AP242 dimensions take precedence over planned dimensions - #2187

Merged
pzfreo merged 3 commits into
mainfrom
fix/2185-authored-precedence
Oct 5, 2026
Merged

pzfreo merged 3 commits into
mainfrom
fix/2185-authored-precedence

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Closes #2185.

Change

  • Correlate authored AP242 size and location witnesses with canonical planned measurements before rendering. An authored baseline on a turned profile replaces the conflicting chain at its stations; uncovered stations receive dimensions from the same reference end.
  • Preserve plain imported diameter wording and source identity when a canonical bore callout can carry it. Keep compound hole terms and pattern members with their owning feature; ambiguous matches remain blocked and visible to lint.
  • Expose Drawing.dimension_sources() as a per-placed-measurement source inventory, including manual, AP242, and planner origin.
  • Preserve the same dimensions and provenance through generated Sheet scripts. Tighten turned-profile axial coverage to accept a connected station graph and offset face witnesses.

Evidence

  • Fresh independent review, including executable reproductions, found and resolved wrong-label propagation, conflicting label merging, remote-body OD suppression, offset-face coverage, and duplicate through-hole wording. Final review disposition: no remaining P0–P2 findings.
  • Local: 450 unit tests pass with pinned Quiddity 0.3.10; 108 smoke tests pass; focused Authored AP242 dimensions are drawn in addition to the planner's own, not instead of them #2185, source-shape, architecture, nominal diameter, compiled-plan, and provenance tests pass. scripts/pr-check --static passes. Broader affected geometry selection and PR CI are the remaining merge gates.

Architecture fit

  • ADR 1: correlation remains in the model/planner waist, with the existing single build engine and import DAG.
  • ADR 2: the planner changes approved content; placement still uses the shared annotation passes and corridor solve.
  • ADR 3: imported source witnesses are joined to canonical features only after exact ownership checks; recognition is not rerun.
  • ADR 4: source identity and authored scheme flow through the compiled plan and generated Sheet round trip; an unproved match does not suppress another measurement.
  • ADR 5: ambiguous or inconsistent source labels fail closed, provenance is explicit, and independent lint remains the judge of coverage.

No ADR boundary or invariant changes.

Final CI-fix review (2026-10-05)

The first CI run exposed a report-only PMI scale regression and a missing route for the new test module. Both were reproduced, fixed, and covered. The report-only GRM-03 fixture contains raw authored dimensions; its generated Sheet script now retains all five planned step lengths. A Document member that hides source PMI no longer inherits an extra baseline mark from the annotated acquisition, while a member-declared source still drives the baseline. Local focused and manifest selection: 145 passing tests; scripts/pr-check --static passes. A fresh independent reviewer executed an adverse mode substitution and found no remaining blocker in this delta. The new full CI run is the merge gate.

The same review uncovered the separate pre-existing Document tolerance-mode defect #2188. It is logged with a CTC-03 reproduction and is outside the raw dimension precedence change in this PR.

Cached-model and inspection guard review

The next CI run exposed two exact-identity assertions (test_detect_once and scale-retry ownership) and the pinned module footprint of read-only STEP inspection. The fix preserves the cached PartModel object when its visibility is already correct and calls PMI lowering only when an active source dimension needs baseline preparation. Local reproduction of all three guard tests, the #2185 regressions, source-shape and import boundaries passed; the static gate passed. A second fresh independent review executed adverse no-source/active-source/report-mode probes and found no blocker (one justified duplicate guard nit). The new CI run remains the merge gate.

@pzfreo
pzfreo enabled auto-merge (squash) October 4, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Authored AP242 dimensions are drawn in addition to the planner's own, not instead of them

1 participant