Skip to content

Recover 2:1 scale and nest imported PMI with step dimensions - #2205

Merged
pzfreo merged 5 commits into
mainfrom
fix/spindle-scale-datum-ladder
Oct 6, 2026
Merged

pzfreo merged 5 commits into
mainfrom
fix/spindle-scale-datum-ladder

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Fixes the spindle case where optional section reservation capped automatic A3 at 1:1 despite the finished section being dropped. A bounded same-sheet 2:1 trial runs only when the section dropped and the no-section estimate fits; the finished candidate still passes normal qualification. Routes generated vertical baseline steps through the shared corridor with imported linear PMI, sorted by measured span.

Verified on the supplied STEP: default PMI-enabled output is A3 2:1, with 12 / 34 ±0.05 / 52 in outward order. Lint has only the pre-existing section_dropped warning. The recognized completeness ledger remains 12 placed, 2 missing, 0 dropped of 14 requirements; this PR does not address those missing step lengths.

Focused tests: 4 passed (new scale/ladder tests, authored turned baseline, section-participant scale test). Ruff and diff check pass.

@pzfreo
pzfreo enabled auto-merge (squash) October 6, 2026 19:06
@pzfreo

pzfreo commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner Author

Tested eb72fbc with two Specify outputs, both now in https://gist.github.com/pzfreo/7c6a0be95a567e2774924207133b2d40.

specify-spindle-callouts.step (spindle with call-outs 12 +0.1/0, 34 ±0.05 and 52 +0.1/0 from datum A):

specify-plate-callout.step (regression check):

From the Specify side, both are good to merge. The two leftover duplicates look like the same "authored covers planned" matching, missing an overall length and a plane-to-axis location.

The two leftover duplicates are now filed as https://github.com/pzfreo/draftwright/issues/2206.

@pzfreo
pzfreo merged commit 16d7ce4 into main Oct 6, 2026
19 checks passed
@pzfreo
pzfreo deleted the fix/spindle-scale-datum-ladder branch October 6, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant