Repository navigation
Recover 2:1 scale and nest imported PMI with step dimensions - #2205
Merged
Merged
Conversation
pzfreo
enabled auto-merge (squash)
October 6, 2026 19:06
Owner
Author
|
Tested
From the Specify side, both are good to merge. The two leftover duplicates look like the same "authored covers planned" matching, missing an overall length and a plane-to-axis location. The two leftover duplicates are now filed as https://github.com/pzfreo/draftwright/issues/2206. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the spindle case where optional section reservation capped automatic A3 at 1:1 despite the finished section being dropped. A bounded same-sheet 2:1 trial runs only when the section dropped and the no-section estimate fits; the finished candidate still passes normal qualification. Routes generated vertical baseline steps through the shared corridor with imported linear PMI, sorted by measured span.
Verified on the supplied STEP: default PMI-enabled output is A3 2:1, with 12 / 34 ±0.05 / 52 in outward order. Lint has only the pre-existing section_dropped warning. The recognized completeness ledger remains 12 placed, 2 missing, 0 dropped of 14 requirements; this PR does not address those missing step lengths.
Focused tests: 4 passed (new scale/ladder tests, authored turned baseline, section-participant scale test). Ruff and diff check pass.