Skip to content

rc8: basic hole-location PMI dropped that rc7 placed ("no room beside the front") #2190

Closed

Description

@pzfreo

What

For the same AP242 plate as the out-of-bounds report (about 120 × 80 × 12 mm, with authored datums, positions, basic hole locations and toleranced distances), 0.5.0rc8 drops two authored basic location dimensions that rc7 placed below the side view:

pmi_dropped | PMI '35' not placed (no room beside the front)
pmi_dropped | PMI '85' not placed (no room beside the front)

rc8 does fix the duplicate: rc7 drew 120 ±0.05 and also the planner's own 120 (#2185). It looks as though the authored-precedence change (#2187) moved where these locations go, rather than the sheet being too full. The A1 sheet is mostly empty.

Lint counts:

  • rc7: 25 errors, with pmi_dropped 3
  • rc8: 26 errors, with pmi_dropped 4 and annotation_out_of_bounds 1

The STEP is not attached: it comes from a private tool. A synthetic reproducer can follow if needed.

Expected

Authored basic locations are placed as they were in rc7, or are placed instead of the planner's matching dimensions.

Activity

  1. pzfreo commented on Oct 5, 2026

    @pzfreo
    OwnerAuthor

    Reproduction

    STEP and script: https://gist.github.com/pzfreo/7c6a0be95a567e2774924207133b2d40

    • specify-plate-callout.step: Draftwright Specify's plate sample (https://draftwright.io/samples/specify-sample-plate.step geometry), with AP242 semantic PMI written by Specify. It has datums A/B/C, positions with basic hole locations from B and C, and two toleranced distances from C (120 ±0.05 to the far end, 75 +0.1/0 to the pocket wall).
    • repro.py: builds it with build_drawing(step, pmi="annotate") and prints the findings.

    On 0.5.0rc8 it prints:

    annotation_out_of_bounds | annotation '60' extends past drawable area (below by 667.0 mm) — increase margin or reduce offset
    pmi_dropped | PMI '35' not placed (no room beside the front)
    pmi_dropped | PMI '85' not placed (no room beside the front)
    pmi_dropped | m_gdt0 not placed (no legible room in any side strip or sheet fallback)
    pmi_dropped | m_gdt4 not placed (no legible room on its surface-normal left strip)
    

    On 0.5.0rc7 the same file has no annotation_out_of_bounds, and 35 and 85 are placed. In neither version does the 75 +0.1/0 distance appear on the drawing, and neither reports it as dropped.

  2. pzfreo commented on Oct 5, 2026

    @pzfreo
    OwnerAuthor

    Fixed by merged PR #2191 (db3b053): rejecting out-of-bounds strip ink lets the authored 35 and 85 PMI dimensions place. The synthetic corridor regression test covers sibling survival; the public Specify plate replay was also checked in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions