Skip to content

Document off/report sheets retain AP242 tolerance overrides from annotated acquisition #2188

Open

Description

@pzfreo

Reproduction

Using the committed CTC-03 fixture:

from draftwright import Document
from draftwright.model.planner import plan_dimensions

source = "tests/fixtures/nist_ctc_03_asme1_ap242.stp"
document = Document.from_part(source, pmi="annotate")
for mode in ("annotate", "report", "off"):
    sheet = document.sheet(mode, pmi=mode)
    sheet.auto_dimensions().auto_views()
    model = sheet._build_model_input()
    print(mode, sum(not item.suppressed and item.param.tolerance is not None
                    for group in plan_dimensions(model) for item in group.dims))

Executed on 2026-10-05: annotate 7, report 7, off 7. The seven approved values include four pattern-member diameters, the grouped pattern diameter, and two hole diameters. They carry AP242 tolerance values even in the lower-PMI members.

Cause and scope

The common annotated Document acquisition already lowers AP242 tolerances into canonical feature decorations/requirements. A later member can hide the raw source annotations by identity, but its inherited canonical measurements still carry those source tolerances. PR #2187 addresses raw authored dimension precedence; this behavior predates that PR and needs a member-specific policy for already-lowered tolerance values. Simply filtering raw AuthoredDimension features cannot undo a value already attached to a canonical feature. The fix should preserve explicit member-declared tolerances and the shared one-recognition inventory.

Acceptance

  • Off/report Document members do not print source AP242 tolerance overrides acquired solely for an annotate member.
  • Annotate member and explicit member-declared tolerance behavior stay intact.
  • A regression uses this CTC-03 fixture and asserts its own AP242 tolerance precondition.
  • Review against ADRs 1, 3, 4 and 5: one model inventory, one recognition run, explicit intent, truthful provenance.

Found during independent review of #2187; tracked separately because source-acquisition lowering must be made reversible per member across both decorations and canonical requirement fields.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions