Repository navigation
Conversation
|
Claude Opus 5.5 on @satchlj's behalf: hardware run.
Build: phellos (MacBook Air M2, J413, macOS 27.2 / 26B123 stub), default rebuilt 2026-11-20 = linux |
|
Build and host-test row from our lab (no 27.2 hardware run: our J413 is still on the 13.5 stub).
The probe dispatch only takes the 27.2 path for Review of the shared part, read against the Airs on 27.2: #2543 (comment) |
|
Claude Opus 5.5 on @satchlj's behalf. Merged #2544's new head f890a9c (the pool-slot cursor fix) as 6c5d3db. Nothing in this PR's own change is different. Cause, bisect and trials are in #2544 (comment). On phellos, with the module built from this head, h1–h8 passed 8/8 (3 × 1024 + 300 × 4096, 303/303), and the host tests passed 23/23. 🤖 Generated with Claude Code |
|
Blockers: 1.
The cfg split itself checks out. Assisted-by: LLM (Claude:Opus 5.5) |
0aac788 to
81446c7
Compare
a8d3cd3 to
3b55fec
Compare
81446c7 to
f5dfd26
Compare
3b55fec to
313361e
Compare
DjDeveloperr
left a comment
There was a problem hiding this comment.
Pre-PR checklist review at head 313361e8d8cf (stacked on #2544 and #2543).
Code & Kconfig Split
The CONFIG_DRM_ASAHI_G14_V27_2 split itself is clean: Sink, Job::{run,timed_out,cancel}, Queue::{new,new_g14_v27_2,submit}, m3/mod.rs, mmu.rs (FirmwareWindow/MAGIC_G14_V27_2), and task_comm() relocation handle all three enabled combinations (M3_T8122 only, G14_V27_2 only, both) and G15=n cleanly, and a G14_V27_2-only build refuses render commands with EINVAL before touching M3 symbols.
Blockers
- §4 Attribution / DCO — unsigned code-change commit (
313361e8d8cf).
Commit313361e8d8cf(Merge branch 'satchlj/g14-v27-2-compute' into satchlj/g14-v27-2-kconfig) is not a trivial merge: it introduces the new#[cfg(CONFIG_DRM_ASAHI_G14_V27_2)]gate changes onsleep_prepareandsleep_completeindrivers/gpu/drm/asahi/driver.rs, but carries noSigned-off-by:line. Per §4, every commit carrying authored changes must have a humanSigned-off-by:.- Fix: rebase this PR cleanly onto #2544's updated head so the three intermediate merge commits (
71d18e84,7d84e08c,313361e8) are dropped and the complete cfg split lives in a single cleanly bisectable, signed commit.
- Fix: rebase this PR cleanly onto #2544's updated head so the three intermediate merge commits (
- Stacked dependency blockers (#2543 and #2544).
This PR depends on #2543 and #2544, both of which have openREQUEST_CHANGESblockers that must be resolved before this branch can rebase and merge.
Pre-PR Checklist (§1–§6)
- §1 No model gating: Pass (for this PR's own diff; inherits #2544).
- §2 Production-ready, no hacks: Pass (for this PR's own diff; inherits #2544).
- §3 Safety: Pass (for this PR's own diff; inherits #2543/#2544).
- §4 Clean-room & attribution: Blocked on
313361e8d8cfmissingSigned-off-by:(Blocker #1). Non-merge commitb45a912chas human author/committer andSigned-off-by:only, and the PR body discloses agent assistance. - §5 Evidence: Partial. CI checks (
source,rust-build,kunit, DWC3/ATC matrix) are green. Still needed on the final rebased head: J413 regression counts (0 SELinux denials, 0 failed units, 0 new kernel errors), an M3 (T8122) hardware boot row with the cfg-splitm3_submit, and a G13/G14 13.5-stub no-regression row. - §6 Naming: Pass.
Assisted-by: LLM (Gemini 4 Neon)
The G14 firmware-27.2 runtime reuses the 26.x submission front end (m3_submit, agx_uapi and their helpers), so it was built only with CONFIG_DRM_ASAHI_M3_T8122. Give it its own option, DRM_ASAHI_G14_V27_2 (default y), and build the shared front end when either user is enabled: - m3/mod.rs: agx_uapi, agx_compute, agx_attachments, agx_memory and m3_submit build with DRM_ASAHI_M3_T8122 or DRM_ASAHI_G14_V27_2. - m3_submit.rs: the M3 sink, queue constructor, render validation, CDM launch check, timeout handling and fence-timing profile build only with the M3 runtime; without it a render command gets EINVAL. task_comm() moves here from m3_client.rs, which now calls it here. - The G14 path's own code is gated on the new option. Like the M3 runtime, the option depends on DRM_ASAHI_G15: the firmware's UAT is adopted through that backend's handoff helpers (Uat::new_adopted, the G15 UAT table cleaning). Signed-off-by: Satya Benson <satya@benson.earth>
313361e to
3d8b62c
Compare
f5dfd26 to
4c4f313
Compare
|
J473 (M2 Mac mini, G14G) hardware row, macOS 27.2 stub (26B123). The watchdog-backed one-shot used the packaged kernel built at
The one-shot test files were removed and the machine returned to the distro default. |
Claude Opus 5.5 on @satchlj's behalf.
Third of three PRs that replace #2473. It builds on #2544 (and #2543).
The G14 firmware-27.2 runtime reuses the 26.x submission front end (
m3_submit,agx_uapiand their helpers), so #2544 builds it only withCONFIG_DRM_ASAHI_M3_T8122. This PR gives it its own option and builds the shared front end for either user.What changes
DRM_ASAHI_G14_V27_2("Apple M2 (G14G) on GPU firmware 27.2, compute only"),default y. Like the M3 runtime, it depends onDRM_ASAHI_G15, because the firmware's UAT is adopted through that backend's handoff helpers (Uat::new_adopted, the G15 UAT table cleaning).m3/mod.rs:agx_uapi,agx_compute,agx_attachments,agx_memoryandm3_submitbuild withDRM_ASAHI_M3_T8122orDRM_ASAHI_G14_V27_2.m3_submit.rs: the M3 sink, queue constructor, render validation, CDM launch check, timeout handling and fence-timing profile build only with the M3 runtime. Without it a render command getsEINVAL.task_comm()moves here fromm3_client.rs, which now calls it here.G15 && M3_T8122.Tested
Builds against the packaged phellos kernel (7.3.0-1-up1-ARCH) in four configurations, with no new warnings from this series: G14_V27_2 + M3 runtime; G14_V27_2 without the M3 runtime; M3 runtime without G14_V27_2; and G15 off (both off).
On phellos (J413, firmware 27.2), the module built without
DRM_ASAHI_M3_T8122and loaded with no parameters, under the same watchdog arrangement as drm/asahi: G14 compute on GPU firmware 27.2 #2544: trial c4, this head: PASS, 303 of 303 dispatches, 0 bad words; normal stop; cleanrmmod; return to the default. Trial c2, an earlier version of this PR differing only in cfg attributes on helpers: the same. Each trial: Vulkan compute, 303 dispatches, every word checked, normal stop, cleanrmmod, unattended return.Head
7fcd6e20(merges the review commits of drm/asahi: share the 26.x wire helpers and clean bound TTBAT slots #2543 and drm/asahi: G14 compute on GPU firmware 27.2 #2544; no change to this PR's own files): module built against phellos's up2 default kernel and run there, trial d8: PASS, 303 of 303 dispatches, every word checked, clean stop andrmmod. Details in drm/asahi: G14 compute on GPU firmware 27.2 #2544. Also built withDRM_ASAHI_G14_V27_2and withoutDRM_ASAHI_M3_T8122, with no new warnings.Untested
m3_submitbehind cfg. They compile unchanged in M3 builds, but no M3 machine booted this.DRM_ASAHI_G15dependency. That would move the adopted-UAT helpers out of the G15 backend and is not part of this series.Assisted-by: LLM (Anthropic:Claude Opus 5.5)