Repository navigation
Conversation
d216aba to
6c62f79
Compare
Bring up the T8112 (G14G B0) GPU with the macOS 27.2 (26B123) firmware and hand the running firmware to a compute-only DRM device. The bring-up path builds the 26B123 root, directory and channels from the existing 13.5 G14G graph (the versioned code is also instantiated as G14/V27_2), starts the firmware with GPU-owned writable registers, runs one kernel-owned compute job and, with t8112_drm=1, keeps the firmware running for a DRM backend instead of stopping it. Client compute commands come through the 26.x submission front end and are re-encoded as 26B123 G14G compute commands; client contexts are bound through the adopted UAT. Runtime behaviour found on hardware and handled here: - the DRM scheduler needs one run queue per client priority (4); - the front end's control-stream launch check decodes the G15 CDM launch format and is skipped for G14 streams; - the firmware unlinks a command's tracking slot only when its retirement cursor reaches the value it recorded; the host writes that value on retirement and reuses a slot only once it is unlinked; - with several commands in flight the shared stamp can be written out of order, so retirement follows the queue's retired position, which the firmware advances in order; - the firmware-to-host event ring and the firmware log rings are acknowledged by advancing their consumers; without that the event ring filled after 255 events and the 256th client command was never fetched. Every take-over failure halts the firmware (allow-off, RTKit power-off, ASC run bit) and keeps all firmware-reachable memory. The DRM device is compute-only: its queues reject render commands. All of it is gated by module parameters (t8112_handshake, t8112_drm, default off) and by the GPU node's device-tree resources and properties; nothing changes for other machines. The bring-up root and the backend reuse the M3 submission front end, so they are built only with DRM_ASAHI_M3_T8122 (gpu/j413_root.rs, j413.rs). The asahi-m4 retention test's UatInner stand-in gains the new clean_poc field that bind_inner now reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Satya Benson <satya@benson.earth>
6c62f79 to
e148759
Compare
|
Thanks for this. A compute device on the M2's 27.2 firmware is a big step. We prefer that a machine works with the default kernel and build, so a few things block merging this form:
Could you split out the shared fixes and land the backend as the G14 firmware-27.2 path? We can then run rows on our M2 (G14G), M1 Pro, M4 Pro and A18 Pro. |
|
Claude Opus 5.5 on @satchlj's behalf. Thanks, I agree with all four points. I read the whole review against the branch ( What the parameters are. Of the 62, about 35 carry the tested set. The rest are of two kinds:
So "working defaults" means keeping one path, the tested one, and deleting the others, not just flipping defaults. The One more blocker you didn't list. The tested set needs Plan (each step as its own PR, each re-run on J413 27.2: the 303-dispatch Vulkan compute check and a clean
Not started yet, and nothing pushed for this review. Render stays out of scope. |
|
Thanks for the careful read and the plan. A series is what we would prefer: shared pieces first, then the backend as the G14 firmware-27.2 path, then the build change. Keeping this PR open as the tracking reference until step 2 is up, then closing it, works for us. Capturing the slot-9 page in the driver at probe is the right call, and dynamic debug for the firmware log is better than a parameter. We will run M2 rows on each step as it lands. |
|
Claude Opus 5.5 on @satchlj's behalf. Closing in favour of the split you asked for, as three stacked PRs:
One correction to my plan comment above: the slot-9 snapshot was not actually needed. In the tested set, On phellos (J413, firmware 27.2) the packaged default kernel loaded each final head's module with no parameters. Vulkan compute passed on both: 303 dispatches, every word checked, normal stop, clean The 27.2 root is still built on the records of a 13.5 G14 manager; 🤖 Generated with Claude Code |
|
Claude Opus 5.5 on @satchlj's behalf. Sorry, I closed this before I saw your 08:53 reply. The series is in the order you asked for: #2543 (shared pieces), #2544 (the backend as the G14 firmware-27.2 path), #2545 (the build change). Step 2 is up, so I've left this closed as the tracking reference, per your note. On your two points:
Both final heads passed on phellos: #2544 in the default config, and #2545 built without 🤖 Generated with Claude Code |
Claude Opus 5.5 on @satchlj's behalf.
Brings up the T8112 (G14G B0) GPU on the macOS 27.2 (26B123) GPU firmware and hands the running firmware to a compute-only DRM device (
aurora, one render node). Based onintegration/aurora449c6a1. Compute only: render commands are refused.What it does
gpu/j413_root.rsbuilds the 26B123 root, directory and channels from the existing 13.5 G14G graph (the versioned code is also instantiated as G14/V27_2), starts the firmware, and runs one kernel-owned compute job. Witht8112_drm=1the firmware stays running andj413.rstakes it over.m3_submit) and are re-encoded as 26B123 G14G compute commands. Client contexts are bound through the adopted UAT. Queues of this backend reject render commands withEINVAL.Selection
apple,agx-t8112-identifyandapple,firmware-version = <27 2 0>. The bring-up also checks the node's resources and properties (thesgxandascregions, theshared-l2reservation,apple,coredump-copy-buffer,apple,meta-sw-interrupt).t8112_handshakeandt8112_drmenable it (both default 0).CONFIG_DRM_ASAHI_M3_T8122.UatInnerstand-in gains theclean_pocfield thatbind_innernow reads.What it needs
t8112_handshake=14 t8112_telemetry_ro=1 t8112_idle_policy=1 t8112_dashboard_ram=1 t8112_cre=1 t8112_performance_control=1 t8112_event_completion=1 t8112_base_request=1 t8112_mtr_sensors=1 t8112_fast_die_fields=4 t8112_alarm_fields=13 t8112_power_curve=1 t8112_calibrated_sensors=26624 t8112_power_filter=1 t8112_command_service=1 t8112_service_stage=0 t8112_firmware_log=1 t8112_active_followup=2 t8112_command_notifier=12 t8112_drain_statistics=1 t8112_stock_header=1 t8112_completion_record=1 t8112_power_zones=0 t8112_dashboard_real=1 t8112_firmware_trace=1 t8112_drm=1 t8112_job_context=0 t8112_priority_row=2 t8112_tail_probe=3 t8112_hw_legacy=448 t8112_queue_lane=1 t8112_compute_job=1 t8112_state_cap=100 t8112_forced_stop=1. Many of the othert8112_*parameters are bring-up diagnostics.t8112_dashboard_ram=1, a 16 KiB snapshot of the live slot-9 register page asapple/t8112-gpu-slot9-seed.bin, saved before the module loads.Tested: MacBook Air M2 (J413), firmware 27.2 (26B123)
The module was built from this branch against the machine's running 7.3 kernel, with three build-only substitutions for things that kernel predates: the mesh-output UAPI constant, the
recv_message_timedRTKit callback member, and the v27 SoC sleep helpers used by g17/sleep.c. T8112 never reaches those paths. Each trial was a one-shot boot under the hardware watchdog, returning unattended to the normal kernel.rmmod aurorastops the firmware normally: allow-off acknowledged, status 0, no forced power-off.d216aba7,6c62f79e(after the build-config split) and the final heade1487598.DRM_ASAHI_M3_T8122off, and it was also built that way on an arm64 host.Not tested
apple,agx-t8112-identifynode, the probe is unchanged.🤖 Generated with Claude Code