Repository navigation
media: apple: isp: add firmware version 27.2 - #1831
RyanTheTide wants to merge 1 commit into
Conversation
macOS 27.2 (build 26B123) ships the legacy-ABI ISP firmware on the M1/M2/M3 image signal processors with an apple,firmware-compat of <27 2 0>. The parser has no arm for it, so the version reads back as UNKNOWN. UNKNOWN sorts below ISP_FIRMWARE_V_13_5, which makes isp_cmd_ch_set_file_load() fall to the 12.x 32-bit set-file record; 27.2, like every firmware from 13.5 on, expects the 64-bit record. Add ISP_FIRMWARE_V_27_2 after ISP_FIRMWARE_V_26_6_2 so it stays above 13.5, parse exactly <27 2 0>, and print "27.2". The firmware stays ISP_FW_ABI_LEGACY and the existing >= ISP_FIRMWARE_V_13_5 condition then selects the 64-bit set-file format. 27.2 is a normal legacy firmware and is not caught by the J613-only 26.6.2 preview admission gate. A KUnit case covers the string and the ordering invariant that drives the set-file selection. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
|
Claude Opus 5.5 on @satchlj's behalf. Hardware result on MacBook Air M2 (J413, T8112), macOS 27.2 (26B123) stub: pass. ISP probe and capture work. One-shot boot
🤖 Generated with Claude Code |
|
Claude Opus 5.5 on @satchlj's behalf: hardware run.
Build: phellos (MacBook Air M2, J413, macOS 27.2 / 26B123 stub), default rebuilt 2026-11-20 = linux |
|
Early note on this draft (no full review yet):
Assisted-by: LLM (Claude:Opus 5.5) |
|
Superseded by 0872ebb in integration/aurora, which already parses firmware 27.2.0 for the ISP. |
Part of the macOS 27.2 (build 26B123) firmware port for the M1/M2/M3 Macs (FW272).
The M1/M2/M3 image signal processors run the legacy-ABI ISP firmware with an
apple,firmware-compatof<27 2 0>. The version parser had no arm for it, so it read back as UNKNOWN. UNKNOWN sorts belowISP_FIRMWARE_V_13_5, which would makeisp_cmd_ch_set_file_load()fall back to the 12.x 32-bit set-file record; 27.2, like every firmware from 13.5 on, expects the 64-bit record.This adds
ISP_FIRMWARE_V_27_2afterISP_FIRMWARE_V_26_6_2(keeping it above 13.5), parses exactly<27 2 0>, prints27.2, and leaves the firmwareISP_FW_ABI_LEGACYso the existing>= ISP_FIRMWARE_V_13_5condition selects the 64-bit set-file format. 27.2 is a normal legacy firmware and is not caught by the J613-only 26.6.2 preview gate.A KUnit case (
apple-isp-fwver) covers the string and the enum ordering invariant that drives the set-file selection.Tested:
apple-isp-*KUnit green under arm64/QEMU (44 tests incl. the newisp_test_fw_version_27_2). No hardware yet runs 27.2 firmware on the Linux side; functional ISP qualification is gated on the per-Mac 27.2 stub.Draft: part of the staged FW272 series; held until the 27.2 stub boots for hardware verification.
Assisted-by: LLM (Claude:Opus 5.5)