Repository navigation
Conversation
|
Looks fine. The bit is set only by the G14 27.2 backend's The branch carries merge commits from the stack (68722a4). It will want a rebase onto integration/aurora, keeping just this commit, once #2545 is in. Assisted-by: LLM (Claude:Opus 5.5) |
a8d3cd3 to
3b55fec
Compare
68722a4 to
0b3789c
Compare
3b55fec to
313361e
Compare
0b3789c to
c9aab7e
Compare
DjDeveloperr
left a comment
There was a problem hiding this comment.
Pre-PR checklist review at c9aab7e770ce141892a81a7fcc3d3740000d033a (§1–§6): REQUEST_CHANGES (1 §4 commit-hygiene blocker + CI/§5 holds).
Code & Source Verification (0 code bugs)
include/uapi/drm/asahi_drm.h:541definesDRM_ASAHI_FEATURE_COMPUTE_ONLY ((1ULL) << 41)using the same#defineconvention as bits 32–38 (avoiding wideningenum drm_asahi_feature). Verified bit 41 is free onintegration/aurora(highest bit 38) and across open PRs (#2059/#2679use 39;#2523uses 40).drivers/gpu/drm/asahi/g14_v27_2.rs:836-840ORsuapi::DRM_ASAHI_FEATURE_COMPUTE_ONLY as u64intoBackend::feature_flags(), whichdrivers/gpu/drm/asahi/file.rs:587propagates intoDRM_IOCTL_ASAHI_GET_PARAMS, matching how bits >= 32 (USERPTR,GEM_RESIDENCY,RENDER_MESH_OUTPUT) are consumed via bindgen.- Verified
drivers/gpu/drm/asahi/m3/m3_submit.rs:268,278-282:Queue::new_g14_v27_2unconditionally setspreempt_alloc: Some(...), andQueue::submitunconditionally rejectsParsedHardwareCommand::RenderwithEINVALfor it whetherCONFIG_DRM_ASAHI_M3_T8122is enabled or not.
Blockers
- §4 Attribution / DCO violation: Commit
c9aab7e770ce141892a81a7fcc3d3740000d033a(Merge branch 'satchlj/g14-v27-2-kconfig' into satchlj/g14-v27-2-compute-only) has noSigned-off-by:trailer. Every commit in the PR must carry a humanSigned-off-by:. In addition, the PR description says "One commit" while the branch carries this stray merge commit. Please rebase cleanly onto the base branch so only the single signed-off commit (af64ed5c) remains.
Additional Holds (CI & §5)
- CI:
statusCheckRollupis empty (0 checks ran onc9aab7e7because the PR targetssatchlj/g14-v27-2-kconfig, whereashost-tests.ymltriggers onintegration/aurora/aurora-wip). Once#2545merges, rebase ontointegration/auroraand confirm CI passes. - §5 Evidence: The phellos test summary reports functional checks and Borealis queue-flag verification, but does not report the §5 regression gate counts (
0 SELinux denials / 0 failed units / 0 new kernel errors) on the final head.
Checklist Summary
- §1 No model gating: Pass — backend-reported capability bit, no board/chip gating.
- §2 Production-ready: Pass.
- §3 Safety: Pass.
- §4 Clean-room & attribution: Fail (missing
Signed-off-by:on merge commitc9aab7e7;af64ed5cand PR bodyAssisted-by:are clean). - §5 Evidence: Incomplete (missing 0 AVC / 0 failed units / 0 new kernel errors row on rebased head).
- §6 Naming: Pass (
Borealis,aurora,aura#402).
Assisted-by: LLM (Gemini 4 Neon)
The G14 firmware-27.2 runtime refuses render commands, but nothing in GET_PARAMS says so. Graphics userspace therefore takes the device for GL: on phellos (J413) with the GPU published, kmsro picked the aurora render node for the internal panel, and the greeter's Hyprland and sddm-greeter-qt aborted after their first renders failed with EINVAL. Add DRM_ASAHI_FEATURE_COMPUTE_ONLY (bit 41; bits 39 and 40 are claimed by open PRs #2059 and #2523) and set it on that runtime. It is a property of the device, not of a board or chip list: Mesa can decline to create a graphics screen or a graphics queue on a device that reports it, and fall back to software rendering, while compute keeps working. Kernels without the bit keep their current behaviour. Signed-off-by: Satya Benson <satya@benson.earth>
313361e to
3d8b62c
Compare
c9aab7e to
3515e7d
Compare
|
Re-checked at 3515e7d. The branch is now the single signed-off commit on top of Assisted-by: LLM (Claude:Opus 5.5) |
Claude Opus 5.5 on @satchlj's behalf.
Stacked on #2545 (G14 compute on GPU firmware 27.2). One commit.
Problem. The G14 firmware-27.2 runtime refuses render commands (
m3_submit), but GET_PARAMS gives userspace no way to know that. On phellos (J413 / T8112, macOS 27.2 stub), with the GPU published by aura#402, udev autoloads aurora and graphics clients take its render node. The greeter's renders fail (DRM_IOCTL_ASAHI_SUBMIT render failed: Invalid argument (2560x1664 …)), then Hyprland aborts and sddm-greeter-qt dumps core.Change. Adds
DRM_ASAHI_FEATURE_COMPUTE_ONLY(bit 41) to the uapi, reported by the G14 firmware-27.2 backend'sfeature_flags(). It describes the device; nothing selects by board or chip. Bits 39 and 40 are already claimed by open PRs #2059 (VM_FENCE_ERROR_COUNT) and #2523 (VDM_USC_INVALIDATE) and their Mesa counterparts. No other backend sets the bit, so kernels and devices without it behave as before. The Mesa side is aurora-silicon/mesa#585.Tested on phellos, in two one-shot boots of the same kernel: integration/aurora 4e58401 + linux#2519, #1832, #1831, #2264, #2526 (419bb47), #2543 → #2544 → #2545, and this commit. Stage 2: aura#402.
VK_QUEUE_GRAPHICS_BIT(flags 0xf → 0xe). Vulkan compute 3 × 1024 + 300 × 4096 dispatches, every word checked: PASS on both boots (54.0 ms and 50.0 ms for the 300). dEQP-VK compute subset: 0 Fail/Crash either way (numbers on the Mesa PR).Not fixed by this alone: the greeter still crashes. Hyprland/aquamarine take the system's only renderD node directly (aquamarine's sole-render-node fallback for split KMS/GPU platforms), and Hyprland asserts on any EGL failure there, so it never reaches the KMS-device path where Mesa can fall back to software. That needs a device-selection change in aquamarine; this PR and the Mesa PR only give userspace the bit to decide with.
Untested: any other machine (no other backend sets the bit); suspend (not exercised: see #2544).
Assisted-by: LLM (Anthropic:Claude Opus 5.5)