Repository navigation
drm/apple: admit the M1/M2/M3 display processors on firmware 27.2 - #1832
RyanTheTide wants to merge 2 commits into
Conversation
The T8103, T600x, T8112, T602x, T8122, T6030 and T603x display processors share one firmware-27 wire generation with the T6050: the same IOMobileFramebuffer method numbering, AFK wire v2 and v27 drive record. On exact firmware-compat 27.2.0 they should run that generation instead of the 14.7-era session the boot loader previously handed them. Give each of these processors' DCP and dcpext a version-aware firmware-27 admission. dcp_check_firmware_version() now selects DCP_FIRMWARE_V_27_0 with the in-tree 27.2.0 method table before the 14.7 board and special-profile checks, so the T8122 and T6030 14.7-only rejections no longer apply to the 27.2 arm. The older admissions stay in place unchanged for the firmware those boards still boot, and the probe keeps each processor's port count, tunnel-flow flag, connector topology, DMA width and DART resources from its own match data; only the live-session adoption is version-selected. The shared v27 method-table validation is factored into one helper reused by both firmware-27 arms. Add an apple-dcp-v27 KUnit suite covering which compatibles the admission recognises, that the non-refmac firmware-27 processors keep their own paths, and that the 27.2.0 method table is complete. Assisted-by: LLM Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Firmware 27 was admitted three ways: T6050 by its match data, T8142 by its compatible on exact 27.0.0, and the M1/M2/M3 processors through a list of fourteen DCP and dcpext compatibles on exact 27.2.0. The deciding facts are the same everywhere: the DCP reports firmware-compat 27 or later, and the driver has a complete method table for that build. Replace the compatible list and the T8142 arm with one helper, dcp_v27_admission(), used for every DCP and dcpext before any per-SoC selection. A firmware-compat of 27 or later runs the firmware-27 instance when iomfb_v27_methods() has a complete table for the build, and is not started otherwise: the interfaces written for older firmware make it panic (T8142 on 27.0 with H17P). Older firmware keeps the existing 26.x, 14.x and 13.x selection unchanged. Every processor on firmware 27 adopts the live session the loader handed over. What stays per SoC has a hardware reason: the T6050 has no interface older than firmware 27; the T8140 dcpext is refused before selection on anything but 26.6.2; T8142 on firmware 27 keeps the default method profile, since with H17G every swap fails with status 4. This also admits T6041, T8132, T8140 and T8142 on firmware 27 builds with a complete table (T8142 newly on 27.2.0); none has been run on 27.2. The T8140's method profile on firmware 27 is left to a separate change. Rewrite the apple-dcp-v27 KUnit suite for the rule: complete 27.x tables are admitted, 27.x and later builds without a usable table are refused, older firmware is left to the older selection. Signed-off-by: Ryan <ryan@aurorasilicon.org>
|
Claude Opus 5.5 on @satchlj's behalf. Hardware result on MacBook Air M2 (J413, T8112), macOS 27.2 (26B123) stub: pass for the internal panel, dcpext probe and s2idle. External display with a monitor attached is not tested yet. One-shot boot
Still to run: an external monitor over USB-C DP (needs someone at the machine). VRR does not apply to this panel. 🤖 Generated with Claude Code |
|
Claude Opus 5.5 on @satchlj's behalf. Follow-up from the J413 27.2 stub: this PR no longer merges cleanly into Built that way, together with #2526, it is now phellos's default. Internal panel at 2560x1664@60, brightness readback, dcpext up, s2idle cycle: pass. 🤖 Generated with Claude Code |
|
Claude Opus 5.5 on @satchlj's behalf: hardware run.
Build: phellos (MacBook Air M2, J413, macOS 27.2 / 26B123 stub), default rebuilt 2026-11-20 = linux |
|
Blockers: 3.
Nit: commit 3b7f78d is signed off with a short name; c22954a uses the full name. Use the same identity on both. HW row: rebased head on the J413 (27.2 stub): panel, backlight readback, dcpext probe, 2x s2idle. Then a production-firmware refmac (J316s on 14.x/26.x) showing the same Assisted-by: LLM (Claude:Opus 5.5) |
|
J473 (T8112) hardware row on macOS 27.2 (26B123), using a narrow adaptation of the method-table admission on integration snapshot
The native HDMI row exposed BT.2020 RGB and the HDR metadata property, with zero EDID bytes and The live-session case needs an adoption path that preserves the loader's RTKit session and carries the discovered endpoints and inherited buffers. Waking it through the normal INIT/EPMAP handshake timed out on both loader variants. |
Part of the macOS 27.2 (build 26B123) firmware port for the M1/M2/M3 Macs (FW272).
The 26B123 DCPs for T8103, T600x, T8112, T602x, T8122, T6030 and T603x are one wire generation and share the firmware-27 method table already in
iomfb_v27.c(added for T6050). There are no per-SoC method-ID deltas, so no new method constants are introduced here — only version-aware admission.On exact
apple,firmware-compat = <27 2 0>, the DCP and dcpext match data for these SoCs now selectDCP_FIRMWARE_V_27_0withiomfb_v27_methods("27.2.0")before the 14.7 board / special-profile checks, and the 14.7-only rejection is lifted for the exact 27.2 arm. The older 14.7/26.6.2 arms are preserved for other firmware during the transition. Per-SoC topology is untouched:num_dptx_ports, the T6020 tunnel-flow flag, connector topology, DMA width and DART resources are preserved, anddfb_ready_queryis not sent.Shared helpers (
dcp_refmac_v27_compat(),dcp_v27_method_table_supported()) keep the selection in one place; the T6050 match structure is not copied wholesale.Tested: new
apple-dcp-v27KUnit cases admit all 14 refmac compatibles, reject T6050/T8142/T6041/T8140, and assert the 27.2.0 table is complete; fullapple-dcp*regression 161/161 green under arm64/QEMU. W=1 clean.Hardware verification (panel start, clocks, dcpext, VRR, sleep) is gated on the per-Mac 27.2 stub and tracked separately. Panel nits/EDR generalization, DT
apple,clock-ids/<27 2 0>publishing and aura handoff are follow-ups.Draft: part of the staged FW272 series.
Update: the compatible list is replaced by one rule for every DCP and dcpext,
dcp_v27_admission(): a firmware-compat of 27 or later runs firmware 27 when its build has a complete method table and is refused otherwise, and every firmware-27 processor adopts the loader's live session.Assisted-by: LLM (Claude:Opus 5.5)