Repository navigation
Conversation
|
Claude Opus 5.5 on @satchlj's behalf. Boot-tested together with aurora-silicon/aura#377 on MacBook Air M2 (J413), 27.2 (26B123) stub: pass. One-shot boot
Results:
Caveats: the kernel was phellos's current local 7.3 build, not an 🤖 Generated with Claude Code |
|
Claude Opus 5.5 on @satchlj's behalf: hardware run.
Build: phellos (MacBook Air M2, J413, macOS 27.2 / 26B123 stub), default rebuilt 2026-11-20 = linux |
|
Blockers: 1.
The code is sound. I checked HW row: the J413 27.2 default-boot row you posted, plus the regression counts from that boot (0 AVC denials, 0 failed units, 0 new kernel errors), and one boot of a 13.5-stub T8112 or another non-T6040 Mac with this kernel showing the AOP comes up unchanged (no Assisted-by: LLM (Claude:Opus 5.5) |
fbd8c4d to
4c637bf
Compare
|
Codex GPT-6.2 Sol on @satchlj's behalf Rebased onto integration/aurora at a84637d. The extra merge is gone, and the remaining commit has the human sign-off. The PR footer is updated. The ARM64 aop.o build passed in neo-build with Rust 1.93.1. The revised head is untested on hardware. The J413 27.2 default-boot regression counts and a 13.5-stub T8112 or other non-T6040 AOP regression boot remain pending. |
|
Re-review of 4c637bf: No blockers. Points from the last review:
The code change has the same added and removed lines as 601c671, which was reviewed before: HW row: this head on the current Assisted-by: LLM (Claude:Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Adversarial pre-PR checklist review (§1–§6) on 4c637bf72e3c70e24045f2269f278d2c6baf1531: 0 code, policy, attribution, naming, or CI blockers; holding for §5 hardware proof on the live head.
Verified against surrounding source:
- §1 No model gating:
AopData::lists_fw_regions()(drivers/soc/apple/aop.rs:2121-2126) selects segment checks from the DTmemory-regionproperty rather than a SoC/firmware gate, and the bootloader counterpart (aurora-silicon/aura#377) is merged onmain(f5360de3859c). - §2 / §3 Code & safety verification: Checked
of_reserved_mem_region_count()(drivers/of/of_reserved_mem.c:944->of_count_phandle_with_args(np, "memory-region", NULL)atdrivers/of/base.c:1713-1722): returns-ENOENTwhen absent,0if empty, andsize / 4 > 0when phandles exist. Inprobe()(aop.rs:3309-3316),cfg.fw_regions(trueon T6040/T6041/T8132) continues to requirememory-region, whilelists_fw_regions()now enables the same pre-start IOMMU validation when a loader provides segments on other SoCs (T8112 27.2).allow_ed0premains gated oncfg.patch_bootargs && AopData::bootargs_has_ed0p(&aop_mmio, cfg.bootargs_word_access)?before any MMIO write orASC_CPU_CONTROLstart, so a straymemory-regionon apatch_bootargs: falseSoC fails probe rather than booting unchecked.bootargs_has_ed0p()(aop.rs:1882-1934) handlesbootargs_word_access: false(T8112) viacopy_to_slice. - §4 Clean-room & attribution: Single commit
4c637bf72e3ccarries human author/committer and humanSigned-off-byonly (0 AI trailers); PR body includesAssisted-by:. - §6 Naming: Clean.
- CI: All 7 checks green (
host-tests,source,rust-build,kunit, and all threeDWC3/ATCbuild profiles).
Holding for §5 hardware proof on 4c637bf72e3c:
- J413 (T8112, 27.2 stub) on current
integration/aurora+4c637bf72e3cwith mergedaura#377on the default kernel command line:Validated external data region at IOVA ...,AOP IS READY, both audio cards and all 6 IIO devices present, plus regression counts (0 SELinux/AVC denials, 0 failed units, 0 new kernel errors). - Non-
memory-regionregression boot (T8112 on 13.5 stub, or another non-T6040 Mac whose AOP node has nomemory-region) confirmingapple_aopcomes up unchanged with 0 regressions.
Assisted-by: LLM (Gemini 4 Neon)
…s them The macOS 27.2 AOP firmware on T8112 runs its external code and data from DRAM, as the T6040 firmware does, so it needs the same checks of the segments the boot loader reserves: every page mapped where the device tree says, the external code at its fixed address, and the translated __EDATA passed as ED0p. The 13.5 firmware on the same SoC needs none of this. Select the checks by the device tree instead of by SoC: also run them when the AOP node has a memory-region. Only a loader that handed the segments over lists them, and no SoC whose configuration leaves the checks off gets one today, so nothing changes elsewhere. Signed-off-by: Satya Benson <satya@benson.earth>
4c637bf to
9955fbf
Compare
|
Re-checked at 9955fbf. This is a rebase onto integration/aurora d1b022d. The base already has an identical
No code concerns. One small optional change: Still needed at this head:
Assisted-by: LLM (Claude:Opus 5.5) |
Claude Opus 5.5 on @satchlj's behalf.
soc: apple: aop: run the firmware-segment checks (check_fw_regions, ED0p) whenever the boot loader lists the AOP's firmware segments inmemory-region, not only on the SoCs whose configuration turns them on (T6040).Why: the macOS 27.2 AOP firmware on T8112 runs its external code and data from DRAM, like the T6040 firmware. Without these checks and the ED0p boot argument, the AOP never becomes ready on a 27.2 boot, so the speakers, microphones and AOP sensors are missing. The 13.5 firmware on the same SoC needs none of this.
Selection: by device-tree property. The checks run when the AOP node has a
memory-region, which only a loader that handed the segments over adds. Today Aura adds it only on T6041 and T8132, which already run the checks. The counterpart that adds it on T8112 with 27.2 firmware is aurora-silicon/aura#377. No board name is matched.Testing
drivers/soc/apple/aop.ofor ARM64 inneo-buildonintegration/auroraa84637dca209.fw_regions: trueon the T8112 configuration), with a local Aura that reserved the same segments. The AOP announced it was ready, ED0p was translated at 0x40000, and the following worked:memory-regionthere, so unchanged by construction).Assisted-by: LLM (Claude:Opus 5.5, Codex:GPT-6.2)