Repository navigation
ground plan GP12.4 step 1: tunnel rules A and B in the bake's levels (no pixel change) - #3488
Conversation
…r, and only a way on top hides it Two rules in the levels that the feature bake computes for tunnels: - Within open_max_m of a tag end, a tunnel station with too little cover is OPEN also where its floor lies over the terrain model: the way goes on as a ground way on its bank until the cover holds. - A paved stroke hides a tunnel station only where its surface lies more than the at-grade band (the lower snap_height_m of the two ways) over the floor. The lift on free ground still reads every paved stroke: a paved face never moves. The features take revision 21 and the fixture is baked again: one tunnel feature changes its levels tag. The spec says how a tunnel station gets its state. The device code does not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
…ls rules The bridge's code does not change; CI measured 806,965 B gzipped (+118 B) and 2,087,266 B raw (+4 B) on the head with the rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review of pull request #3488 (GP12.4 tunnel step 1: rules A and B in the bake's levels)Head 674d660, base Verdict: MERGE. No blocking finding. One small spec fix (N1) is recommended in this pull request, because it is Blocking findingsNone. I looked for each block reason of the brief:
Non-blocking findingsN1. The new spec sentence does not say which tag end the OPEN rule reads. N2. Rule A can leave an OPEN stretch that ends in a HIDDEN one with the floor over the terrain. Example on box B: N3. The node-map fault is a bridge bug too, and it has no issue of its own. N4. Rule B's "on top" test and the crossing's ladder read the heights at different points. N5. The 1 m lift still reads every paved stroke (documented deviation 2). The reason ("a paved face never moves") N6. The pull request body says "no device code", but the bridge's bytes moved. I read the N7. Spec style. The new sentence ends on a very long line that also holds the next sentence ("Else it is N8. For step 2 (not this pull request). When What I checked and found soundS1. No pixel change. S2. The rules as built.
S3. Bridges. By construction: S4. Bake and device. The rule values are step options: S5. Tests. S6. The census. From S7. The deviations. S8. The WASM guard. See N6. Recording 806,965 B and 2,087,266 B is right. What I could not check
Generated by Claude Code |
… tag end Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The bridge's recorded size takes ground-plan's for now; this branch records its own CI size on the merged base next. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ls rules on the passage rule CI on 681070b measured 808,099 B gzipped (-172 B) and 2,090,936 B raw (+0 B); the bridge's behaviour does not change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tunnel step 1 of GP12.4 (#3345): two rules in the levels that the feature bake computes for tunnels. No device
behaviour changes, and no pixel changes.
The two rules
open_max_m(30 m,plan.jsonstructures: the longest open cut of the crossing design) of atag end, a tunnel station that has too little cover is OPEN, also where its floor lies over the terrain model.
The way goes on as a ground way, on its bank, until the cover holds. There is the portal line. Before, such a
station was HIDDEN when its floor lay more than
snap_height_mover the terrain.band over the floor: the lower
snap_height_mof the two ways (0.5 m in every class row ofroads.json), thesame band as at a crossing. A lower way beside the mouth, or a path that crosses at the floor's height, does not
hide the tunnel any more.
The 1 m lift on free ground (
lift_max_m) still reads every paved stroke: a paved face never moves, so the groundthere cannot be lifted, whatever its height.
Both values are in the rule tables and in the options of the bake step already (
structures, andsnap_height_min the graph fields of
level_rows), so a change of them bakes again. The code of the levels changed, soplanner/trailview-featurestakes revision 21 and the fixture is baked again. The spec(
specs/trailview-features.md, Structures) now says how a tunnel station getsB,OorH(after thereview:
Obefore the firstBfrom its nearer tag end, as the code reads it).The census: closed mouths of test box B
The probe of the diagnosis, over all 1,014 portals, on one tile set: the zoom-13 tiles of a box B bake of this head,
with the zoom-13 and zoom-12 terrain of the checkpoint 5 grid (the terrain that the bake reads). Before: the base
code (67092ce). After: this head. A mouth is closed when, from the tag end on its own tunnel way, the levels hide
the way before any portal line, or when a closed line lies less than 5 m behind its first portal line. The reason is
the one the probe gives at the base.
No mouth closes that was open. Of the 1,013 portals with a way end (one has none in the data), 958 mouths are open
before and 993 after. 35 open: 25 by rule A (the floor over the terrain model), 10 by rule B (a lower way beside the
mouth, or a way at the floor's height).
Why 20 and not the 19 of the diagnosis:
bake reads, the base closes 55: 19 mouths of the 58 are open there, and 16 others are closed.
no tag end at their portal, so their stations there lie "more than 30 m" from a tag end:
map of the levels (
Ctx::nodes, one entry per way and direction) takes that junction for the way's end node.The tunnel then seems to go on at its portal.
floor's height).
The 20 that stay closed:
Proofs
cell::build_storeys,mesh_cellandmesh_storeys: the records with the storeys' records, the faces, the farblock, the rim, the mesh, and in the 47 cells with storeys the storey mesh, its ways and its ground ends are
byte-equal in 256 of 256 cells. The way graph of the device (the level of each way, and its levels) is equal too.
The device reads a tunnel way's
levelstag nowhere yet (level_tags::splitkeeps a tunnel way's level).copies of one tunnel feature (a funicular) change their
levelsonly: a hidden tail after its portal is now open.of every zoom-16 cell (10,752 cells), base against head on the same tiles: the
levels,storeyandslabofall 2,739 deck features and of the 57 other features with level tags are equal; 38 of 651 tunnel features change.
So no deck changes, also where a deck meets a tunnel. The head's merge equals the tags that the bake wrote, for
all 3,447 features.
graph/tests.rs). Each fails on the base rule. The terrain helperplanemoves from the heights tests to the shared test module, unchanged; no existing test changes.a_tunnel_that_comes_in_over_the_terrain_is_open_from_its_tag_end_up_to_open_max_m: a tunnel 3 m over flatterrain into a ridge. On a steep ridge it is open from each tag end to its portal at the cover's line (10.6 m in);
on a gentle one it is open to 30 m, then hidden until the cover holds.
a_paved_stroke_hides_a_tunnel_station_only_where_it_lies_on_top: a road beside a tunnel, its stroke over thetunnel's middle line, at 2 m under, 0.5 m over and 0.55 m over the floor: only the last hides the tunnel.
Bake time
Box B on 4 cores (
taskset -c 0-3, 5 GB cap): wall 136.2 s, peak 3.6 GB, levels 16.5 s for 10,752 cells, 3,616ways tagged. The rules add no read; the levels pass of an earlier bake of the same box on 4 cores took 15.6 s. No
base bake in this session, so the difference is not measured.
WASM
No device behaviour changes; the bridge's CI size moved by 4 B raw (118 B gzipped) and is recorded as the guard
says. CI on b135e2c measured 806,965 B gzipped against the recorded 806,847 B, and 2,087,266 B raw; 674d660
recorded it, and the next run showed +0 B. After the merge of
ground-planwith the passage rule (#3489, 681070b),CI measured 808,099 B gzipped (-172 B against #3489's recorded 808,271 B) and 2,090,936 B raw (+0 B); 22c58ae
records it.
Checks
obc test -p obc-ground-plan: 137 of 137 pass (the fixture testthe_tiles_carry_the_levels_of_each_cellonthe rebaked fixture).
obc test -p obc-trailview-features: 122 of 122 pass.obc test -p obc-data-steps: 80 of 80 pass. In the new worktree,builder/webhad nonode_modules, so thefirst run failed in the verify step (no Node MVT reader). It passed with the main checkout's
node_moduleslinked.obc exec cargo clippy -p obc-ground-plan -p obc-trailview-features -p obc-data-steps --all-targets -- -D warnings:clean.
cargo fmt --all,obc suites check,obc prose --check: pass.bridge),
obc test affected,obc test full, pictures (no pixel changes).Deviations from the brief and the diagnosis
classifydoes not readtunnel=yeson the ground kinds in this step. It cannot come without a pixelchange. On the device,
classifygives the part its level. A shallow tunnel (a road, path or railway with thetag) would become a tunnel way,
level_tags::splitkeeps a tunnel way's level, and storey 0 draws only groundways: the shallow tunnels would go from the plan. The fixture holds 6 of them (11 copies), the census tiles of
box B 191 copies. Measured: with the reading alone, 11 of the 256 fixture cells change what the viewer reads.
Proposal: this reading comes in step 2, with the split of tunnel ways by their states, so that
the OPEN stretches of a shallow tunnel stay on the ground. 11 census portals have a shallow tunnel at their end;
their counts can move then.
paved stroke forbids it, as before: the cover face cannot lift a paved face. The census effect is that of the
diagnosis's simulation, which did not change the lift either. With the lift read as the diagnosis says, P0692
would open with a path at the floor's height inside its bore (from a trace of its stations, not built).
General forms, not built: enter an arm in the node map only at its way's end station; a way end is a tag end
where a way of another kind (not water) meets it. Measured on box B for the first (not in this pull request): it
opens P0134 and P0215 and closes none, but it changes the levels of 6 deck features (
deck_endsreads the samemap), so it needs its own proof on bridges.
Public docs: unchanged. The spec
specs/trailview-features.md(a contract) says the tunnel states.Mode: change #3345
Requirements: none
🤖 Generated with Claude Code