Skip to content

TrailView ground plan GP12.5: closed faces and hidden stretches: the framed door, tunnels that do not fit, the no-room wall on a tunnel's open stretch #3346

Closed as not planned

Description

@timohueser

Status: proposed
Part of #3105 (GP12, the crossing block of #3096). One pull request into ground-plan.
The steps of the block, in build order: GP12.1 #3342, GP12.2a #3343, GP12.2b #3352, GP12.3a #3344, GP12.3b #3353, GP12.4 #3345, GP12.5 #3346, GP12.6 #3347, GP12.7 #3348, GP12.8 #3349.
Read first: #3105 (words, invariants including the thickness rule, the gallery, the costs, the owner's decisions).
Design on timosPC: /media/timo/OSM1/tmp/ground-plan/crossings/CASES.md (section 4 step 3, case 2 points 2 to 5,
section 8.1), drawings/x1-ladder.svg, c7-subway.svg, c9-shallow-tunnel.svg; the prototype sheets
proto/sheets/S1-1-the-pit.jpg, S1-2-overview.jpg. Short names: gp/ = host/obc-ground-plan/src/, tv/ =
builder/web/src/lib/trailview/.

Goal

Where the heights give no room for an opening, the rider sees a way that ends at a closed, framed, dark door in a
bank: it tells him that the way goes on underneath. A tunnel that does not fit under a town is not drawn there, and
the roads on top are whole. The way down into a tunnel has a bank where there is room and a wall where there is
none; on a path the wall carries a railing.

Depends on / blocks

  • Depends on: GP12.4 (the frame, the end face with an opening, the open cut), GP12.3a and GP12.3b (the shell),
    GP12.2a (the wall top).
  • The places under roads with little cover (R02, W5, R11) depend on GP12.8 part A and its box B rebake: the
    tiles carry the tunnel tag of a shallow tunnel, which GP12.4 reads. Without it the bake turns such a tunnel into a
    ground way with no tag (host/obc-trailview-features/src/bake.rs:345-357), and no state rule sees it.
  • Blocks: nothing in the block (GP12.6 and GP12.7 do not need it).

Design

1. The closed framed door (CASES section 4, step 3; owner: "the closed framed door")

  • Where: at each end of an interrupted way of ladder step 3 (GP12.1: a tunnel way under any way; else the smaller
    way, by the rows of roads.json; a railway never ends), at each closed line where a tunnel way's OPEN stretch meets
    a HIDDEN run (a tag end whose cover is never reached within open_max_m), and at an inverted crossing.
  • Rule: where the whole way stands higher than the interrupted way's end by at least door_min_m (1.0), the end face
    of GP12.2b at that end carries a door: a frame as the portal frame of GP12.4 (jambs 0.7 m, lintel 1.3 m, depth
    0.6 m, coping) about a closed, dark panel recessed by the frame's depth. The door is as tall as r − roof_least_m, at most the bore of the class, and as wide as the interrupted way's paved width. Under 1.0 m there
    is no door: the way ends with GP12.2b's ordinary end, its bank round the end.
  • With no crossing (a closed line where an OPEN stretch meets a HIDDEN run), the "whole way" is storey 0 over the
    closed line, and r is that ground less the floor.
  • Inside a bore, a sheet that ends at a closed line ends with a plain end wall (GP12.4); that is not a door.
  • No new shape: the door is the frame and the end face of GP12.4 with a panel in place of the opening.

2. The no-room wall on every open stretch of a tunnel way (owner: banks where there is room, walls where there is none)

  • The OPEN stretch of a tunnel way is a ground way in a cut (GP12.4). On it every class has the no-room wall
    (Line::wall true there, gp/faces/heights/mod.rs:372): a bank where there is room, a wall up to wall_max_m where
    there is none. The way down into a subway has no room (S1: between a carriageway and a house); a path mouth on a
    meadow has (T14). One rule gives both approved pictures.
  • Construction: the walls are steps of the ground body with GP12.2b's concrete look and GP12.2a's smooth top. On a
    path class a railing of the path stands on the wall's top where the wall is at least WALL_STEP_M (0.5 m,
    tv/plan/piece.wgsl:27) high. The wall top has a coping band.
  • Thickness: where a wall's top stands over the ground beside it, the wall is a closed solid 0.3 m thick (prototype
    variant B at S1) with its coping; the railing's posts and rail are 0.08 m square closed boxes, 1.05 m high.
  • The pit's place: it follows the mapped way. Where the way down runs along a road, between a carriageway and a house
    (S1, LEARNED 3.7), the overlay's ranks keep the pit off the carriageway; nothing moves the way by hand.

3. Hidden stretches (CASES case 2 point 4, 2d)

  • A HIDDEN station draws nothing; storey 0 over it is whole (GP12.1, GP12.4). This section proves it on the places
    under towns, after GP12.8 part A: the tunnel keeps its tag, its stations under the roundabout are HIDDEN, its open
    ends at the tag ends are OPEN cuts within open_max_m or end at a door.

Data and bytes

  • Mesh: the door is a frame and a panel: about 30 triangles (CASES 7.6, a frame). Records: none beyond GP12.4.
  • Values in plan.json structures: door_min_m exists (GP12.1); pit_wall_m 0.3.

Invariants

  1. Every end of an interrupted way is whole: an ordinary end, or an end face with a door. No torn or free-standing
    face. Check: GP12.2b's crate test at end lines, now at closed lines too; the gallery.
  2. Nothing is drawn for a HIDDEN station; storey 0 over it is the same as without the tunnel way. Check: crate test
    on a synthetic tunnel under a junction (faces and heights of storey 0 equal with and without it).
  3. A door never stands over a paved face of the whole way. Check: crate test.
  4. No wall beside a path outside the OPEN stretch of a tunnel way, and none there where a bank has room. An end face
    and a frame are structure faces, not walls. Check: a count of wall-look steps beside path classes over the
    fixture and box B outside such walls: 0.
  5. The door, the pit walls and the railing have their stated thickness and close on every visible side. Check: the
    shell closure test of GP12.3a.

Decisions already made by the owner that apply

  • "No room at all: the closed framed door."
  • With no room at all, a railway never ends; the smaller way ends.
  • One rule for a tunnel's open stretch, a path's too: banks where there is room, walls only where there is none (the
    subway's way down has none). It keeps "Path subway, the way down: concrete walls with a railing" and "Tunnel mouth,
    road and path: the slope cut back as a bank, walls only with no room".
  • Walls on paths: never, except where a tunnel's open stretch has no room for a bank.
  • "End walls and tunnel frames taller than 4.5 m: yes of course."

Not in scope

The heights that would give these places their room (GP12.8). Stairs (the data has steps ways or none; #3106).
Station platforms and their subways' other side (#3106). Lifts, canopies, lamps.

Proofs and pictures required before review

  • The gallery, all 50 places, before and after, one before | after sheet per place with label boxes, a verdict
    table; the implementer opens every sheet.
    • On today's data (step 3 or inverted): S1, S2, S7, W3, R03, R08 must turn BROKEN to whole: the way
      ends at a door (or round, under 1 m), the way on top is whole, no block across a road.
    • Data limits, whole but not true (CASES 8.1): S8, W4 (a subway mouth at a junction or on a platform).
    • After GP12.8 part A and its rebake: R02, W5, R11 whole: no open motorway through the roundabout, no wall
      taller than a house, no box over the junction.
    • S1 on heights that give room (the prototype's heights by hand, or bake c3): the walled way down with the
      railing, against the approved prototype sheet S1-1-the-pit.jpg; and T14 keeps its grass banks (GP12.4).
  • The door at W4 and at two more doors chosen from the census of GP12.1 (one road, one path), eye height and top:
    no render of a door exists yet (HANDBACK 7). The owner sees them.
  • The owner sees the sheets and gives his OK before the merge.

Cost to measure

Base: ground-plan at the branch point. Triangles per door and per pit; cell build time p50 and p95 over the cells
with a door; WASM bytes against the guard; frame on walk, valley-drive, luz (no change expected; report).

Risks and the stop rule

  • Stop and report if the door or the pit needs a shape of its own, a repair pass, or a case distinction by place.
  • Stop and report if a door stands where a real opening is on full heights (a fault of GP12.1's state rule).
  • After two failed review rounds, stop and report.

Requirements: the verification console could not be checked from this PC (no agent token here). The orchestrator sets
the pull request's Requirements: line.

Activity

  1. changed the title [-]TrailView ground plan GP12.5: closed faces and hidden stretches: the framed door, tunnels that do not fit, the walled way down into a path subway[/-] [+]TrailView ground plan GP12.5: closed faces and hidden stretches: the framed door, tunnels that do not fit, the no-room wall on a tunnel's open stretch[/+] on Nov 11, 2026
  2. timohueser commented on Nov 11, 2026

    @timohueser
    OwnerAuthor

    From GP12.1 (PR #3367): what this step can read, and what differs from the plan

    • graph.levels.runs covers every tagged way (non-synthetic deck way, non-water tunnel way) once, in order; untagged ways that end on step 3 also have runs (HIDDEN under the body, OPEN elsewhere). in_level is unchanged.
    • End lines: graph.levels.end_lines (A, Portal, Closed); merged lines list each member way with its station on the merged line, and the members' runs are moved to that station.
    • A bore stroke's wall is edge_band_m in GP12.1's sheets (the block has no wall value): GP12.4 should add one to structures.
    • deck(upper) of an untagged upper way is its deck_least_m.
    • Finding: a tunnel's tag end where the floor lies a few centimetres over the terrain gets a one-sample HIDDEN run and two closed lines (box B: many, e.g. A1 east, p04). The rule "the floor is at or under the terrain" may need a tolerance before doors are drawn (GP12.4, GP12.5).
    • Finding: on box B about a quarter of the decks are on step 2 (thin), by the least room over the paved overlap (at the centre only: about 15 %).
    • WASM: GP12.1 alone takes 25,818 B of gzip, the whole block allowance; the owner decides how the later steps are budgeted.

    Generated by Claude Code

  3. timohueser commented on Nov 12, 2026

    @timohueser
    OwnerAuthor

    Orchestrator note after the merge of GP12.1 (#3367). Earlier notes of the implementer on this issue are stale in three points: the end-line merge, the sheets and the storeys are NOT in the merged step (their code is on the branch claude/gp12-1-later, to arrive with the step that first uses them); the floor-over-terrain tolerance is fixed; the levels stage is not linked into the device build (GP12.3a links it, target at most 12 kB gzip).

    Open points from the delta review (crossings/REVIEW-3367-delta.md) that the step which first DRAWS from the states must close before it draws:

    • D1 (graph/levels.rs about 393-405): a way that joins at a tunnel end is left out of the ground along the whole tunnel, not only near that end. A spiral tunnel or a hairpin over a portal can lose its cover or show OPEN under a road. Limit the exclusion to the reach of the tag end.
    • D2 (about 798-829): the OPEN rule reads only its own graph way. A tunnel that is split a few metres inside the portal can show OPEN after a BORE; check G7 does not catch it.
    • D3: A_MAX_M = 40 m has no stated source, and past it the whole deck way becomes ground; GRID_M holds an unexplained 13.0; the real read reaches 42 m against the 40 m of the reach row.
    • 153 HIDDEN tunnel runs of one sample remain on the test box (was 543). Find their causes before a door is drawn at any of them.

    Generated by Claude Code

  4. timohueser commented on Nov 12, 2026

    @timohueser
    OwnerAuthor

    Correction after the merge of GP12.8 part A (#3382), from its proofs and its review (crossings/REVIEW-3382.md).

    The body of this issue says or implies that part A (the bake keeps the tunnel tag on a tunnel that the shallow rule turns into a ground way) unblocks the gallery places R02 (Kriens), W5 and R11. That is wrong. The motorway tunnels at those three places are of the kind tunnel in every bake (the demo data, round 1 and the new bake); the shallow rule never touched them. Their faults come from the road heights of the demo data and from the old tunnel drawing. On round-1 heights R02 is whole (crossings/gallery/r1-vs-today/).

    What part A does give: on the test box 194 shallow tunnels (mostly short tunnels under buildings) keep their tag, as tunnel=yes on a ground kind, so that the step that draws tunnels can see them. No reader reads that tag today.

    For the step that first reads the tag (#3345): tiles of feature revision 15 that were baked before #3382 do not carry it. That step must depend on a rebake (the revision 16 of #3337 or a later one) or raise the revision itself; otherwise regions on older tiles silently keep their shallow tunnels as ground ways.

    Also wrong in the body of #3349: "or the mapped value" (the tag's value is always yes) and that the ground kinds' keep lists include tunnel (they do not; the tag is written by the shallow rule itself).


    Generated by Claude Code

  5. timohueser commented on Nov 13, 2026

    @timohueser
    OwnerAuthor

    From GP12.3b part A (PR #3470), for GP12.5

    The levels of the way graph (graph::levels) now run in the feature bake (features revision 18), on every zoom-16 cell of each zoom-13 tile with a road way. The zoom-13 tiles carry per road way the tags levels (the states D/B/O/H and the end lines A/P/C, in metres along the stroke), storey and slab (specs/trailview-features.md, Structures). The device reads them with graph::level_tags::read; it does not run graph::levels. The bake uses the rule tables of its own build: a change of a level rule (cover, lift_max_m, open_max_m, the least rooms, the class rows) or of the code of the levels takes a new bake, a new revision and a fixture rebake (make-fixture.py features, about 10 s); the test the_tiles_carry_the_levels_of_each_cell fails until then. A way of a cell margin reads the levels of the cell that owns it, so cells agree by construction. The low zooms carry no level tags.

    For this step: the HIDDEN runs of the ways that end on ladder step 3, untagged ground ways at a stacked crossing included, and their closed lines are in the tags of every cell with a road way.


    Generated by Claude Code

  6. timohueser commented on Nov 14, 2026

    @timohueser
    OwnerAuthor

    GP12.3b part B (#3482) changes what this step builds on:

    • The graph of the storeys (graph::build_levelled, level_tags::split) drops a bridge way's HIDDEN stretch: storey 0
      over it is whole, and the way that stays sees no way there. Tunnel ways are not split yet (GP12.4).
    • An end of a deck is open where a ground way, or a deck on another storey, meets it at a junction or a joint; a
      free end is closed (faces::deck::Decks).

    Generated by Claude Code

  7. timohueser commented on Nov 15, 2026

    @timohueser
    OwnerAuthor

    From GP12.4 step 1 (pull request #3488, the tunnel rules A and B in the bake's levels): the closed tunnel mouths of
    test box B on the tiles of that bake (the census of 1,014 portals, the terrain that the bake reads). 20 stay closed,
    not 19:

    Cause Portals
    No cover within 30 m of the tag end (heights) P0005, P0075, P0171, P0172, P0501, P0539, P0623, P0727, P0820, P1006
    A way on top with too little room at the mouth (heights) P0193, P0295
    A path at the floor's height 1.6 m inside a bore that holds only by the lift (heights) P0692
    A station subway under a platform (a door is right) P0282, P0306
    The levels see no tag end at the portal (a node-map fault and a fork at the portal; see #3345) P0134, P0205, P0215
    Other, as in the diagnosis P0622, P0726

    Data: /media/timo/OSM1/tmp/ground-plan/tunnels/step1/logs/census-head.json, table logs/census-table.md.


    Generated by Claude Code

  8. timohueser commented on Nov 20, 2026

    @timohueser
    OwnerAuthor

    Closed in the backlog cleanup as superseded by #3651. All of this issue is tunnel work. #3651 decides that a tunnel always has an opening and goes through (a free tube end, no doors). Its parts replace the framed door and the no-room wall (P2 #3679, P6 #3683).


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions