You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
levels: a junction that a way runs through overwrites the way's end nodes #3499
Part of the crossing block #3105 (found in tunnel step 1, #3345 / #3488).
The fault
Ctx::new in host/obc-ground-plan/src/graph/levels.rs writes nodes[2 * way + dir] for every arm of every junction. When a way runs through a junction (the junction is not at the way's end), that write replaces the way's real end entry. The levels rules then read a wrong end node for that way.
What it does today
Tunnels: two tunnel mouths of test box B stay closed, because the rules find no tag end at the portal: P0134 and P0215 (census of tunnels/step1/logs/census-table.md).
Bridges: the fix changes the levels of 6 deck features on test box B. Those 6 decks probably have wrong levels today.
Evidence
The implementer of #3488 made the fix in a scratch tree and reverted it, because tunnel step 1 must not move a bridge:
It opens P0134 and P0215 and closes no mouth.
It changes 6 deck features on box B.
Files on the owner PC: /media/timo/OSM1/tmp/ground-plan/tunnels/step1/logs/census-nodefix.json, logs/tags-boxb-nodefix.tsv. The review: tunnels/step1/REVIEW-3488.md, finding N3.
What done looks like
A way's end entries hold its real end nodes; a junction that the way runs through does not change them.
One test for the invariant: a way that runs through a junction keeps both end nodes.
The census of box B: P0134 and P0215 are open, no mouth closes.
The 6 deck features are listed with their levels before and after. Because this moves bridges, the owner sees labelled pictures of these 6 places before the merge.
The features layer revision goes up by one.
Not in this issue: P0205 (two tunnel ways and a deck end at one node; a different cause).
Activity