Repository navigation
trailview: a building passage is never a tunnel, also on older tiles - #3489
Merged
Merged
Conversation
Tiles of an older bake hold a way through a building (`tunnel=building_passage`) as the kind `tunnel` with its tag. The viewer's `lineType` and the plan's `classify` now take such a way as a way of its class on the ground, as develop's viewer does, so no hill, portal or lifted house shows at a gateway. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
The CI build of the bridge with the building-passage rule: 808,271 B gzipped (WASM and glue), 2,090,936 B raw, on stable 1.100.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
timohueser
marked this pull request as ready for review
November 15, 2026 12:58
Owner
Author
Review of #3489 (head 897b4d3, base ground-plan 67092ce)Verdict: MERGE. No blocking finding. Two body corrections and one note for the tunnel step 2 are below. 1. Viewer rule against develop, every reader
2. The crate rule
3. WASM size
4. Tests, comments, body, CI
5. Pictures
Not checked
Generated by Claude Code |
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fault
Tiles of an older bake hold a way through a building (
tunnel=building_passage) as the kindtunnel, with its tag. The viewer ofground-planmakes every feature of kindtunnela tunnel line. At a gateway it then builds a hill, puts a grey portal in front and lifts the house onto the hill.When a live user sees it
The site deploys a new viewer some minutes after a merge into develop. New data goes live only after a separate, approved prod rebake. Between the two, the live site shows the new viewer on older tiles, and users see this fault.
The rule
A feature of kind
tunnelwith the tagtunnel=building_passageis not a bore. It is a way of its class on the ground, and the building stands over it. Develop's viewer has the same rule.builder/web/src/lib/trailview/terrain/bins.ts,lineType: the default path.host/obc-ground-plan/src/graph/parts.rs,classify: the plan path. The kind and the tags reach the crate, so the same rule applies there (the level isGround, notTunnel).New tiles do not hold this form: the current kind table bakes a passage as a way of its class. Thus the change has no effect on new data.
Proof
New viewer with this change (eef1f75; the second commit only records the WASM size), default path, GPU shots at 1920 × 960, views
zebra-taggedandx-tertiary-eye. Pixels whose largest channel differs by more than 8 of 255:ground-planon old dataground-planon theground-planfixtureground-planfixture, the default path does not change (0 px in both views)./media/timo/OSM1/tmp/ground-plan/old-data-house/sheets/fix-zebra-tagged.pngandfix-x-tertiary-eye.png(develop | before | after | fix on its own fixture).Checks
Run:
npx vitest run src/lib/trailview/terrain/bins.test.ts: 43 passed (one new test: a line of kindtunnelwithtunnel=building_passageis a road, one withtunnel=yesis a tunnel).npm run check: 0 errors, 0 warnings.obc test -p obc-ground-plan(one new test onclassify): 136 passed.obc exec cargo clippy -p obc-ground-plan --all-targets -- -D warnings: clean.cargo fmt --all --check: clean.Left out: the other trailview vitest files (CI runs them); the plan path on old data in the viewer (not shot); the other passage houses of the fixture.
WASM
The plan bridge changes by one condition. Its CI size (
wasm-bridgesof the first CI run on eef1f75, stable 1.100.0) is recorded inbuilder/wasm/wasm_size_guard.py, as the guard says:The growth is larger than one string comparison:
classifyhas four callers, and the compiler most likely inlines it into each. I did not measure this.Public docs: not changed.
Mode: change #3096
Requirements: none
🤖 Generated with Claude Code