Repository navigation
test: give the fixture test of the debug mesh a longer time limit - #3497
Conversation
The test builds three real fixture cells and meshes each face alone. It takes several seconds, and it timed out at the default limit of 5 s in a CI run. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Review of #3497: a longer time limit for the fixture test of the debug meshVerdict: MERGE WITH NOTES The change is correct and is the smallest fix. The failure in CI was a busy runner, not a slower test. Findings, by weight1. The time-out is runner load, not a slowdown (strongest evidence)
2. Where the time goes (measured on timosPC, at 8a399ce)Three plain runs of
The PR body says "about 3.5 s on the owner PC". Alone, I measured 2.4–2.6 s; beside the other plan One more run with timers put into the test for a moment (file restored with
The time is in the TypeScript debug mesh ( 3. History: nothing on the hot path changed recently
4. The diff and the comment
5. Is there an equally small change that makes the test cheap?
6. Other tests in
|
| Test | Time |
|---|---|
debug.test.ts > fills each face of real fixture cells to its own area |
2,936 ms |
mesh.test.ts > reads the storeys after a cell mesh ... |
409 ms |
mesh.test.ts > reads a real cell ... |
367 ms |
plan.test.ts > the bridge > names pages of levels 13 and 14, and builds a cell ... |
351 ms |
debug.test.ts > fills a face with its holes and a long strip ... |
266 ms |
| all others | 81 ms or less |
Only the test of this PR is at risk. No other plan/ test needs a longer limit.
What I ran and what I left out
Ran:
gh pr view 3497,gh pr diff 3497,gh pr checksfor ground plan GP12.4 step 1: tunnel rules A and B in the bake's levels (no pixel change) #3488, trailview: a building passage is never a tunnel, also on older tiles #3489 and test: give the fixture test of the debug mesh a longer time limit #3497,gh run view
and the jobs API (job metadata only) for run 43721750361.git logon the test file,debug.ts,builder/ground-plan-wasm,host/obc-ground-planand the
fixture;git diffof the head of ground plan GP12.4 step 1: tunnel rules A and B in the bake's levels (no pixel change) #3488 against 8a399ce on these paths.- In the prepared worktree
/media/timo/OSM1/tmp/ground-plan/develop-doc/notes/wt(8a399ce,
builder/web): three runs ofdebug.test.ts, one run with temporary timers (restored), one run of
the fourplan/test files. All under the 3 GB cap withnice, started with more than 5,600 MB
available and swap on.git statusis clean after the work.
Left out:
- The raw CI log (forbidden), so the per-test time in CI is not known to me.
- Times at older commits (no older bridges built).
- The whole
trailviewvitest folder, other suites,npm run check. - I made no separate worktree under
review-3497/: the prepared worktree had all I needed, and I
changed nothing in it that stayed.
Orchestrator: no code change follows from the review, so there is no delta review. The description now says 2.5 to 3.5 s. The one-pass rewrite of the test (finding 6) is optional and is not done here.
Generated by Claude Code
What
plan/debug.test.ts > fills each face of real fixture cells to its own areagets a time limit of 30 s.Why
The test builds three real fixture cells and meshes each face alone. On the owner PC it takes 2.5 to 3.5 s. In the CI run of #3491 (the merge of
ground-planintodevelop) it timed out at vitest's default limit of 5 s; all other 1,770 tests passed. The test does the same work as before: the limit was too near its normal time.The limit of 30 s is chosen with a wide margin for a busy runner; it is not a measured budget.
Checks
npx vitest run src/lib/trailview/plan/debug.test.ts(throughobc exec): 3 of 3 pass.Public docs do not change.
Mode: change #3096
Requirements: none
🤖 Generated with Claude Code