Repository navigation
fix(skill): create_signing_url never throws NotSignersTurn - #35
Merged
Merged
Conversation
This was referenced Oct 9, 2026
Contributor
Author
|
Self-review (author). No blocking issues found.
Pairs with TurboDocx/Docs#217 (both close out TurboDocx/Docs#213). |
…/Docs#213) The API's only turn refusal is RecipientNotInTurn. Note that the SDK still catches NotSignersTurn for cross-SDK parity so generated code doesn't add handling for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nicolasiscoding
force-pushed
the
fix/213-not-signers-turn-python-ref
branch
from
October 20, 2026 12:24
52dd3cf to
e723ac9
Compare
Member
|
Update: rebased and fact-checked
🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of TurboDocx/Docs#213 (docs fix: TurboDocx/Docs#217).
Why
skills/turbodocx-sdk/references/python.md:497saidcreate_signing_urlthrowsNotSignersTurn. The API never returns it: the only turn refusal isRecipientNotInTurn. The skill generates customer code from this file, so it would write handling for a code that never arrives.What
One sentence:
create_signing_urlthrowsRecipientNotInTurn/RecipientAlreadySigned. It adds that the Python SDK still catches the reservedNotSignersTurnincreate_embedded_signaturefor cross-SDK parity (py-sdk/.../modules/sign.py:41), so generated code shouldn't handle it.Verified
createSigningUrlreturns409 RecipientNotInTurn.NotSignersTurn.🤖 Generated with Claude Code