Skip to content

docs(turbosign): drop NotSignersTurn, the API only returns RecipientNotInTurn - #217

Merged
amitsharma-turbodocx merged 2 commits into
developfrom
fix/213-remove-not-signers-turn
Oct 21, 2026
Merged

amitsharma-turbodocx merged 2 commits into
developfrom
fix/213-remove-not-signers-turn

Conversation

@yacinekahlerras-turbodocx

@yacinekahlerras-turbodocx yacinekahlerras-turbodocx commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Closes #213

Why

The embedded signing docs said createSigningUrl can return HTTP 409 NotSignersTurn. The API never sends it. Its only turn refusal is RecipientNotInTurn. Nothing in the API ever raises NotSignersTurn.

What

  • build/sequential-signers.md: Step 3 prose, the retry code in all six language tabs (the TURN_RACE sets are now a single RecipientNotInTurn comparison), and the Common errors row.
  • index.md and reference.md (2 tables): drop NotSignersTurn from the 409 rows.
  • SDKs are unchanged. They keep NotSignersTurn on purpose for cross-SDK parity.
  • Companion QuickStart skill fix: TurboDocx/quickstart (link below).

Verified

Against a local TurboDocx API and the built site:

  • Live API: asking for signer 2's URL before signer 1 signs returns 409 ConflictError with code RecipientNotInTurn.
  • This page's JS mintNext, run verbatim against that API:
    • Signer 2 asked for too early: retries for 6.5s, then rethrows RecipientNotInTurn.
    • An unknown recipient: throws RecipientNotFound at once, with no retries.
    • After signer 1 really signs in the browser: returns signer 2's URL on the first try.
  • Syntax checks: all six samples pass (TS transpile, py_compile, php -l, gofmt -e, java-parser, ruby -c).
  • Built site:
    • No NotSignersTurn in the HTML of any of the three pages.
    • Every language tab shows the new check.
    • ?language=python still selects the Python tab.
    • No horizontal overflow at 390px, and dark mode checked.
  • Build: docusaurus build passes. The 8 broken-anchor warnings are pre-existing (/docs/SDKs/*#error-handling) and identical on a branch that doesn't touch these pages.

🤖 Generated with Claude Code

Update (2026-10-21): rebased on current develop (after #219), and added 869a440, which also drops NotSignersTurn from the 409 row of Error Codes for Sending and Updating Recipients in API-Signatures.md. That was the last mention in the docs, so git grep NotSignersTurn -- docs now returns nothing. #216 (the earlier draft of this fix, against main) is closed as superseded.

@yacinekahlerras-turbodocx

yacinekahlerras-turbodocx commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Self-review (author). No blocking issues found.

Checked:

  • Completeness: git grep NotSignersTurn over docs/ returns nothing. No leftover "two codes" / "those codes" wording.
  • The six retry samples:
    • Each one now does a single equality check and keeps the same retry count and delay as before.
    • The error accessors are unchanged: err.code, $e->errorCode, conflict.Code, e.getCode(), e.code.
    • Each passes a syntax check in its own language.
    • The JS one, run verbatim against a local TurboDocx API:
      • Signer not yet in turn: retries, then rethrows RecipientNotInTurn.
      • Unknown recipient: throws RecipientNotFound at once.
      • After the earlier signer signs: returns the URL on the first try.
  • Common errors: the "never clears" and RecipientAlreadySigned rows are unchanged.

Notes for reviewers, no change requested:

yacineKahlerras and others added 2 commits October 21, 2026 14:55
…otInTurn (#213)

The embedded-signing pages listed a 409 NotSignersTurn that createSigningUrl never
returns: the only turn refusal is RecipientNotInTurn. Remove it from the error
tables and prose, and retry only RecipientNotInTurn in the six code samples.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…odes too (#213)

The API never returns NotSignersTurn; its only turn refusal is
RecipientNotInTurn. This was the last mention left in the docs.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@amitsharma-turbodocx
amitsharma-turbodocx force-pushed the fix/213-remove-not-signers-turn branch from c64e5a5 to 869a440 Compare October 21, 2026 09:25
@amitsharma-turbodocx
amitsharma-turbodocx merged commit f6d0dec into develop Oct 21, 2026
1 check passed

This branch was successfully deployed

1 active deployment
preview — 869a4404 Deployed Oct 21, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embedded signing docs list a NotSignersTurn 409 the API never returns

3 participants