Repository navigation
docs(embedded-signing): drop NotSignersTurn, API only returns RecipientNotInTurn - #216
Closed
nicolasiscoding wants to merge 1 commit into
Closed
nicolasiscoding wants to merge 1 commit into
nicolasiscoding wants to merge 1 commit into
Conversation
…ipientNotInTurn The turn check emits only RecipientAlreadySigned and RecipientNotInTurn; NotSignersTurn is an unused error-handler mapping. Remove it from the error tables, prose and the six retry samples. Part of #213.
Contributor
|
Closing as superseded by #217, which makes the same fix for #213 and targets #217 removes 🤖 Generated with Claude Code |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #213. Companion: TurboDocx/quickstart TurboDocx/quickstart#34.
What
Removes
NotSignersTurnfrom the embedded-signing pages:build/sequential-signers.md: prose, troubleshooting row, and the turn-race retry in all six language samples (TS, Python, PHP, Go, Java, Ruby). Each sample now retries onlyRecipientNotInTurn.index.mdandreference.md: 409 error-table rows.Verified against the backend (
staging)signingEligibility.tsdefines onlyRecipientAlreadySignedandRecipientNotInTurn;signingRefusalCodeParity.test.tspins exactly those two.NotSignersTurnappears only ascaselabels inSignatureErrorHandler.ts; nothing throws it.signingRefusalCodeParity,signingEligibility,loadSigningEligibilitytests on staging: 3 suites, 32 tests pass.SDKs intentionally keep
NotSignersTurnin their retry lists (cross-SDK parity); untouched.🤖 Generated with Claude Code