Skip to content

fix(skill): create_signing_url never throws NotSignersTurn #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolasiscoding merged 1 commit into from
Oct 20, 2026
Merged

fix(skill): create_signing_url never throws NotSignersTurn #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion skills/turbodocx-sdk/references/python.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ Returns `documentId` plus `recipients`; each entry has `recipientId`, `name`, `e
- `'pending'` — an earlier signer hasn't finished; `embedUrl` is `None`. Re-mint with `create_signing_url` once earlier signers complete.
- `'completed'` — they already signed; `embedUrl` is `None`.

This is one underlying condition seen from both methods: `create_signing_url` **throws** `RecipientNotInTurn` / `NotSignersTurn` / `RecipientAlreadySigned`, while `create_embedded_signature` **catches exactly those codes** and degrades them to `pending` / `completed`. Any other error propagates. An SMS-OTP recipient with no `phone` (E.164) raises `PhoneRequiredForSmsOtp` before the send.
This is one underlying condition seen from both methods: `create_signing_url` **throws** `RecipientNotInTurn` / `RecipientAlreadySigned`, while `create_embedded_signature` **catches those codes** and degrades them to `pending` / `completed`. (The SDK also catches `NotSignersTurn` for cross-SDK parity; it is reserved and the current API never returns it, so don't write handling for it.) Any other error propagates. An SMS-OTP recipient with no `phone` (E.164) raises `PhoneRequiredForSmsOtp` before the send.

### The three identity modes

Expand Down