Skip to content

docs(python): create_signing_url never throws NotSignersTurn - #34

Closed
nicolasiscoding wants to merge 1 commit into
mainfrom
fix/docs-213-not-signers-turn
Closed

nicolasiscoding wants to merge 1 commit into
mainfrom
fix/docs-213-not-signers-turn

Conversation

@nicolasiscoding

@nicolasiscoding nicolasiscoding commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Part of TurboDocx/Docs#213. Companion: TurboDocx/Docs#216

references/python.md said create_signing_url throws NotSignersTurn. The API's only turn refusal when minting a signing URL is 409 RecipientNotInTurn (a signer who already signed gets 409 RecipientAlreadySigned). The line now lists RecipientNotInTurn / RecipientAlreadySigned and notes the SDK still accepts NotSignersTurn as a reserved code (kept in _NOT_IN_TURN_CODES for parity).

🤖 Generated with Claude Code

The API's only turn refusal is RecipientNotInTurn. The SDK still accepts
NotSignersTurn for cross-SDK parity, so say it is reserved. Part of TurboDocx/Docs#213.
@nicolasiscoding

Copy link
Copy Markdown
Member Author

Closing as superseded by #35, which fixes the same python.md sentence and is ready for review.

Both PRs make the same correction, and it holds up: when you mint a signing URL, the API refuses a signer whose turn hasn't come with 409 RecipientNotInTurn and a signer who already signed with 409 RecipientAlreadySigned. It never returns NotSignersTurn. #35's wording is the more accurate of the two. This PR said create_embedded_signature "catches exactly those codes" and then that it "also accepts NotSignersTurn", which contradicts itself. #35 says "catches those codes" and puts the reserved NotSignersTurn in a separate note telling the reader not to write handling for it, which matches the Python SDK (_NOT_IN_TURN_CODES in py-sdk/src/turbodocx_sdk/modules/sign.py). Nothing from this PR needed to be carried over. #35 is rebased onto current main.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant