feat(reports): leftover-map unexplained leftover on grouping comparison graphic (v2.71.0) - #854
Conversation
…on graphic (v2.71.0)
Caption persisted leftover-map unexplained leftover U on the grouping
comparison leftover-map graphic from already-named leftover_map_unexplained
(ADR 0314). Comparison copy uses leftover map comparison graphic unexplained
leftover {label} so it stays distinct from hyphen leftover-map unexplained
leftover {label} and from strip Leftover map comparison unexplained leftover.
A missing or non-finite U omits that caption and keeps leftover-map
cross share, leftover-map unexplained leftover share, leftover-map explained
leftover share, leftover-map reconstruction, leftover-map distance, and
comparison graphic coverage notes. Rank-0 origin cells still name U 0.00
when that leftover is finite. Do not caption leftover residual this increment.
Do not invent U from R and R̂ or leftover-map distance. Never invent a leftover
score. Never invent a theta. No new columns.
|
Copilot review requested on exact head |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Queue retry 2026-08-31T08:01 KST: Full test suite green; Frontend lint/test/build green; Devin Review commented with no issues. Independent APPROVE still required on exact head 935cdea. Do not self-approve. Do not squash onto the unprotected leftover base. Next buyer gap is leftover residual on the grouping comparison leftover-map graphic (distinct comparison-graphic name; residual already on the strip via ADR 0298). |
|
Cycle 2026-08-31 08:19 KST: exact head |
|
Writes work this cycle. #855 ( |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head finding on eb4ffef04677d6e1d67fe1325cfdf1bbb2db2245: this Draft PR still points to old #853 snapshot 11fc346299f9d4a96e4ba397ba373e275af2fce1, while current #853 is fab1cfd587bc6495c9d1084e86774b1378b411c6; the current compare is diverged and #854 is 22 commits behind. ADR 0314 is also marked Accepted although the PR is Draft. After the #840 foundation repair and #853 current-parent reconstruction, rebuild #854 from the current #853 while preserving its unexplained-leftover delta, and set ADR 0314 to Proposed before readiness.
seonghobae
added
enhancement
ChatGPT Codex Connector
Preserve #855 residual-R truth and Proposed ADR 0315 while inheriting repaired ADR 0313/0314 governance through ordinary two-parent non-force convergence.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head re-review: ADR 0314 is now Proposed, and this head preserves the v2.71 persisted-U product delta while inheriting repaired ADR 0313 governance by ordinary two-parent non-force convergence. The PR remains inherited RED because #851 still owns generated-lock parity, 20px small-canvas bounds, and Vietnamese copy failures; no stale validation receipt is transferable.
Preserve the v2.72 residual product delta and the already-adopted compact-canvas layout while making current #854 e34020f an explicit second parent. The resolved tree is the existing #855 exact tree, which already contains the bounded padding/caption behavior; no force rewrite or product delta removal.
Preserve the v2.71 persisted-U delta while adopting exact repaired #853 and regenerating the child lock with repository-authoritative uv.
1 participant
Summary
Caption persisted leftover-map unexplained leftover
Uon the grouping-comparison graphic (ADR 0314 / v2.71.0). Missing/non-finiteUomits only that caption; finite negative and zero values remain visible. No SQL/new columns or new measurement authority.Current exact authority
ef02b1d2fab4f9f7a8db797a29acda93e156847d746bd6a102fa6ec6eb181779369e98cdad7fa34d467b0a865a0661a275b456a1d7ea689755ec3610; second parent is exact repaired feat(reports): leftover-map cross share on grouping comparison graphic (v2.70.0) #853ef02b1d2...Proposed; predecessor acceptance does not transfer across head movementThe live merge result was exercised before promotion. It preserves #854's v2.71 persisted-
Udelta, inherits #853's exact #852 ancestry and Vietnamese explained/unexplained/cross-share semantic repairs, keeps the parent regression files, and regenerates/verifies the editable lock with repository-authoritativeuvat 2.71.0. Focused i18n regressions, lint, production build, and project lock-version parity were GREEN on the promoted workflow-free tree. This does not substitute for normal hosted PR gates, authenticated browser/a11y/performance evidence, or independent review.Descendant convergence
Direct child #855 is still on historical #854
467b0a865a0661a275b456a1d7ea689755ec3610and must adopt746bd6a1...non-force before its v2.72 residual delta can be accepted. Then descendants converge in order. Parent movement is a repair finding, never a reason to close or force-rebase.Product invariants
The v2.71 persisted-
Udelta remains authoritative: missing/non-finiteUomits only its caption; finite zero and negative values remain explicit. Never deriveUfromR,R̂, geometry, rank, coverage, counts, shares, or neighbouring statistics. Canonical KO/EN/JA/ZH/VI/ES/DE/FR translation authority remains the governed Customer Master path.Keep out of normal merge until fresh exact-head repository/security gates, descendant convergence, authenticated browser/a11y/performance evidence, and qualifying independent approval are current. No self-approval, bypass, force-push, destructive rebase, generated-lock hand edit, ancestor skip, or stale-evidence transfer.