feat(reports): leftover observed on grouping comparison graphic (v2.73.0) by seonghobae · Pull Request #856 · ContextualWisdomLab/LineageWeave

seonghobae · 2026-08-30T23:54:13Z

Summary

Caption persisted leftover observed Y on the grouping-comparison leftover-map graphic (ADR 0316 / v2.73.0) without inventing scores or columns. Missing/non-finite Y omits only this caption; finite negative Y remains visible.

Current exact authority

parent/base: feat(reports): leftover residual on grouping comparison graphic (v2.72.0) #855 701c5ba6dde80ffa19a78e57d6321b29328aa1ee
exact head after ordinary non-force convergence: 87de090ead8a39fdf0d12bc1ca5b5c6d3b5ebad0
ADR 0316 remains Proposed; predecessor acceptance does not transfer across head movement

Convergence PR #1004 merged normally into the child branch, preserving the v2.73 observed-Y product delta while adopting the repaired #855→#854→#853 ancestry. Fresh exact-head repository/security/browser/a11y/performance evidence and qualifying independent approval remain required. Direct child #857 has been converged from this exact head through #1005.

No self-approval, bypass, force-push, destructive rebase, generated-lock hand edit, ancestor skip, or stale-evidence transfer.

coderabbitai · 2026-08-30T23:54:20Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 5b8efd22-abda-49f1-b34f-dfc3da731844

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

seonghobae · 2026-08-30T23:54:26Z

Cycle 2026-08-31 08:52 KST: exact head 1a2f11cf (v2.73.0 / ADR 0316 leftover observed on grouping comparison leftover-map graphic). Stacked on #855 @ 4ffed4ae. Independent APPROVE required. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Copilot review requested this cycle. Next buyer increment: leftover expected E on that comparison graphic (ADR 0317 / v2.74.0).

devin-ai-integration

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

seonghobae · 2026-08-30T23:55:57Z

Exact head now c7a8680 stacked on #855 @ 1087b16 (v2.72.0 leftover residual a11y name). Comparison graphic leftover observed uses leftover map comparison graphic leftover observed {label} so it stays distinct from hyphen leftover observed {label} and strip Leftover map comparison observed. Independent APPROVE still required on this leftover-observed increment before squash-merge. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open. Next buyer increment is leftover expected E on this comparison graphic (ADR 0317 / v2.74.0), stacked here — not mixed into #74/#92.

…3.0) Name leftover observed Y on grouping comparison leftover-map pair segments (ADR 0316). After make seed, closest and farthest leftover pairs sit above the member list with leftover observed Y next to leftover residual R on that comparison graphic; click opens that post. Rank-0 unused axes still name Y 0.00 when that persisted leftover observed is finite. A missing or non-finite Y omits that leftover-map comparison graphic observed caption and keeps leftover residual R. Never invent a leftover score. Never invent a theta.

seonghobae · 2026-08-31T00:01:06Z

Rebased onto #855 @ 1087b16 after the leftover residual a11y rename. Head is now cf3b6d4.

Comparison-graphic leftover observed uses distinct accessible name leftover map comparison graphic leftover observed {label} (same leftover-qualifier pattern as residual). Vietnamese copy names the leftover map. Local oxlint 0; 502 tests passed (App 103, LeftoverMapPlot 55, leftoverMapPlotLayout 58, i18n 272, leftoverObservedExpected 9, leftoverResidual 5).

Leave open for independent review. Do not self-approve. Do not squash-merge without independent APPROVE + exact-head required success. Next buyer increment after this residual: leftover expected E on the comparison graphic (ADR 0317 / v2.74.0).

seonghobae · 2026-08-31T00:01:39Z

Independent APPROVE still required on this leftover-observed head c7a8680 (v2.73.0). #857 leftover expected (v2.74.0) is stacked here at 9f34d2c. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Issues #79 and #87 stay open.

devin-ai-integration

Devin Review found 2 new potential issues.

devin-ai-integration · 2026-08-31T00:01:46Z

+                  aria-label={tf(
+                    variant === "comparison"
+                      ? LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_OBSERVED
+                      : LEFTOVER_MAP_PLOT_SEGMENT_OBSERVED,
+                    { label: segment.observedLabel },
+                  )}


📝 Info: Observed values remain data-backed

observedLabel still uses persisted observed_response through its finite-value formatter. The variant branch changes only the accessible name, preserving independent omission.

Was this helpful? React with 👍 or 👎 to provide feedback.

devin-ai-integration · 2026-08-31T00:01:47Z

+                  aria-label={tf(
+                    variant === "comparison"
+                      ? LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_OBSERVED
+                      : LEFTOVER_MAP_PLOT_SEGMENT_OBSERVED,
+                    { label: segment.observedLabel },
+                  )}


📝 Info: Plot variants keep separate labels

The comparison branch receives the new translation key. Report plots retain LEFTOVER_MAP_PLOT_SEGMENT_OBSERVED, so their accessible contract stays unchanged.

Was this helpful? React with 👍 or 👎 to provide feedback.

seonghobae · 2026-08-31T00:03:55Z

Cycle 2026-08-31 08:19 KST: exact head cf3b6d4 (v2.73.0 / ADR 0316 leftover observed on grouping comparison leftover-map graphic). Independent APPROVE still required on this leftover-map stack before any squash-merge. Do not self-approve. Issues #79 and #87 stay open. Do not merge #808 without independent APPROVE. Next buyer increment is leftover-map rank on this comparison graphic after leftover expected (#857 / ADR 0317 / v2.74.0).

Adopt the conflict-free GitHub test-merge tree for exact parent #855 e38c7ca while preserving existing #856 product head cf3b6d4 as first-parent ancestry. No force push and no product delta is dropped.

Adopt the conflict-free GitHub test-merge tree for exact parent #856 dbb3079 while preserving existing #857 product head ade9ed5 as first-parent ancestry. No force push and no product delta is dropped.

seonghobae

Current-head repair finding: ADR 0316 is introduced by this still-Draft PR as Decision status: Accepted. That is premature decision authority before qualifying independent review/normal merge. Preserve the observed-caption product/UI delta, but keep ADR 0316 Proposed while this PR is Draft and add an executable governance regression. The PR body is also stale: live base is #855 at e38c7caf45ed51825eba73047f78052e8d51a431 and live head is dbb30794bdf5af1ae85f2e9e1ea39ba434e9bd14, not the abbreviated older Stack line. No force-push, self-approval, or gate weakening.

Adopt exact parent #855 177c6f5 without rewriting #856. Preserve the #856 product tree and inherit the project/uv lock version-parity RED verbatim. No force push or product delta is dropped.

Adopt exact parent #856 e34f32c without rewriting #857. Preserve the #857 product tree and inherit the project/uv lock version-parity RED verbatim. No force push or product delta is dropped.

Preserve the #857 expected-E product delta and ADR 0317 Proposed repair while adopting exact #856 ADR 0316 Proposed by ordinary two-parent non-force convergence.

Preserve the #856 observed-Y product delta and ADR 0316 Proposed repair while adopting exact #855 ADR 0315 Proposed by ordinary two-parent non-force convergence.

Preserve #857 expected-E truth and ADR 0317 Proposed while inheriting #855/#856 Proposed governance through ordinary two-parent non-force convergence.

Preserve #856 observed-Y truth and ADR 0316 Proposed while inheriting repaired ADR 0314/0315 governance through ordinary two-parent non-force convergence.

Preserve #857 expected-E truth and ADR 0317 Proposed while inheriting repaired ADR 0314/0315/0316 governance through ordinary two-parent non-force convergence.

Preserve #856 observed-Y truth and Proposed ADR 0316 while inheriting repaired ADR 0313/0314/0315 governance through ordinary two-parent non-force convergence.

Preserve #857 expected-E truth and Proposed ADR 0317 while inheriting repaired ADR 0313/0314/0315/0316 governance through ordinary two-parent non-force convergence.

seonghobae

Current-head re-review: ADR 0316 is Proposed and the observed-Y product delta remains intact after non-force convergence through repaired ADR 0313–0315. This is not an acceptance review: #851's generated-lock and UI/i18n REDs still gate the stack, so fresh exact-head evidence is required after the parent is causally GREEN.

Preserve the v2.73 observed-Y product delta and ADR 0316 Proposed while inheriting #855 db9871e as an explicit parent. Semantic resolution applies the already-GREEN compact-canvas layout and keeps the distinct grouping-comparison observed label export. No force rewrite or product delta removal.

Preserve the v2.74 expected-E product delta and ADR 0317 Proposed while inheriting #856 0ff6dee as an explicit parent. Semantic resolution keeps the already-GREEN compact-canvas layout and both distinct comparison observed/expected label exports. No force rewrite or product delta removal.

chore(stack): converge #856 onto repaired #855

chore(stack): converge #857 onto repaired #856

devin-ai-integration Bot reviewed Aug 30, 2026

View reviewed changes

seonghobae force-pushed the feat/leftover-map-compare-plot-observed-v2730 branch from 1a2f11c to c7a8680 Compare August 30, 2026 23:55

seonghobae mentioned this pull request Aug 30, 2026

feat(reports): leftover residual on grouping comparison graphic (v2.72.0) #855

Draft

seonghobae force-pushed the feat/leftover-map-compare-plot-observed-v2730 branch from c7a8680 to cf3b6d4 Compare August 31, 2026 00:00

seonghobae mentioned this pull request Aug 31, 2026

feat(reports): leftover expected on grouping comparison graphic (v2.74.0) #857

Draft

devin-ai-integration Bot reviewed Aug 31, 2026

View reviewed changes

seonghobae marked this pull request as draft September 4, 2026 08:05

chore(stack): converge #856 onto current #855

dbb3079

Adopt the conflict-free GitHub test-merge tree for exact parent #855 e38c7ca while preserving existing #856 product head cf3b6d4 as first-parent ancestry. No force push and no product delta is dropped.

seonghobae commented Sep 6, 2026

View reviewed changes

test(adr): keep draft 0316 proposed

974109a

seonghobae added a commit that referenced this pull request Sep 6, 2026

ci(repair): stage #856 ADR status fix

4bb04c8

seonghobae added enhancement New feature or request priority: medium status: draft type: feature labels Sep 7, 2026 — with ChatGPT Codex Connector

chore(stack): converge #856 onto current #855 RED

e34f32c

Adopt exact parent #855 177c6f5 without rewriting #856. Preserve the #856 product tree and inherit the project/uv lock version-parity RED verbatim. No force push or product delta is dropped.

seonghobae mentioned this pull request Sep 10, 2026

feat(reports): leftover-map explained leftover share on grouping comparison graphic (v2.68.0) #851

Draft

seonghobae added 3 commits September 11, 2026 01:02

fix(release): align runtime package version with v2.73 metadata

4554ac0

chore(stack): converge v2.73 on repaired v2.72 runtime identity

d8f1d71

docs(adr): keep ADR 0316 Proposed while draft

f62b890

seonghobae added a commit that referenced this pull request Sep 10, 2026

chore(stack): converge #857 onto repaired #856

b3157a3

Preserve the #857 expected-E product delta and ADR 0317 Proposed repair while adopting exact #856 ADR 0316 Proposed by ordinary two-parent non-force convergence.

chore(stack): converge #856 onto repaired #855

0ff976b

Preserve the #856 observed-Y product delta and ADR 0316 Proposed repair while adopting exact #855 ADR 0315 Proposed by ordinary two-parent non-force convergence.

seonghobae added a commit that referenced this pull request Sep 10, 2026

chore(stack): reconverge #857 onto repaired #856

8b9b7ce

Preserve #857 expected-E truth and ADR 0317 Proposed while inheriting #855/#856 Proposed governance through ordinary two-parent non-force convergence.

chore(stack): converge #856 onto repaired #855

d966894

Preserve #856 observed-Y truth and ADR 0316 Proposed while inheriting repaired ADR 0314/0315 governance through ordinary two-parent non-force convergence.

seonghobae added a commit that referenced this pull request Sep 10, 2026

chore(stack): converge #857 onto repaired #856

330eb16

Preserve #857 expected-E truth and ADR 0317 Proposed while inheriting repaired ADR 0314/0315/0316 governance through ordinary two-parent non-force convergence.

chore(stack): converge #856 onto repaired #855

9d08f8d

Preserve #856 observed-Y truth and Proposed ADR 0316 while inheriting repaired ADR 0313/0314/0315 governance through ordinary two-parent non-force convergence.

seonghobae added a commit that referenced this pull request Sep 10, 2026

chore(stack): converge #857 onto repaired #856

99a83a6

Preserve #857 expected-E truth and Proposed ADR 0317 while inheriting repaired ADR 0313/0314/0315/0316 governance through ordinary two-parent non-force convergence.

seonghobae commented Sep 10, 2026

View reviewed changes

merge: adopt #855 Vietnamese test-authority repair

e4035cc

seonghobae added a commit that referenced this pull request Sep 10, 2026

merge: adopt #856 Vietnamese test-authority repair

98b303a

seonghobae mentioned this pull request Sep 10, 2026

chore(stack): converge #856 onto repaired #855 #1004

Merged

seonghobae marked this pull request as ready for review September 10, 2026 22:11

chore(stack): converge #856 onto repaired #855

87de090

chore(stack): converge #856 onto repaired #855

seonghobae mentioned this pull request Sep 10, 2026

chore(stack): converge #857 onto repaired #856 #1005

Merged

seonghobae added a commit that referenced this pull request Sep 10, 2026

chore(stack): converge #857 onto repaired #856

38ac253

chore(stack): converge #857 onto repaired #856

seonghobae marked this pull request as draft September 11, 2026 20:19

Navigation Menu

Uh oh!

feat(reports): leftover observed on grouping comparison graphic (v2.73.0) - #856

feat(reports): leftover observed on grouping comparison graphic (v2.73.0)#856
seonghobae wants to merge 13 commits into
feat/leftover-map-compare-plot-residual-v2720from
feat/leftover-map-compare-plot-observed-v2730

seonghobae commented Aug 30, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 30, 2026 •

edited

Loading

Review skipped

Uh oh!

seonghobae commented Aug 30, 2026

Uh oh!

devin-ai-integration Bot left a comment •

edited

Loading

Uh oh!

seonghobae commented Aug 30, 2026

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

devin-ai-integration Bot left a comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

seonghobae left a comment

Uh oh!

seonghobae left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

seonghobae commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Current exact authority

Uh oh!

coderabbitai Bot commented Aug 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

seonghobae commented Aug 30, 2026

Uh oh!

devin-ai-integration Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

✅ Devin Review: No Issues Found

Uh oh!

seonghobae commented Aug 30, 2026

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

devin-ai-integration Bot Aug 31, 2026

Choose a reason for hiding this comment

Uh oh!

seonghobae commented Aug 31, 2026

Uh oh!

seonghobae left a comment

Choose a reason for hiding this comment

Uh oh!

seonghobae left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

seonghobae commented Aug 30, 2026 •

edited

Loading

coderabbitai Bot commented Aug 30, 2026 •

edited

Loading

devin-ai-integration Bot left a comment •

edited

Loading