feat(reports): leftover residual on grouping comparison graphic (v2.72.0) - #855
Conversation
…2.0) Name leftover residual R on grouping comparison leftover-map pair segments (ADR 0315). After make seed, closest and farthest leftover pairs sit above the member list with leftover residual R next to leftover-map unexplained leftover U on that comparison graphic; click opens that post. Rank-0 unused axes still name R 0.00 when that persisted leftover residual is finite. A missing or non-finite R omits that leftover-map comparison graphic residual caption and keeps leftover-map unexplained leftover U. Never invent a leftover score. Never invent a theta.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
Cycle 2026-08-31 08:35 KST: exact head |
|
Stacking leftover observed |
Keep leftover map comparison graphic leftover residual {label} distinct
from leftover residual {label} on the period-report graphic and from
strip Leftover map comparison residual (ADR 0315). Vietnamese copy
names the leftover map. Do not invent R. Never invent a leftover score.
Never invent a theta. No new columns.
|
Exact head now |
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head governance finding: this Draft PR introduces ADR 0315 as Decision status: Accepted. That is the same premature authority defect now being repaired downstream in #856/#857. Preserve the residual-caption product delta and keep ADR 0315, but its decision state must remain Proposed until qualifying independent acceptance/normal merge. Because the shared source foundation is still #841's exact-head RED/repair lane, do not churn descendants or promote downstream governance staging ahead of that foundation; this finding must be carried when the chain is reconstructed non-force. No close, force-push, self-approval, or gate weakening.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head governance finding: this PR is Draft, but docs/adr/0315-leftover-map-compare-plot-residual.md declares **Decision status:** Accepted. The product/ADR delta is valid and should remain open, but acceptance is premature until the unchanged release-ready head has qualifying independent approval and required exact-head evidence. Add an executable governance regression requiring ADR 0315 to remain Proposed, then minimally change only the decision status; preserve the residual semantics, v2.72.0 identity, and descendant stack. Do not close, force-push, self-approve, or transfer predecessor approval.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
RCA for ADR0315 repair run 34012808279: the temporary lane changed the ADR marker to Proposed, then failed before executing the governing test because the harness invoked python -m pytest without installing the repository's locked dev dependencies (No module named pytest). This is a harness failure, not evidence that the ADR repair is product-red. Separately, #855 remains downstream of the stale #840→…→#854 chain, so even a corrected harness result must not be promoted until that parent stack is reconstructed. Re-run the governance test with the normal frozen uv dev environment on the reconstructed exact head.
seonghobae
added
enhancement
ChatGPT Codex Connector
Preserve #856 observed-Y truth and ADR 0316 Proposed while inheriting repaired ADR 0314/0315 governance through ordinary two-parent non-force convergence.
Preserve #855 residual-R truth and Proposed ADR 0315 while inheriting repaired ADR 0313/0314 governance through ordinary two-parent non-force convergence.
Preserve #856 observed-Y truth and Proposed ADR 0316 while inheriting repaired ADR 0313/0314/0315 governance through ordinary two-parent non-force convergence.
seonghobae
left a comment
seonghobae
left a comment
There was a problem hiding this comment.
Current-head re-review: ADR 0315 is Proposed and the v2.72 persisted-R delta survives the non-force convergence onto repaired #854. Acceptance remains inherited RED from #851; generated-lock parity, small-canvas caption bounds, and Vietnamese copy must be repaired at their owner before this child can receive fresh exact-head acceptance.
Preserve the v2.72 residual product delta and the already-adopted compact-canvas layout while making current #854 e34020f an explicit second parent. The resolved tree is the existing #855 exact tree, which already contains the bounded padding/caption behavior; no force rewrite or product delta removal.
1 participant
Summary
Caption persisted leftover residual
Ron the grouping-comparison leftover-map graphic (ADR 0315 / v2.72.0). Missing/non-finiteRomits only this caption; finite negative and zero values remain visible. Consume persisted truth only; do not deriveRfrom Y/E/U/R̂, coordinates, rank, coverage, pair counts, shares, or unused-axis counts.Current exact authority
746bd6a102fa6ec6eb181779369e98cdad7fa34d701c5ba6dde80ffa19a78e57d6321b29328aa1eeProposed; predecessor acceptance does not transfer across this head movementConvergence PR #1003 merged normally into the child branch, preserving the v2.72 residual product delta while adopting #854→#853 repaired ancestry. This is ancestry repair, not product acceptance. Fresh exact-head repository/security/browser/a11y/performance evidence and qualifying independent approval remain required. Direct child #856 has been converged from this exact head through #1004.
No self-approval, bypass, force-push, destructive rebase, generated-lock hand edit, ancestor skip, or stale-evidence transfer.