Skip to content

Bump hashgraph-online/ai-plugin-scanner-action from 1.2.816 to 1.2.817 in the actions group - #960

Merged
zlareb1 merged 4 commits into
mainfrom
dependabot/github_actions/actions-d7fe8920e2
Nov 21, 2026
Merged

zlareb1 merged 4 commits into
mainfrom
dependabot/github_actions/actions-d7fe8920e2

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Why

The plugin scanner uses action bundle 1.2.817. Its commit pin fixes the downloaded action source.

Scope and risk

The scanner action pin moves to 013b123a036a252a6d74ddb52836ee923498150c. The published bundle changes a hash-pinned DNS dependency and release metadata. Job permissions remain read-only, checkout does not persist credentials and the score threshold stays 75. Current main supplies the person-query observation controls and replicated-erasure setup; this branch preserves them unchanged. The net diff contains only the scanner workflow.

Compatibility, rollout and rollback

  • Wire: none.
  • Operator steps: none.
  • Rollback: revert the action pin. No runtime dependency, stored data or migration changes.

Tests

The signed merge contains current main and preserves every preceding feature blob and mode. Focused YAML parsing, exact action-pin, read-only permissions, checkout credential and score-threshold checks pass. The affected workflow passes formatting; committed-range whitespace and body prose checks pass. Full required hosted CI and a fresh independent whole review remain required.

Earlier parser-cost failures remain recorded without a selected cause or a passing rerun. Earlier erasure-fixture results precede changes to the replicated-lease setup on main and do not qualify its current implementation. No performance threshold, workload or failure assertion changes.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex composed the action pin and checked its published source, permissions and workflow controls.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full required hosted checks pass on this head.
  • No wire, migration, plugin behavior or frontend changes.
  • Repository text follows the public-copy rules.
  • Commits are signed off.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Nov 19, 2026
@zlareb1 zlareb1 self-assigned this Nov 19, 2026

@zlareb1 zlareb1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings. The pinned action commit changes its attestation dependency lock and README only. Workflow permissions and scanner inputs are unchanged.

@zlareb1
zlareb1 force-pushed the dependabot/github_actions/actions-d7fe8920e2 branch from ed26861 to cb9cd20 Compare November 20, 2026 20:45
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 21, 2026 6:43am UTC

Request Review

@zlareb1
zlareb1 force-pushed the dependabot/github_actions/actions-d7fe8920e2 branch from cb9cd20 to ff22059 Compare November 20, 2026 22:37

@zlareb1 zlareb1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings. The pinned action changes its attestation dependency lock and README; workflow permissions and scanner inputs stay the same. Checked both fixture changes and their refusal and timeout controls. All 13 focused unit tests and all five replicated-erasure integration tests pass against a private ClickHouse.

@zlareb1
zlareb1 force-pushed the dependabot/github_actions/actions-d7fe8920e2 branch 2 times, most recently from 9e84067 to 07cb861 Compare November 21, 2026 00:08

@zlareb1 zlareb1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking findings. Checked the pinned scanner action source, unchanged read-only permissions, decision-scoped query capture and unbounded-read controls. All 98 focused query-observation, person-policy and ClickHouse-client tests pass.

@zlareb1
zlareb1 force-pushed the dependabot/github_actions/actions-d7fe8920e2 branch from 07cb861 to 1fbad5e Compare November 21, 2026 01:25
dependabot Bot and others added 2 commits November 21, 2026 02:14
Bumps the actions group with 1 update: [hashgraph-online/ai-plugin-scanner-action](https://github.com/hashgraph-online/ai-plugin-scanner-action).


Updates `hashgraph-online/ai-plugin-scanner-action` from 1.2.816 to 1.2.817
- [Release notes](https://github.com/hashgraph-online/ai-plugin-scanner-action/releases)
- [Commits](hashgraph-online/ai-plugin-scanner-action@9b169fc...013b123)

---
updated-dependencies:
- dependency-name: hashgraph-online/ai-plugin-scanner-action
  dependency-version: 1.2.817
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: actions
...

Signed-off-by: dependabot[bot] <support@github.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 57327d5)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the dependabot/github_actions/actions-d7fe8920e2 branch from 1fbad5e to d9cddae Compare November 21, 2026 02:14
Retain the reviewed concern while incorporating current main without rewriting its published history.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Retain the reviewed concern while incorporating current main without rewriting its published history.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 merged commit d6b2b18 into main Nov 21, 2026
49 checks passed
@dependabot
dependabot Bot deleted the dependabot/github_actions/actions-d7fe8920e2 branch November 21, 2026 07:30
zlareb1 added a commit that referenced this pull request Nov 21, 2026
Related: #1090
Related: #1096

### Changelog category

- CI Fix or Improvement (changelog entry is not required)

### Changelog entry

Not required.

### Why

Cost assertions need the process state around each original sample as well as the selected minima. Ingestion fixture failures need the worker attempt's outcome when a dataset read returns the wrong number of datasets.

Record numeric process, wall and thread clocks, allocation counts, GC state, and tracing/profiling state around the original cost calls. Scalar checks, registered lanes, the independent lane-walk child and the SQL ratio check retain their sample values and order. Failure output includes that context.

The workbook fixture's two-dataset assertion reports the actual worker return and observed dataset count. The metadata-edit fixture reports the same fields when its one-dataset assertion fails. A worker return describes that attempt; it does not establish persisted state at the later dataset read. The retrieval-floor fixture reads fixed persisted status fields only when its original readiness assertion fails.

### Scope and risk

Only test code changes. The hook-contract prerequisite waits for its owned detached flusher before removing the sandbox, using the existing isolated-home and child-environment helpers. Its hook deadlines and assertions stay unchanged.

Sample observation runs outside the original timed calls. Boundary deltas include observer work and collection or tracer restoration. Observation can perturb later samples; its fields are diagnostic context, not a cost measure or acceptance criterion. Input text and exception messages are omitted. Context errors record their class without changing the judge.

The lane-walk child emits its original two CPU minima and all six ordered samples. Input sizes, operations, call order, sample counts, minima, warmup, subprocess deadlines, comparison, floor and retry policy stay unchanged. The causes of the Python, Lua, SQL and setup.cfg cost failures remain unknown. This change claims no parser performance fix.

Dataset diagnostics use the existing worker return and dataset response, with no additional I/O, connection, status read, worker attempt or retry. The workbook still requires exactly two datasets, then runs its original unpacking and every sheet, count, rejected-row and served-row assertion. The metadata-edit fixture retains its exact cardinality, metadata, deletion and served-snapshot checks. Only fixed worker-state strings and dataset counts enter the added messages.

The retrieval diagnostic performs one same-scope status lookup with a one-second timeout. It emits whitelisted state, stage and error-code values plus a bounded integer attempt count. Missing or unavailable observations use fixed labels. Stored error messages, source content, metadata and identifiers are excluded from the added messages.

The preserved workbook failure reaches an empty dataset result after successful upload, ingest, extraction and dataset-read HTTP responses. Those responses do not establish the ingestion cause. This change adds failure context and changes no production ingestion behavior.

The retrieval fixture also observes the existing inline retry helper through one test-scoped dispatcher. Per-attempt context matches the trusted scope and originating task, delegates the same objects and awaitable exactly once, and resets before cleanup. Failure messages contain closed exception labels and bounded native numeric codes through at most four cause links. No new I/O, worker attempt, retry or deadline change is introduced. Original ingestion causation remains unknown.

### Compatibility, rollout and rollback

- Wire changes and operator steps: none.
- Rollback: revert the test diagnostics and fixture prerequisites.

### Tests

The current-main composition includes the reviewed scanner action pin from #960. Its workflow file matches main exactly; every preceding concern, generated entry and unchanged support remains byte-identical. Current scoped commands below are new-head results. Earlier CI results and review verdicts do not transfer.

On this current-main composition, all 64 directly related ingestion-observer controls pass. Scoped Ruff, formatting, public prose and committed-range whitespace pass. Three canonical diagnostic files match the independently reviewed ingestion-context source exactly.

Targeted parser-context controls also pass on this head. The prior 47-case aggregate and six Node controls remain retained receipts, not repeated aggregates. Seven cost and Node concern entries remain exact; the shared lane helper combines the unchanged diagnostic sampler nodes with current main's Thrift selectors and samples. A whole-module AST proof verifies that exact composition. The full tree equals current main plus the retained cost diagnostics and three canonical ingestion files. The CPU sampler, judges, floors, thresholds and workloads remain unchanged. Earlier failure-only sample-context and Node deadline controls retain their original evidence; no cause or performance repair is inferred from them.

The retrieval controls preserve strict readiness, scope/task isolation, delegate identity, cancellation, bounded numeric codes, privacy, the ready path and cleanup. Dataset and workbook assertions remain strict. Original hosted ingestion and cost failures are not rerun locally; their causes remain unknown. Earlier CI and review verdicts do not transfer. Fresh independent entire review and full new exact-head hosted CI remain required.

### AI assistance in the code

- AI-generated: Codex wrote the diagnostics and checked the unchanged assertion and timing contracts.

- [x] I can explain every line of this diff and how it interacts with the rest of Loom.

### Checklist

- [x] Focused qualification of the final candidate is complete.
- [ ] Full required CI passes on the eventual public head.
- [ ] A fresh independent whole review is complete on the eventual public head.
- [x] Commits are signed off.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant