Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
test/catalog-send-failure-context
branch
from
November 21, 2026 04:27
339b41e to
027fac3
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #960
Changelog category (leave one):
Changelog entry
Not required.
Why
A catalog-copy integration test can fail during its catalog INSERT before reaching the injected delete cutoff. The public retryable error suppresses the original ClickHouse exception, leaving the underlying error code and carried-column snapshot unavailable.
The test records a fixed exception category, bounded numeric code, and the already available stored-column count and fingerprint when that send fails. It adds the context to the outward exception and raises the same object. This supplies missing evidence; the cause of the observed refusal remains unknown.
Scope and risk
Only the existing retry-copy test and its focused fake-boundary controls change. The observer calls the original sender with the same arguments and preserves its return value and exception. It performs no additional read, connection, write, retry, or worker attempt. Diagnostic notes contain no exception text, SQL, payload, token, identity, or column names.
The original cutoff, retry, deletion and final-row assertions remain. Production code, the carry fence, leases and deadlines are unchanged.
The scanner action pin is inherited from current main at version 1.2.817. The fixture behavior is retained; three comments explain why the diagnostics catch every exception.
Compatibility, rollout and rollback
Prior-source qualification
This composition includes the complete reviewed test prerequisites on current main. The original fixture behavior is preserved; entries supplied identically by main remain inherited support. No previous CI result or review verdict qualifies this head.
Thirteen offline diagnostic controls retain sender call count, arguments, result and exception identity. Metadata stays within the closed label, bounded code, count and fingerprint fields. The earlier scoped commands and outcomes remain bound to their recorded heads on unchanged corresponding source. Full hosted CI and a new independent whole review remain required.
An earlier hosted catalog-copy refusal happened before the intended delete cutoff. Its cause remains unknown; the added context is diagnostic only. An earlier Rust-cost failure remains recorded. No live provider, benchmark, runtime or CI retry was run.
Tests
This composition includes main's grep response fixture and private retirement clock controls. The committed tree preserves every prior concern entry outside those three main paths, with its exact blob and mode. The three main entries match main exactly.
Current local checks pass for the retirement clock's blocked-wait control, syntax of both grep test files, scoped Ruff and formatting of the retirement unit file, public prose and whitespace in the three-path composition. Feature qualification listed above remains historical on unchanged source; those checks were not repeated unless named here. No prior whole review or hosted CI verdict qualifies this head. Full new exact-head hosted CI and a fresh independent whole review remain required before merge. Existing failures and unproven causes remain unresolved; no performance or runtime repair is claimed.
AI assistance in the code (leave one; writing this description with AI is fine):
AI-generated: Codex wrote the diff and checked the send path, exception identities, metadata bounds and original assertion preservation.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist