Skip to content

Platform administrators can read every registered repository - #993

Open
zlareb1 wants to merge 20 commits into
mainfrom
fix/platform-admin-repository-read
Open

zlareb1 wants to merge 20 commits into
mainfrom
fix/platform-admin-repository-read

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Related: #1087
Related: #1041
Related: #1072
Related: #1077
Related: #1096

Changelog category

  • Bug Fix (user-visible misbehavior in a release)

Changelog entry

Platform administrators can inspect configured repositories with their own unrestricted platform token. Repository writes and delegated reads retain their existing grants and token limits.

Why

Repository metadata reads require a namespace viewer grant even when the caller holds unrestricted platform administration rights. The repository read authorization path recognizes that authority only for viewer reads.

Diagnostic prerequisites add bounded observations to failed ingestion assertions. They preserve worker outcomes and the expected results; they do not establish the cause of the hosted failure.

Scope and risk

The exception applies to repository inspection by an undelegated, unrestricted platform administrator. Member writes explicitly opt out. Restricted, delegated and impersonated tokens retain namespace checks. Assistant delegated reads retain their scope ceiling. Restricted serving still requires available classification and the serving kill switch.

The retained prerequisites cover person-query observation, default-comparison work and cleanup timing. The person-query observation source is already present on main. The default comparison computes the canonical mapping once, and cleanup uses one private idle clock for its owner and connection-close budgets. Existing deadlines, refusal controls and behavior assertions remain.

The ingestion diagnostics report bounded status fields, retry categories and allowed native error codes. Retry observation is scoped to the calling task and ingestion identity. Backend messages and source content are excluded.

Documentation distinguishes repository metadata from readable code and populated index status. The restricted-serving help and generated references describe the same administrator viewer exception.

Compatibility, rollout and rollback

No wire fields, setting values, migrations or stored data change. Operator steps: none. Reverting restores the earlier repository inspection requirement and failure messages.

Prior-source qualification

This composition includes the complete reviewed test prerequisites on current main. Every original feature entry is preserved; entries already supplied identically by main remain inherited support. No previous CI result or review verdict qualifies this head.

Platform-administrator repository-read boundaries and their delegated/member-write refusal controls remain. Inherited ingestion diagnostics describe closed error categories without changing readiness or retry assertions. The earlier scoped commands and outcomes remain bound to their recorded heads on unchanged corresponding source. Full hosted CI and a new independent whole review remain required.

An earlier hosted retrieval-floor case left a CSV dataset pending after a retryable backend failure. Its cause remains unproven. The inherited diagnostic source does not claim to repair that failure. No live provider, benchmark, runtime or CI retry was run.

Tests

This composition includes main's grep response fixture and private retirement clock controls. The committed tree preserves every prior concern entry outside those three main paths, with its exact blob and mode. The three main entries match main exactly.

Current local checks pass for the retirement clock's blocked-wait control, syntax of both grep test files, scoped Ruff and formatting of the retirement unit file, public prose and whitespace in the three-path composition. Feature qualification listed above remains historical on unchanged source; those checks were not repeated unless named here. No prior whole review or hosted CI verdict qualifies this head. Full new exact-head hosted CI and a fresh independent whole review remain required before merge. Existing failures and unproven causes remain unresolved; no performance or runtime repair is claimed.

AI assistance in the code

  • AI-generated: Codex wrote the change. The authorization boundaries, preserved source entries, generated descriptions and regression assertions were checked.
  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full required hosted CI passes on the final head.
  • A fresh independent whole review is complete on the final head.
  • Generated settings references, schema descriptions and example comments match the canonical help source.
  • Documentation describes the administrator read exception and token limits.
  • Commits are signed off.

Current-main composition preserves independent human administrator approval for proposals and the stored review-provenance field. Focused local checks on this source are recorded separately; fresh whole-source review and complete exact-head hosted CI are required. Earlier CI failures and their unproven causes remain recorded. No previous review or CI pass qualifies this composition.

Default-comparison refusal coverage includes all 44 protocol defaults, including requires_review, with the existing assertions and encoder bound retained.

@zlareb1
zlareb1 force-pushed the fix/platform-admin-repository-read branch 9 times, most recently from 3a1bc56 to 03f5699 Compare November 20, 2026 21:05
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 21, 2026 11:33am UTC

Request Review

@zlareb1
zlareb1 force-pushed the fix/platform-admin-repository-read branch 6 times, most recently from 46a3a9d to 46b2cb3 Compare November 21, 2026 03:28
Admit repository viewer reads from a platform administrator using its own unscoped authority. Preserve restricted serving, classification, tenancy, delegated-token and write boundaries.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the ordinary namespace and organization limits when member writes check read access.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Cover refused and unavailable provisioning before the platform repository
read exception for both standard and restricted indexes.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 7cd6fe5)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep the blocked close, deadline observers and loop timers on one private
clock. A controlled independent clock advance reproduces the elapsed-time
dependency while the original cleanup and refusal assertions stay intact.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 4b03db4)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Exercise each default-field refusal and JSON numeric distinction before consolidating repeated default comparisons.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 73ef63b)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit cb594d0)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Keep every default-field and JSON type check while avoiding a separate encoder setup for each field.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 0bfc712)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit a94d2f9)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Describe the platform administrator exception beside ordinary direct-grant
requirements and keep the restricted-serving kill switch explicit.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the fix/platform-admin-repository-read branch from 46b2cb3 to 7405fa3 Compare November 21, 2026 03:57
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…hecks

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…ered repository

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant