Skip to content

Python CI helpers install from verified dependency locks - #852

Open
zlareb1 wants to merge 9 commits into
mainfrom
fix/security-dependency-pins
Open

zlareb1 wants to merge 9 commits into
mainfrom
fix/security-dependency-pins

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Related: #1076

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Why

Version constraints alone do not verify downloaded helper packages. CI, release preparation and the course setup install Python tooling from complete hash-checked requirement locks. The SDK packaging matrix uses the existing commit-pinned installer action and shared tool version. The document-parsing benchmark base uses a pinned image digest.

Scope and risk

Current main supplies the person-query observation controls and replicated-erasure setup. This branch preserves them unchanged. The diff contains only the feature described below; no production authorization, lease or erasure rule changes.

This changes helper installation commands and their requirement inputs and generated locks. Runtime server and SDK dependency declarations are unchanged. The adapter tests and the course setup retain their declared dependency ranges as inputs, while their installation locks fix every resolved dependency and artifact hash. Hash checking and binary-only installation fail if a compatible verified wheel is unavailable. The benchmark image digest remains pinned. Its earlier architecture report has not been independently reverified from the original registry response. Sandbox requirement changes trigger the existing image checks.

Compatibility, rollout and rollback

  • Wire: none.
  • Operator steps: none for server deployments. Recompile a helper lock after changing its input requirements; use uv pip compile <input> --generate-hashes --universal --python-version <version> --no-header --no-annotate --output-file <lock> with Python 3.12 for the adapter lock and 3.11 for the other locks.
  • Rollback: reverting restores the helper install commands. No stored data or migration changes.

Prior-source qualification

This composition includes the complete reviewed test prerequisites on current main. Every original feature entry is preserved; entries already supplied identically by main remain inherited support. No previous CI result or review verdict qualifies this head.

Lock and workflow checks verify literal pins, hash syntax, wheel-only refusal commands, workflow triggers and both SDK tag-normalization cases. Original installation and registry reports remain unverified because their raw receipts are unavailable. No dependency-closure, downloaded-wheel or architecture verification is claimed. The earlier scoped commands and outcomes remain bound to their recorded heads on unchanged corresponding source. Full hosted CI and a new independent whole review remain required. No fresh wheel download, registry observation, provider call, benchmark, runtime or CI retry was run.

Tests

This composition includes main's grep response fixture and private retirement clock controls. The committed tree preserves every prior concern entry outside those three main paths, with its exact blob and mode. The three main entries match main exactly.

Current local checks pass for the retirement clock's blocked-wait control, syntax of both grep test files, scoped Ruff and formatting of the retirement unit file, public prose and whitespace in the three-path composition. Feature qualification listed above remains historical on unchanged source; those checks were not repeated unless named here. No prior whole review or hosted CI verdict qualifies this head. Full new exact-head hosted CI and a fresh independent whole review remain required before merge. Existing failures and unproven causes remain unresolved; no performance or runtime repair is claimed.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex changed helper installation commands, generated requirement locks and verified the hashes and workflow syntax.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Full formatting, lint, type and test checks pass in CI.
  • Requirement locks are generated from their inputs; no generated API or schema files change.
  • No wire, migration, plugin behavior or frontend changes.
  • Repository text follows the public-copy rules.
  • Commits are signed off.

Current-main composition preserves independent human administrator approval for proposals and the stored review-provenance field. Focused local checks on this source are recorded separately; fresh whole-source review and complete exact-head hosted CI are required. Earlier CI failures and their unproven causes remain recorded. No previous review or CI pass qualifies this composition.

@zlareb1
zlareb1 force-pushed the fix/security-dependency-pins branch from 94b4ca9 to a0b478a Compare November 20, 2026 20:08
@vercel

vercel Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
loom-docs Ready Ready Preview Nov 21, 2026 11:33am UTC

Request Review

@zlareb1
zlareb1 force-pushed the fix/security-dependency-pins branch 3 times, most recently from 2723496 to be0ec73 Compare November 21, 2026 00:08
Lock complete helper dependency sets and require verified wheels for workflow and course installs. Use the shared pinned uv action for SDK package builds and a multi-platform digest for the document benchmark base.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Route the workflow module invocation through the existing fake installer and assert that helper installs require hashes. Preserve SDK prerelease and final PEP 440 checks.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Shared client schema reads run with an independent context. Record only decision-tagged statements while retaining unbounded decision reads as failures.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
(cherry picked from commit 57327d5)
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
@zlareb1
zlareb1 force-pushed the fix/security-dependency-pins branch from be0ec73 to 0259e12 Compare November 21, 2026 01:59
Retain the reviewed concern while incorporating current main without rewriting its published history.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…dency locks

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant