Repository navigation
Grep fallback tests distinguish responses from pre-dispatch timeouts - #1093
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 of 6 tasks
zlareb1
force-pushed
the
test/grep-shim-response-evidence
branch
3 times, most recently
from
November 21, 2026 03:36
16c9c67 to
cd2a842
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
zlareb1
force-pushed
the
test/grep-shim-response-evidence
branch
from
November 21, 2026 04:56
cd2a842 to
401469d
Compare
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
…m pre-dispatch timeouts Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1072
Changelog category
Changelog entry
Not required.
Why
HTTP startup can consume the lookup deadline before a request reaches the local server. The HTTP cases check bounded native fallback for attempted requests. Controlled child fetches check response handling and abort of a request that entered the pending state.
Scope and risk
Two grep test files separate attempted HTTP fallback from admitted response and abort controls. The existing HTTP cases retain their three modes, mode order, native output and exit checks, 300 ms request deadline and 3000 ms elapsed bound. Those cases do not establish that the server received a request.
A test-only preload supplies refusal and malformed JSON response objects before the shim deadline begins. A stalled mode validates the fetch arguments and live signal, enters a pending promise, and requires the shim signal to abort with
TimeoutError. It records zero JSON calls. A separate 3000 ms fixture watchdog rejects if that abort never arrives; the test rejects watchdog expiry. The abort path clears the watchdog, and the watchdog path removes its abort listener. Every mode retains native output, exit status and the 3000 ms elapsed bound. The response controls retain their invocation, request-argument and JSON parsing assertions. Existing successful annotation cases still exercise real HTTP.The historical macOS failure has no transport-phase trace. This fixes the fixture contract without claiming a measured scheduling cause or a production defect.
The two reviewed person-query fixture files from #1072 are already present on main. Their integration capture snapshots the task-local decision tag before awaiting either query method, excluding unrelated background reads. Decision reads with no timeout remain visible to the unchanged finite-budget assertion. Ten controls cover concurrent schema reads, both query methods, unbounded decision reads and the real decision reader with a fake driver.
Hosted integration CI recorded a 2.5-second captured limit against the 1.75-second ceiling. The log does not identify the offending SQL. The retained fail-first controls reproduce the capture defect; this composition does not establish that run's unique cause or change the assertion.
Compatibility, rollout and rollback
Tests
The current-main composition keeps the existing prerequisites. Only the two grep test files change after the main merge. No previous CI result or review verdict qualifies this head.
Two focused Node cases pass: the attempted HTTP fallback case and the controlled child case covering refusal, malformed JSON and an admitted stalled fetch. The stalled-fetch control first fails against the unsupported fixture, then passes with the abort path. That failing control demonstrates missing deterministic coverage, not a production defect or the historical hosted cause. Node syntax, formatting, prose and committed-range whitespace checks pass. Full hosted CI and a fresh independent whole review remain required.
Earlier hosted Go-cost and translation-worker failures remain recorded; this fixture change does not establish their causes. No live provider, benchmark, runtime or CI retry was run.
AI assistance in the code
AI-generated: Codex investigated the fixture and wrote the response controls.
I can explain every line of this diff and how it interacts with the rest of Loom.
Checklist
Current-main composition preserves independent human administrator approval for proposals and the stored review-provenance field. Focused local checks on this source are recorded separately; fresh whole-source review and complete exact-head hosted CI are required. Earlier CI failures and their unproven causes remain recorded. No previous review or CI pass qualifies this composition.