Repository navigation
[ASIM] Add Salesforce Audit Trail and Login History ingestion-time parsers - #15390
Open
Chencheng Xie (Microsoft) (melmarsezio) wants to merge 6 commits into
Open
Chencheng Xie (Microsoft) (melmarsezio) wants to merge 6 commits into
Chencheng Xie (Microsoft) (melmarsezio) wants to merge 6 commits into
Conversation
Chencheng Xie (Microsoft) (melmarsezio)
requested review from
a team
as code owners
October 21, 2026 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add ingestion-time ASIM normalization for Salesforce Setup Audit Trail and Login History data across both the Microsoft native-table routes and the newer CCF custom-table routes. Each source table receives its own ITP and source-specific validation fixture, while reusing the established query-time parser as the optional parity reference.
Required items, please complete
Change(s):
SalesforceAuditTrailMicrosoft-SentinelSalesforceAuditTrailASimAuditEventLogsASimAuditEventSalesforceAuditTrailSalesforceAuditTrailV2_CLCustom-SalesforceAuditTrailV2_CLASimAuditEventLogsASimAuditEventSalesforceAuditTrailSalesforceLoginHistoryMicrosoft-SentinelSalesforceLoginHistoryASimAuthenticationEventLogsASimAuthenticationSalesforceLoginHistorySalesforceLoginHistoryV2_CLCustom-SalesforceLoginHistoryV2_CLASimAuthenticationEventLogsASimAuthenticationSalesforceLoginHistory{EventVendor}_{EventProduct}_{Schema}_{SourceRawTable}_IngestedLogs.csv.Type.ParserFilterQuery: sourcebehavior for all four routes.Reason for Change(s):
Version Updated:
Testing Completed:
python -m unittest discover -s ".script\tests\asimParsersTest\ingestTimeParser\tests" -p "test_asim_*.py"— Passed, 124 tests.prepare_fixture— Passed; each fixture produced 10 typed rows using the repository table schema.git diff --check origin/master...HEAD— Passed.Known static-validation findings
The fixtures resolve and prepare correctly, but the current static validator reports these parser metadata/stream findings that still need resolution before merge:
META005/META006for all four files becauseParserNamecurrently uses the_ASim_...built-in-function alias format rather than the validator'sASim<Schema>...parser-name format.SOURCE001/SOURCE002for the two native-table routes because their connector stream names areMicrosoft-SentinelSalesforceAuditTrailandMicrosoft-SentinelSalesforceLoginHistory, while the validator currently expectsMicrosoft-{SourceRawTable}and searches connector DCR JSON evidence.Checked that the validations are passing and have addressed any issues that are present: