Repository navigation
[ASIM] Fix ingestion-time parser validation reliability - #15392
Merged
Chencheng Xie (Microsoft) (melmarsezio) merged 3 commits intoOct 22, 2026
Merged
Chencheng Xie (Microsoft) (melmarsezio) merged 3 commits into
Chencheng Xie (Microsoft) (melmarsezio) merged 3 commits into
Conversation
Remove obsolete connector DCR evidence rules, keep validation failures visible in shadow mode, and report fixture preparation as blocked after template failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f180e6f0-55c0-4d78-8707-7ed0bb43c8de
Reject ParserQuery values above Azure's TransformKql limit and attribute DCR creation errors to the correct report stage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f180e6f0-55c0-4d78-8707-7ed0bb43c8de
Chencheng Xie (Microsoft) (melmarsezio)
requested review from
a team
as code owners
October 22, 2026 03:54
Remove non-semantic indentation and line comments outside string literals, use the compacted query for TransformKql, and validate the resulting length. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f180e6f0-55c0-4d78-8707-7ed0bb43c8de
Derrick Lee (yummyblabla)
approved these changes
Oct 22, 2026
Chencheng Xie (Microsoft) (melmarsezio)
merged commit Oct 22, 2026
ec7d33f
into
master
24 checks passed
Chencheng Xie (Microsoft) (melmarsezio)
deleted the
chenchengxie/IngestTimeParserValidationFix
branch
October 22, 2026 22:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
SOURCE001,SOURCE002, andSOURCE004and their repository-scanning helpers.InputStream: nonerequirement as the reorderedSOURCE001.continue-on-errormasking so failed steps, matrix jobs, and the overall workflow remain visibly failed.//comments outside string literals before creating the parser DCR.KQL044when the compactedParserQuerystill exceeds Azure's 15,360-characterTransformKqllimit.shadow-only-failurereport status.Reason for Change(s):
39711879637for [ASIM] Add Salesforce Audit Trail and Login History ingestion-time parsers #15390 exposed two validation gaps:TransformKqlis limited to 15,360 characters.Version Updated:
Testing Completed:
python -m unittest discover -s ".script\tests\asimParsersTest\ingestTimeParser\tests" -p "test_asim_*.py"— Passed, 131 tests.python -m compileall -q .script\tests\asimParsersTest\ingestTimeParser— Passed.python -m pyflakes .script\tests\asimParsersTest\ingestTimeParser— Passed.go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.7 .github\workflows\runAsimIngestionTimeValidation.yaml .github\workflows\runAsimIngestionTimeValidationTests.yaml— Passed.git diff --check— Passed.39711879637through the updated code — Passed:ParserQuerycompacts from 16,612 to 14,257 characters without changing string contents, noKQL044is emitted,rawDcrremains passed with empty detail, and the HTTP 400 detail is assigned only toparserDcr.Checked that the validations are passing and have addressed any issues that are present: