Repository navigation
[ASIM] Decouple parser validation from optional QTP replay - #15401
Merged
Chencheng Xie (Microsoft) (melmarsezio) merged 3 commits intoOct 23, 2026
Merged
Chencheng Xie (Microsoft) (melmarsezio) merged 3 commits into
Chencheng Xie (Microsoft) (melmarsezio) merged 3 commits into
Conversation
Store complete QTP and ITP schemas and rows, derive an intersection schema, persist filtered row sets, and compare parity only across shared typed columns. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f180e6f0-55c0-4d78-8707-7ed0bb43c8de
Include nested provider diagnostics in stage summaries, surface target-output failures as parity failures, and report cleanup warning messages. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f180e6f0-55c0-4d78-8707-7ed0bb43c8de
Chencheng Xie (Microsoft) (melmarsezio)
requested review from
a team
as code owners
October 22, 2026 22:21
Upload typed fixture rows directly through the parser DCR, make InputStream-based QTP source replay optional, preserve parity artifacts with schema consistency checks, and remove obsolete raw-table compatibility code. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f180e6f0-55c0-4d78-8707-7ed0bb43c8de
Maksym Porfirov (mporfirov)
approved these changes
Oct 23, 2026
Chencheng Xie (Microsoft) (melmarsezio)
merged commit Oct 23, 2026
4ba2915
into
master
24 checks passed
Chencheng Xie (Microsoft) (melmarsezio)
deleted the
chenchengxie/IngestTimeParserValidationFix
branch
October 23, 2026 01:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
Type,TenantId, andTitle, while excluding non-replayable Azure-generated fields.ParserFilterQueryagainst an inline typed KQLdatatable.ASimDataTestervalidation before optional QTP replay.InputStreamas the raw DCRoutputStream.qtp_schema,qtp_rows,itp_schema, anditp_rows.intersect_schemaby shared column name and records QTP/ITP types.qtp_rows_filteredanditp_rows_filtered.ASimDataTesteronce per target; successful QTP replay invokes a parity-only validation path.report.json, Markdown summaries, and GitHub annotations:target-outputfailures under parity.Reason for Change(s):
39823143359for [ASIM] Add Salesforce Audit Trail and Login History ingestion-time parsers #15390 showed that required parser execution could be blocked by raw source-table replay limitations unrelated to the parser DCR itself.Microsoft-{SourceRawTable}stream.Version Updated:
Testing Completed:
python -m unittest discover -s ".script\tests\asimParsersTest\ingestTimeParser\tests" -p "test_asim_*.py"— Passed, 138 active tests.python -m compileall -q .script\tests\asimParsersTest\ingestTimeParser— Passed.python -m pyflakes .script\tests\asimParsersTest\ingestTimeParser— Passed.git diff --cached --checkandgit diff --check— Passed before commit.39823143359— Passed; fixture rows, inferred parser-only fields, and YAMLInputStreamvalues were preserved.InvalidStreamand output-stream target details are exposed in the stage summary.Checked that the validations are passing and have addressed any issues that are present: