Repository navigation
[ASIM] Fix replay timestamp and failure handling - #15411
Merged
Chencheng Xie (Microsoft) (melmarsezio) merged 2 commits intoOct 23, 2026
Merged
Chencheng Xie (Microsoft) (melmarsezio) merged 2 commits into
Chencheng Xie (Microsoft) (melmarsezio) merged 2 commits into
Conversation
Normalize returned TimeGenerated values through Kusto ticks and retain observed optional raw-replay schemas, rows, and timestamp counts in validation artifacts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f180e6f0-55c0-4d78-8707-7ed0bb43c8de
Keep raw table and DCR establishment warning-only, but fail the target when optional raw ingestion, QTP execution, or parity fails after the raw DCR is available. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f180e6f0-55c0-4d78-8707-7ed0bb43c8de
Chencheng Xie (Microsoft) (melmarsezio)
requested review from
a team
as code owners
October 23, 2026 18:20
Derrick Lee (yummyblabla)
approved these changes
Oct 23, 2026
Chencheng Xie (Microsoft) (melmarsezio)
merged commit Oct 23, 2026
edbf125
into
master
24 checks passed
Chencheng Xie (Microsoft) (melmarsezio)
deleted the
chenchengxie/IngestTimeParserValidationFix
branch
October 23, 2026 18:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
TimeGeneratedvalue through exact Kusto ticks before comparison or counting:.863843Zand.8638430Zas the same timestamp.validation-result.json:observedSchemaobservedRowsobservedCountsByTimestampReason for Change(s):
39992368738for [ASIM] Add Salesforce Audit Trail and Login History ingestion-time parsers #15390 exposed two validator gaps:2026-10-23T16:24:47.863843Zas outside the expected timestamp set even though it is the same Kusto instant as2026-10-23T16:24:47.8638430Z.Version Updated:
Testing Completed:
python -m unittest discover -s ".script\tests\asimParsersTest\ingestTimeParser\tests" -p "test_asim_*.py"— Passed, 144 tests.python -m compileall -q .script\tests\asimParsersTest\ingestTimeParser— Passed.python -m pyflakes .script\tests\asimParsersTest\ingestTimeParser— Passed.git diff --check— Passed.39992368738— Passed:.863843Zcanonicalizes to.8638430Zand counts against the expected timestamp.qtpSourceReplay.Checked that the validations are passing and have addressed any issues that are present: