Repository navigation
[ASIM] Fix fixture filter serialization and parity - #15402
Merged
Chencheng Xie (Microsoft) (melmarsezio) merged 2 commits intoOct 23, 2026
Merged
Chencheng Xie (Microsoft) (melmarsezio) merged 2 commits into
Chencheng Xie (Microsoft) (melmarsezio) merged 2 commits into
Conversation
Serialize missing string fixture values as empty strings, exclude the platform Type column from parity, and expose actionable schema and row mismatch diagnostics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f180e6f0-55c0-4d78-8707-7ed0bb43c8de
Chencheng Xie (Microsoft) (melmarsezio)
requested review from
a team
as code owners
October 23, 2026 01:57
| ) | ||
| self.assertIn("true, long(null), 1.5", query) | ||
| self.assertNotIn("string(null)", query) | ||
| self.assertTrue(query.count("@''") >= 1) |
List required parser validation stages before optional QTP replay stages and mark raw replay, QTP execution, and parity as optional in the rendered summary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f180e6f0-55c0-4d78-8707-7ed0bb43c8de
Derrick Lee (yummyblabla)
approved these changes
Oct 23, 2026
Chencheng Xie (Microsoft) (melmarsezio)
merged commit Oct 23, 2026
18ccbc6
into
master
24 checks passed
Chencheng Xie (Microsoft) (melmarsezio)
deleted the
chenchengxie/IngestTimeParserValidationFix
branch
October 23, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Required items, please complete
Change(s):
datatableserialization:stringvalues are emitted as empty strings rather than invalidstring(null)expressions.Typecolumn fromintersect_schemaand filtered row comparison.Typein completeqtp_rowsanditp_rowsartifacts for diagnostics.Reason for Change(s):
39882249717for [ASIM] Add Salesforce Audit Trail and Login History ingestion-time parsers #15390 exposed two independent validator defects:string(null), which Kusto could not parse.ASimDataTester, QTP replay, and QTP execution, but parity marked every row missing/extra solely because QTP and native ASIM tables intentionally return differentTypevalues.Typeidentifies the source or physical destination table and is not a normalized semantic field suitable for parity.Query-time and ingestion-time outputs differsummaries did not identify the actual mismatch, even though detailed artifact diagnostics were available.Version Updated:
Testing Completed:
python -m unittest discover -s ".script\tests\asimParsersTest\ingestTimeParser\tests" -p "test_asim_*.py"— Passed, 140 tests.python -m compileall -q .script\tests\asimParsersTest\ingestTimeParser— Passed.python -m pyflakes .script\tests\asimParsersTest\ingestTimeParser— Passed.git diff --check— Passed.39882249717— Passed: regenerated filter queries contain nostring(null)values and serialize missing strings as@''.Typeis excluded from the parity intersection.Checked that the validations are passing and have addressed any issues that are present: