Conversation
This was referenced Sep 14, 2026
jterapin
force-pushed
the
serde-opt/7-compatibility
branch
from
September 14, 2026 18:44
300ae49 to
79d87ea
Compare
jterapin
force-pushed
the
serde-opt/7-compatibility
branch
from
September 14, 2026 19:47
79d87ea to
a616b43
Compare
jterapin
marked this pull request as ready for review
September 14, 2026 20:33
jterapin
added this pull request to stack #370
September 14, 2026 20:34
richardwang1124
approved these changes
Sep 17, 2026
| add_filter 'gems/smithy-client/' | ||
| add_filter 'gems/smithy-json/' | ||
| add_filter 'gems/smithy-schema/' | ||
| skip '/spec/' |
Contributor
There was a problem hiding this comment.
Also I just noticed these, but what does changing add_filter to skip do?
Contributor
Author
There was a problem hiding this comment.
There’s no behavior change. skip is the replacement for the deprecated add_filter API so we won't get annoying SimpleCov warning anymore! :D
jterapin
added a commit
that referenced
this pull request
Sep 21, 2026
## Summary Migrates Smithy client plugins and parameter handling to the cached Schema metadata established by the earlier foundation PRs. - Migrates default parameters, parameter conversion, and validation to cached target-shape and collection metadata. - Uses cached required-member, streaming, host-label, idempotency-token, and event-stream metadata. - Uses cached operation metadata for checksum, host prefix, request compression, retry long-polling, and transfer encoding. - Retains a narrow trait fallback only for non-model operation doubles in retry tests. ## Out of scope - Serde micro-optimizations and compatibility fixes in #367 and #369. - Legacy helper removal in #366. - Staging runtime/regeneration work. ## Validation - smithy-client RBS task: 839 examples, 0 failures, 2 expected pending. - RuboCop and git diff --check passed.
jterapin
added a commit
that referenced
this pull request
Sep 21, 2026
## Summary Removes the obsolete Schema legacy_wire_name compatibility helper after the migrated consumers no longer need it. - Migrates Schema document deserialization to the canonical cached wire index. - Removes legacy_wire_name, its RBS declaration, and focused compatibility coverage. ## Merge order Merge after #367 and #369. GitHub does not allow this existing stacked PR to be retargeted, so it remains based on #365. ## Validation - smithy-schema RBS task: 135 examples, 0 failures. - git diff --check passed.
jterapin
removed this pull request from stack #370
September 21, 2026 17:58
jterapin
force-pushed
the
serde-opt/7-compatibility
branch
from
September 23, 2026 20:06
a616b43 to
b08c5f8
Compare
jterapin
added this pull request to stack #371
September 23, 2026 20:19
jterapin
force-pushed
the
serde-opt/7-compatibility
branch
from
September 23, 2026 20:44
b08c5f8 to
3fc4be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies small runtime, type-signature, and test-setup compatibility fixes on top of #367.
Smithy::Client::Util.Merge order
Merge after #367.
Validation
git diff --checkpassed.