Skip to content

refactor: migrate client consumers to cached schema metadata - #365

Merged
jterapin merged 1 commit into
mainfrom
serde-opt/5-client-consumers
Sep 21, 2026
Merged

jterapin merged 1 commit into
mainfrom
serde-opt/5-client-consumers

Conversation

@jterapin

@jterapin jterapin commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Migrates Smithy client plugins and parameter handling to the cached Schema metadata established by the earlier foundation PRs.

  • Migrates default parameters, parameter conversion, and validation to cached target-shape and collection metadata.
  • Uses cached required-member, streaming, host-label, idempotency-token, and event-stream metadata.
  • Uses cached operation metadata for checksum, host prefix, request compression, retry long-polling, and transfer encoding.
  • Retains a narrow trait fallback only for non-model operation doubles in retry tests.

Out of scope

Validation

  • smithy-client RBS task: 839 examples, 0 failures, 2 expected pending.
  • RuboCop and git diff --check passed.

@jterapin
jterapin added this pull request to stack #362 September 14, 2026 17:44
@jterapin
jterapin force-pushed the serde-opt/5-client-consumers branch from 7496884 to 970989b Compare September 14, 2026 18:09
@jterapin
jterapin force-pushed the serde-opt/5-client-consumers branch 2 times, most recently from 082bc51 to 9db5e87 Compare September 14, 2026 19:46
@jterapin
jterapin marked this pull request as ready for review September 14, 2026 20:34
@jterapin
jterapin requested a review from a team as a code owner September 14, 2026 20:34
@jterapin
jterapin force-pushed the serde-opt/5-client-consumers branch from 9db5e87 to cadaa3e Compare September 21, 2026 16:30
@jterapin
jterapin force-pushed the serde-opt/5-client-consumers branch from cadaa3e to 9c0a439 Compare September 21, 2026 16:46
@jterapin
jterapin force-pushed the serde-opt/5-client-consumers branch from 9c0a439 to cfdf34c Compare September 21, 2026 16:47
Base automatically changed from serde-opt/4-client-http to main September 21, 2026 16:50
@jterapin
jterapin force-pushed the serde-opt/5-client-consumers branch from cfdf34c to ee6aa2e Compare September 21, 2026 16:50
@jterapin
jterapin merged commit bc072a0 into main Sep 21, 2026
10 checks passed
jterapin added a commit that referenced this pull request Sep 21, 2026
## Summary

Removes the obsolete Schema legacy_wire_name compatibility helper after
the migrated consumers no longer need it.

- Migrates Schema document deserialization to the canonical cached wire
index.
- Removes legacy_wire_name, its RBS declaration, and focused
compatibility coverage.

## Merge order

Merge after #367 and #369. GitHub does not allow this existing stacked
PR to be retargeted, so it remains based on #365.

## Validation

- smithy-schema RBS task: 135 examples, 0 failures.
- git diff --check passed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants