Skip to content

refactor: remove legacy schema wire-name helper - #366

Merged
jterapin merged 1 commit into
mainfrom
serde-opt/6-cleanup
Sep 21, 2026
Merged

jterapin merged 1 commit into
mainfrom
serde-opt/6-cleanup

Conversation

@jterapin

@jterapin jterapin commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Removes the obsolete Schema legacy_wire_name compatibility helper after the migrated consumers no longer need it.

  • Migrates Schema document deserialization to the canonical cached wire index.
  • Removes legacy_wire_name, its RBS declaration, and focused compatibility coverage.

Merge order

Merge after #367 and #369. GitHub does not allow this existing stacked PR to be retargeted, so it remains based on #365.

Validation

  • smithy-schema RBS task: 135 examples, 0 failures.
  • git diff --check passed.

@jterapin
jterapin added this pull request to stack #362 September 14, 2026 17:49
@jterapin
jterapin force-pushed the serde-opt/6-cleanup branch 2 times, most recently from 64defa2 to 4e1ddac Compare September 14, 2026 18:00
@jterapin
jterapin marked this pull request as ready for review September 14, 2026 20:34
@jterapin
jterapin requested a review from a team as a code owner September 14, 2026 20:34
Base automatically changed from serde-opt/5-client-consumers to main September 21, 2026 16:50
jterapin added a commit that referenced this pull request Sep 21, 2026
## Summary

Migrates Smithy client plugins and parameter handling to the cached
Schema metadata established by the earlier foundation PRs.

- Migrates default parameters, parameter conversion, and validation to
cached target-shape and collection metadata.
- Uses cached required-member, streaming, host-label, idempotency-token,
and event-stream metadata.
- Uses cached operation metadata for checksum, host prefix, request
compression, retry long-polling, and transfer encoding.
- Retains a narrow trait fallback only for non-model operation doubles
in retry tests.

## Out of scope

- Serde micro-optimizations and compatibility fixes in #367 and #369.
- Legacy helper removal in #366.
- Staging runtime/regeneration work.

## Validation

- smithy-client RBS task: 839 examples, 0 failures, 2 expected pending.
- RuboCop and git diff --check passed.
@jterapin
jterapin merged commit 1179b43 into main Sep 21, 2026
33 checks passed
@jterapin
jterapin deleted the serde-opt/6-cleanup branch September 21, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants