Conversation
jterapin
force-pushed
the
serde-opt/6-optimizations
branch
2 times, most recently
from
September 14, 2026 18:17
44d61ee to
fd298ea
Compare
This was referenced Sep 14, 2026
jterapin
force-pushed
the
serde-opt/6-optimizations
branch
from
September 14, 2026 18:44
fd298ea to
0c30860
Compare
jterapin
force-pushed
the
serde-opt/6-optimizations
branch
from
September 14, 2026 19:47
0c30860 to
85b754e
Compare
jterapin
marked this pull request as ready for review
September 14, 2026 20:34
jterapin
added this pull request to stack #370
September 14, 2026 20:34
| # @return [String, nil] | ||
| def build(shape, data) | ||
| Builder.new(@options).build(shape, data) | ||
| @builder.build(shape, data) |
Contributor
There was a problem hiding this comment.
Could using the same builder each time build is called cause multithreading issues? Previously each time build was called a new Builder was created.
Contributor
Author
There was a problem hiding this comment.
Good callout. I ended up making some changes so that we don't use any per-call state from now on. When we switch protocols, the codecs are re-init.
An error occurred while trying to automatically change base from
serde-opt/5-client-consumers
to
main
September 21, 2026 16:50
jterapin
added a commit
that referenced
this pull request
Sep 21, 2026
## Summary Migrates Smithy client plugins and parameter handling to the cached Schema metadata established by the earlier foundation PRs. - Migrates default parameters, parameter conversion, and validation to cached target-shape and collection metadata. - Uses cached required-member, streaming, host-label, idempotency-token, and event-stream metadata. - Uses cached operation metadata for checksum, host prefix, request compression, retry long-polling, and transfer encoding. - Retains a narrow trait fallback only for non-model operation doubles in retry tests. ## Out of scope - Serde micro-optimizations and compatibility fixes in #367 and #369. - Legacy helper removal in #366. - Staging runtime/regeneration work. ## Validation - smithy-client RBS task: 839 examples, 0 failures, 2 expected pending. - RuboCop and git diff --check passed.
jterapin
added a commit
that referenced
this pull request
Sep 21, 2026
## Summary Removes the obsolete Schema legacy_wire_name compatibility helper after the migrated consumers no longer need it. - Migrates Schema document deserialization to the canonical cached wire index. - Removes legacy_wire_name, its RBS declaration, and focused compatibility coverage. ## Merge order Merge after #367 and #369. GitHub does not allow this existing stacked PR to be retargeted, so it remains based on #365. ## Validation - smithy-schema RBS task: 135 examples, 0 failures. - git diff --check passed.
jterapin
force-pushed
the
serde-opt/6-optimizations
branch
from
September 21, 2026 17:55
85b754e to
91f7cc6
Compare
jterapin
removed this pull request from stack #370
September 21, 2026 17:58
This reverts commit 66931cd.
jterapin
marked this pull request as ready for review
September 23, 2026 20:14
jterapin
added this pull request to stack #371
September 23, 2026 20:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes schema, serde, and client hot paths on top of the merged schema-extension foundation.
Each commit isolates one optimization or correctness follow-up so the changes can be reviewed incrementally.
Review guide
Recommended review order:
Schema and extension metadata
fetch_metadatawhere||=would not memoize them.Serde codecs
DocBuilderthrough each build rather than storing it on the reusable worker.Allocation reductions
Safety and compatibility
Non-goals
Compatibility
The corresponding AWS Query and REST schema-extension changes have merged into
aws-sdk-ruby-stagingversion-4through PRs #76, #77, #78, #80, and #81.Validation
smithy-schema: 137 examples, 0 failures.smithy-json: 69 examples, 0 failures.smithy-xml: 58 examples, 0 failures.smithy-cbor: 268 examples, 0 failures.smithy-client: 889 examples, 0 failures, 2 pre-existing pending.